[GitHub] [plc4x] ottobackwards commented on a diff in pull request #439: Apache Nifi plc4x record processor 2

[GitBox <gi...@apache.org>]

ottobackwards commented on code in PR #439:
URL: https://github.com/apache/plc4x/pull/439#discussion_r941520980


##########
plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/util/Plc4xCommon.java:
##########
@@ -258,34 +259,43 @@ else if (value.isTime())
 	 * @param addresses
 	 * @return
 	 */
-	public static Map<String, String> parseAddressString(String connectionString, PropertyValue addresses){
+	public static Map<String, String> parseAddressString(String connectionString, PropertyValue addressesProp){
 		Map<String, String> addressMap = new HashMap<>();
-		//TODO OPCUA var adresses sintax
+		String addresses = addressesProp.getValue();
+		

Review Comment:
   This is a big yellow warning sign/code smell however you want to call it.
   The insistence on having an option do do something in a way that is more complicated, error prone, and requires this kind of stuff to work is an anti-pattern.
   
   Also, it seems you want to add *more* properties, to help control how this complicated code works, to make it even more complicated.
   
   I will not ask you to change it however.  
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org