You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@archiva.apache.org by ol...@apache.org on 2014/05/13 09:10:50 UTC
git commit: [MRM-1837] so as it's only prototype we can assume
configuration will not change during the use of the bean
Repository: archiva
Updated Branches:
refs/heads/master 76ad886e4 -> 011e7b0ee
[MRM-1837] so as it's only prototype we can assume configuration will not change during the use of the bean
Project: http://git-wip-us.apache.org/repos/asf/archiva/repo
Commit: http://git-wip-us.apache.org/repos/asf/archiva/commit/011e7b0e
Tree: http://git-wip-us.apache.org/repos/asf/archiva/tree/011e7b0e
Diff: http://git-wip-us.apache.org/repos/asf/archiva/diff/011e7b0e
Branch: refs/heads/master
Commit: 011e7b0ee8dd90374f8039567c11f87a9e86de49
Parents: 76ad886
Author: Olivier Lamy <ol...@apache.org>
Authored: Tue May 13 17:08:26 2014 +1000
Committer: Olivier Lamy <ol...@apache.org>
Committed: Tue May 13 17:08:26 2014 +1000
----------------------------------------------------------------------
.../core/ArtifactMissingChecksumsConsumer.java | 16 +++++++++++-----
.../consumers/core/MetadataUpdaterConsumer.java | 12 ++++++++----
2 files changed, 19 insertions(+), 9 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/archiva/blob/011e7b0e/archiva-modules/archiva-base/archiva-consumers/archiva-core-consumers/src/main/java/org/apache/archiva/consumers/core/ArtifactMissingChecksumsConsumer.java
----------------------------------------------------------------------
diff --git a/archiva-modules/archiva-base/archiva-consumers/archiva-core-consumers/src/main/java/org/apache/archiva/consumers/core/ArtifactMissingChecksumsConsumer.java b/archiva-modules/archiva-base/archiva-consumers/archiva-core-consumers/src/main/java/org/apache/archiva/consumers/core/ArtifactMissingChecksumsConsumer.java
index 639ff00..50efbd9 100644
--- a/archiva-modules/archiva-base/archiva-consumers/archiva-core-consumers/src/main/java/org/apache/archiva/consumers/core/ArtifactMissingChecksumsConsumer.java
+++ b/archiva-modules/archiva-base/archiva-consumers/archiva-core-consumers/src/main/java/org/apache/archiva/consumers/core/ArtifactMissingChecksumsConsumer.java
@@ -50,7 +50,9 @@ import java.util.List;
@Scope( "prototype" )
public class ArtifactMissingChecksumsConsumer
extends AbstractMonitoredConsumer
- implements KnownRepositoryContentConsumer, RegistryListener
+ implements KnownRepositoryContentConsumer
+ // it's prototype bean so we assume configuration won't change during a run
+ //, RegistryListener
{
private String id = "create-missing-checksums";
@@ -78,7 +80,7 @@ public class ArtifactMissingChecksumsConsumer
this.configuration = configuration;
this.filetypes = filetypes;
- configuration.addChangeListener( this );
+ //configuration.addChangeListener( this );
initIncludes();
}
@@ -197,6 +199,7 @@ public class ArtifactMissingChecksumsConsumer
}
}
+ /*
@Override
public void afterConfigurationChange( Registry registry, String propertyName, Object propertyValue )
{
@@ -206,22 +209,25 @@ public class ArtifactMissingChecksumsConsumer
}
}
+
@Override
public void beforeConfigurationChange( Registry registry, String propertyName, Object propertyValue )
{
- /* do nothing */
+ // do nothing
}
+ */
+
private void initIncludes()
{
- includes = new ArrayList<String>( filetypes.getFileTypePatterns( FileTypes.ARTIFACTS ) );
+ includes = new ArrayList<>( filetypes.getFileTypePatterns( FileTypes.ARTIFACTS ) );
}
@PostConstruct
public void initialize()
{
- configuration.addChangeListener( this );
+ //configuration.addChangeListener( this );
initIncludes();
}
http://git-wip-us.apache.org/repos/asf/archiva/blob/011e7b0e/archiva-modules/archiva-base/archiva-consumers/archiva-core-consumers/src/main/java/org/apache/archiva/consumers/core/MetadataUpdaterConsumer.java
----------------------------------------------------------------------
diff --git a/archiva-modules/archiva-base/archiva-consumers/archiva-core-consumers/src/main/java/org/apache/archiva/consumers/core/MetadataUpdaterConsumer.java b/archiva-modules/archiva-base/archiva-consumers/archiva-core-consumers/src/main/java/org/apache/archiva/consumers/core/MetadataUpdaterConsumer.java
index cb1f78f..8e23483 100644
--- a/archiva-modules/archiva-base/archiva-consumers/archiva-core-consumers/src/main/java/org/apache/archiva/consumers/core/MetadataUpdaterConsumer.java
+++ b/archiva-modules/archiva-base/archiva-consumers/archiva-core-consumers/src/main/java/org/apache/archiva/consumers/core/MetadataUpdaterConsumer.java
@@ -61,7 +61,9 @@ import java.util.List;
@Scope( "prototype" )
public class MetadataUpdaterConsumer
extends AbstractMonitoredConsumer
- implements KnownRepositoryContentConsumer, RegistryListener
+ implements KnownRepositoryContentConsumer
+ // it's prototype bean so we assume configuration won't change during a run
+ //, RegistryListener
{
private Logger log = LoggerFactory.getLogger( MetadataUpdaterConsumer.class );
@@ -292,6 +294,7 @@ public class MetadataUpdaterConsumer
return false;
}
+ /*
@Override
public void afterConfigurationChange( Registry registry, String propertyName, Object propertyValue )
{
@@ -304,18 +307,19 @@ public class MetadataUpdaterConsumer
@Override
public void beforeConfigurationChange( Registry registry, String propertyName, Object propertyValue )
{
- /* do nothing here */
+ // do nothing here
}
+ */
private void initIncludes()
{
- includes = new ArrayList<String>( filetypes.getFileTypePatterns( FileTypes.ARTIFACTS ) );
+ includes = new ArrayList<>( filetypes.getFileTypePatterns( FileTypes.ARTIFACTS ) );
}
@PostConstruct
public void initialize()
{
- configuration.addChangeListener( this );
+ //configuration.addChangeListener( this );
initIncludes();
}