[GitHub] [druid] rash67 commented on a diff in pull request #13048: Compressed Big Decimal Cleanup and Extension

[GitBox <gi...@apache.org>]

rash67 commented on code in PR #13048:
URL: https://github.com/apache/druid/pull/13048#discussion_r967353301


##########
extensions-contrib/compressed-bigdecimal/src/main/java/org/apache/druid/compressedbigdecimal/CompressedBigDecimal.java:
##########
@@ -266,15 +262,27 @@ protected static <S> int signumInternal(int size, S rhs, ToIntBiFunction<S, Inte
    * @see java.lang.Comparable#compareTo(java.lang.Object)
    */
   @Override
-  public int compareTo(CompressedBigDecimal<T> o)
+  public int compareTo(CompressedBigDecimal o)
   {
 
-    if (this.equals(o)) {
+    if (super.equals(o)) {

Review Comment:
   oops, it was a hangover from when i was changing this.equals() and it wanted to do identity check (and java won't let you use == for Number identity check due to auto-unboxing ambiguity and CBD extends Number...
   
   will revert



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org