You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/06 18:18:20 UTC
[GitHub] [incubator-superset] etr2460 opened a new pull request #9755: Revert "FilterBox,BigNumber,WorldMap: Handle empty results"
etr2460 opened a new pull request #9755:
URL: https://github.com/apache/incubator-superset/pull/9755
Reverts apache/incubator-superset#9671
Unfortunately this breaks filterboxes with only a time range filter. I'm reverting for now, but it should be pretty easy to fix and re-PR out.
cc: @villebro @elukey @graceguo-supercat
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] elukey commented on pull request #9755: Revert "FilterBox,BigNumber,WorldMap: Handle empty results"
Posted by GitBox <gi...@apache.org>.
elukey commented on pull request #9755:
URL: https://github.com/apache/incubator-superset/pull/9755#issuecomment-624822835
ah snap really sorry, will try to re-work the PR! :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on pull request #9755: Revert "FilterBox,BigNumber,WorldMap: Handle empty results"
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #9755:
URL: https://github.com/apache/incubator-superset/pull/9755#issuecomment-624810958
Attach a time-range filter:
<img width="197" alt="Screen Shot 2020-05-06 at 11 20 02 AM" src="https://user-images.githubusercontent.com/27990562/81213665-91f1f200-8f8b-11ea-9392-3f3dd43ee589.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org