You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Kevin Sweeney <ke...@apache.org> on 2014/10/17 00:56:38 UTC

Review Request 26836: Draft of cron documentation

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26836/
-----------------------------------------------------------

Review request for Aurora, Maxim Khutornenko and Bill Farner.


Bugs: AURORA-440
    https://issues.apache.org/jira/browse/AURORA-440


Repository: aurora


Description
-------

Initial shot at cron documentation.


Diffs
-----

  docs/configuration-reference.md 83d0d104554753dab939bf8d25b83e9adb00758a 
  docs/cron-jobs.md PRE-CREATION 

Diff: https://reviews.apache.org/r/26836/diff/


Testing
-------


Thanks,

Kevin Sweeney

Re: Review Request 26836: Draft of cron documentation

Posted by Kevin Sweeney <ke...@apache.org>.

> On Oct. 16, 2014, 4:10 p.m., Bill Farner wrote:
> > docs/cron-jobs.md, line 99
> > <https://reviews.apache.org/r/26836/diff/1/?file=723471#file723471line99>
> >
> >     s/remember/record/

fixed


> On Oct. 16, 2014, 4:10 p.m., Bill Farner wrote:
> > docs/cron-jobs.md, line 90
> > <https://reviews.apache.org/r/26836/diff/1/?file=723471#file723471line90>
> >
> >     s/ (subject to change)//

fixed


> On Oct. 16, 2014, 4:10 p.m., Bill Farner wrote:
> > docs/cron-jobs.md, line 47
> > <https://reviews.apache.org/r/26836/diff/1/?file=723471#file723471line47>
> >
> >     I don't grok this sentence.  Reword or nuke.

nuked


> On Oct. 16, 2014, 4:10 p.m., Bill Farner wrote:
> > docs/cron-jobs.md, line 10
> > <https://reviews.apache.org/r/26836/diff/1/?file=723471#file723471line10>
> >
> >     I suggest using 4-space indent for better readability in plaintext.  Ditto throughout.

changed.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26836/#review57032
-----------------------------------------------------------


On Oct. 16, 2014, 4:21 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26836/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 4:21 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-440
>     https://issues.apache.org/jira/browse/AURORA-440
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Initial shot at cron documentation.
> 
> 
> Diffs
> -----
> 
>   docs/configuration-reference.md 83d0d104554753dab939bf8d25b83e9adb00758a 
>   docs/cron-jobs.md PRE-CREATION 
>   examples/jobs/cron_hello_world.aurora PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26836/diff/
> 
> 
> Testing
> -------
> 
> Pushed to https://github.com/kevints/incubator-aurora/blob/kts/cron-docs/docs/cron-jobs.md
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 26836: Draft of cron documentation

Posted by Kevin Sweeney <ke...@apache.org>.

> On Oct. 16, 2014, 4:10 p.m., Bill Farner wrote:
> > docs/cron-jobs.md, line 9
> > <https://reviews.apache.org/r/26836/diff/1/?file=723471#file723471line9>
> >
> >     This is slightly confusing, i thought this file existed in the repo.  Can you reword to make it obvious that the user is to _create_ this file?

This is actually a bug in the patch - updated patch forthcoming.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26836/#review57032
-----------------------------------------------------------


On Oct. 16, 2014, 3:57 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26836/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 3:57 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-440
>     https://issues.apache.org/jira/browse/AURORA-440
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Initial shot at cron documentation.
> 
> 
> Diffs
> -----
> 
>   docs/configuration-reference.md 83d0d104554753dab939bf8d25b83e9adb00758a 
>   docs/cron-jobs.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26836/diff/
> 
> 
> Testing
> -------
> 
> Pushed to https://github.com/kevints/incubator-aurora/blob/kts/cron-docs/docs/cron-jobs.md
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 26836: Draft of cron documentation

Posted by Kevin Sweeney <ke...@apache.org>.

> On Oct. 16, 2014, 4:10 p.m., Bill Farner wrote:
> > docs/cron-jobs.md, line 9
> > <https://reviews.apache.org/r/26836/diff/1/?file=723471#file723471line9>
> >
> >     This is slightly confusing, i thought this file existed in the repo.  Can you reword to make it obvious that the user is to _create_ this file?
> 
> Kevin Sweeney wrote:
>     This is actually a bug in the patch - updated patch forthcoming.
> 
> Bill Farner wrote:
>     Aha, i thought that might be the case.  Now i'll post my original concern: these files will drift.  Since we lack a means to include the file contents, consider linking to it instead.

I think the inline example greatly enhances readability here, so this is a DRY violation I'm willing to live with


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26836/#review57032
-----------------------------------------------------------


On Oct. 16, 2014, 4:32 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26836/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 4:32 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-440
>     https://issues.apache.org/jira/browse/AURORA-440
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Initial shot at cron documentation.
> 
> 
> Diffs
> -----
> 
>   docs/configuration-reference.md 83d0d104554753dab939bf8d25b83e9adb00758a 
>   docs/cron-jobs.md PRE-CREATION 
>   examples/jobs/cron_hello_world.aurora PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26836/diff/
> 
> 
> Testing
> -------
> 
> Pushed to https://github.com/kevints/incubator-aurora/blob/kts/cron-docs/docs/cron-jobs.md
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 26836: Draft of cron documentation

Posted by Bill Farner <wf...@apache.org>.

> On Oct. 16, 2014, 11:10 p.m., Bill Farner wrote:
> > docs/cron-jobs.md, line 9
> > <https://reviews.apache.org/r/26836/diff/1/?file=723471#file723471line9>
> >
> >     This is slightly confusing, i thought this file existed in the repo.  Can you reword to make it obvious that the user is to _create_ this file?
> 
> Kevin Sweeney wrote:
>     This is actually a bug in the patch - updated patch forthcoming.

Aha, i thought that might be the case.  Now i'll post my original concern: these files will drift.  Since we lack a means to include the file contents, consider linking to it instead.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26836/#review57032
-----------------------------------------------------------


On Oct. 16, 2014, 11:32 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26836/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 11:32 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-440
>     https://issues.apache.org/jira/browse/AURORA-440
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Initial shot at cron documentation.
> 
> 
> Diffs
> -----
> 
>   docs/configuration-reference.md 83d0d104554753dab939bf8d25b83e9adb00758a 
>   docs/cron-jobs.md PRE-CREATION 
>   examples/jobs/cron_hello_world.aurora PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26836/diff/
> 
> 
> Testing
> -------
> 
> Pushed to https://github.com/kevints/incubator-aurora/blob/kts/cron-docs/docs/cron-jobs.md
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 26836: Draft of cron documentation

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26836/#review57032
-----------------------------------------------------------

Ship it!



docs/cron-jobs.md
<https://reviews.apache.org/r/26836/#comment97494>

    This is slightly confusing, i thought this file existed in the repo.  Can you reword to make it obvious that the user is to _create_ this file?



docs/cron-jobs.md
<https://reviews.apache.org/r/26836/#comment97500>

    I suggest using 4-space indent for better readability in plaintext.  Ditto throughout.



docs/cron-jobs.md
<https://reviews.apache.org/r/26836/#comment97496>

    I don't grok this sentence.  Reword or nuke.



docs/cron-jobs.md
<https://reviews.apache.org/r/26836/#comment97501>

    s/ (subject to change)//



docs/cron-jobs.md
<https://reviews.apache.org/r/26836/#comment97502>

    s/remember/record/


- Bill Farner


On Oct. 16, 2014, 10:57 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26836/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 10:57 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-440
>     https://issues.apache.org/jira/browse/AURORA-440
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Initial shot at cron documentation.
> 
> 
> Diffs
> -----
> 
>   docs/configuration-reference.md 83d0d104554753dab939bf8d25b83e9adb00758a 
>   docs/cron-jobs.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26836/diff/
> 
> 
> Testing
> -------
> 
> Pushed to https://github.com/kevints/incubator-aurora/blob/kts/cron-docs/docs/cron-jobs.md
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 26836: Draft of cron documentation

Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26836/#review57058
-----------------------------------------------------------

Ship it!



docs/cron-jobs.md
<https://reviews.apache.org/r/26836/#comment97539>

    Header and TOC would be great here.


- Maxim Khutornenko


On Oct. 16, 2014, 11:32 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26836/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 11:32 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-440
>     https://issues.apache.org/jira/browse/AURORA-440
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Initial shot at cron documentation.
> 
> 
> Diffs
> -----
> 
>   docs/configuration-reference.md 83d0d104554753dab939bf8d25b83e9adb00758a 
>   docs/cron-jobs.md PRE-CREATION 
>   examples/jobs/cron_hello_world.aurora PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26836/diff/
> 
> 
> Testing
> -------
> 
> Pushed to https://github.com/kevints/incubator-aurora/blob/kts/cron-docs/docs/cron-jobs.md
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 26836: Draft of cron documentation

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26836/#review57079
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On Oct. 17, 2014, 12:36 a.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26836/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2014, 12:36 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-440
>     https://issues.apache.org/jira/browse/AURORA-440
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Initial shot at cron documentation.
> 
> 
> Diffs
> -----
> 
>   docs/configuration-reference.md 83d0d104554753dab939bf8d25b83e9adb00758a 
>   docs/cron-jobs.md PRE-CREATION 
>   examples/jobs/cron_hello_world.aurora PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26836/diff/
> 
> 
> Testing
> -------
> 
> Pushed to https://github.com/kevints/incubator-aurora/blob/kts/cron-docs/docs/cron-jobs.md
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 26836: Cron documentation

Posted by Jay Buffington <me...@jaybuff.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26836/#review57144
-----------------------------------------------------------



docs/cron-jobs.md
<https://reviews.apache.org/r/26836/#comment97615>

    I'd add a link here like this:
    
    The full specification for cron_schedule is [described below(however you anchor link to "## Technical Note About Syntax")



docs/cron-jobs.md
<https://reviews.apache.org/r/26836/#comment97614>

    s/indepdendently/independently/


- Jay Buffington


On Oct. 17, 2014, 12:43 a.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26836/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2014, 12:43 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-440
>     https://issues.apache.org/jira/browse/AURORA-440
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Cron documentation.
> 
> 
> Diffs
> -----
> 
>   docs/configuration-reference.md 83d0d104554753dab939bf8d25b83e9adb00758a 
>   docs/cron-jobs.md PRE-CREATION 
>   examples/jobs/cron_hello_world.aurora PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26836/diff/
> 
> 
> Testing
> -------
> 
> Pushed to https://github.com/kevints/incubator-aurora/blob/kts/cron-docs/docs/cron-jobs.md
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 26836: Cron documentation

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26836/#review57252
-----------------------------------------------------------


Sorry Jay, I'll address your feedback in a subsequent review.

- Kevin Sweeney


On Oct. 16, 2014, 5:43 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26836/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 5:43 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-440
>     https://issues.apache.org/jira/browse/AURORA-440
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Cron documentation.
> 
> 
> Diffs
> -----
> 
>   docs/configuration-reference.md 83d0d104554753dab939bf8d25b83e9adb00758a 
>   docs/cron-jobs.md PRE-CREATION 
>   examples/jobs/cron_hello_world.aurora PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26836/diff/
> 
> 
> Testing
> -------
> 
> Pushed to https://github.com/kevints/incubator-aurora/blob/kts/cron-docs/docs/cron-jobs.md
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 26836: Cron documentation

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26836/
-----------------------------------------------------------

(Updated Oct. 16, 2014, 5:43 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
-------

Update cron documentation.


Summary (updated)
-----------------

Cron documentation


Bugs: AURORA-440
    https://issues.apache.org/jira/browse/AURORA-440


Repository: aurora


Description (updated)
-------

Cron documentation.


Diffs
-----

  docs/configuration-reference.md 83d0d104554753dab939bf8d25b83e9adb00758a 
  docs/cron-jobs.md PRE-CREATION 
  examples/jobs/cron_hello_world.aurora PRE-CREATION 

Diff: https://reviews.apache.org/r/26836/diff/


Testing
-------

Pushed to https://github.com/kevints/incubator-aurora/blob/kts/cron-docs/docs/cron-jobs.md


Thanks,

Kevin Sweeney

Re: Review Request 26836: Draft of cron documentation

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26836/
-----------------------------------------------------------

(Updated Oct. 16, 2014, 5:36 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
-------

Add overview and ToC


Bugs: AURORA-440
    https://issues.apache.org/jira/browse/AURORA-440


Repository: aurora


Description
-------

Initial shot at cron documentation.


Diffs (updated)
-----

  docs/configuration-reference.md 83d0d104554753dab939bf8d25b83e9adb00758a 
  docs/cron-jobs.md PRE-CREATION 
  examples/jobs/cron_hello_world.aurora PRE-CREATION 

Diff: https://reviews.apache.org/r/26836/diff/


Testing
-------

Pushed to https://github.com/kevints/incubator-aurora/blob/kts/cron-docs/docs/cron-jobs.md


Thanks,

Kevin Sweeney

Re: Review Request 26836: Draft of cron documentation

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26836/
-----------------------------------------------------------

(Updated Oct. 16, 2014, 4:32 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
-------

Fix example.


Bugs: AURORA-440
    https://issues.apache.org/jira/browse/AURORA-440


Repository: aurora


Description
-------

Initial shot at cron documentation.


Diffs (updated)
-----

  docs/configuration-reference.md 83d0d104554753dab939bf8d25b83e9adb00758a 
  docs/cron-jobs.md PRE-CREATION 
  examples/jobs/cron_hello_world.aurora PRE-CREATION 

Diff: https://reviews.apache.org/r/26836/diff/


Testing
-------

Pushed to https://github.com/kevints/incubator-aurora/blob/kts/cron-docs/docs/cron-jobs.md


Thanks,

Kevin Sweeney

Re: Review Request 26836: Draft of cron documentation

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26836/
-----------------------------------------------------------

(Updated Oct. 16, 2014, 4:29 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
-------

Bill's feedback


Bugs: AURORA-440
    https://issues.apache.org/jira/browse/AURORA-440


Repository: aurora


Description
-------

Initial shot at cron documentation.


Diffs (updated)
-----

  docs/configuration-reference.md 83d0d104554753dab939bf8d25b83e9adb00758a 
  docs/cron-jobs.md PRE-CREATION 
  examples/jobs/cron_hello_world.aurora PRE-CREATION 

Diff: https://reviews.apache.org/r/26836/diff/


Testing
-------

Pushed to https://github.com/kevints/incubator-aurora/blob/kts/cron-docs/docs/cron-jobs.md


Thanks,

Kevin Sweeney

Re: Review Request 26836: Draft of cron documentation

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26836/
-----------------------------------------------------------

(Updated Oct. 16, 2014, 4:21 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
-------

Add example file.


Bugs: AURORA-440
    https://issues.apache.org/jira/browse/AURORA-440


Repository: aurora


Description
-------

Initial shot at cron documentation.


Diffs (updated)
-----

  docs/configuration-reference.md 83d0d104554753dab939bf8d25b83e9adb00758a 
  docs/cron-jobs.md PRE-CREATION 
  examples/jobs/cron_hello_world.aurora PRE-CREATION 

Diff: https://reviews.apache.org/r/26836/diff/


Testing
-------

Pushed to https://github.com/kevints/incubator-aurora/blob/kts/cron-docs/docs/cron-jobs.md


Thanks,

Kevin Sweeney

Re: Review Request 26836: Draft of cron documentation

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26836/
-----------------------------------------------------------

(Updated Oct. 16, 2014, 3:57 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Bugs: AURORA-440
    https://issues.apache.org/jira/browse/AURORA-440


Repository: aurora


Description
-------

Initial shot at cron documentation.


Diffs
-----

  docs/configuration-reference.md 83d0d104554753dab939bf8d25b83e9adb00758a 
  docs/cron-jobs.md PRE-CREATION 

Diff: https://reviews.apache.org/r/26836/diff/


Testing (updated)
-------

Pushed to https://github.com/kevints/incubator-aurora/blob/kts/cron-docs/docs/cron-jobs.md


Thanks,

Kevin Sweeney