You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/09/29 07:06:01 UTC
[GitHub] [incubator-echarts] pingf opened a new pull request #13366: [12979] fix bug of overriding magictype buttons' title when click the…
pingf opened a new pull request #13366:
URL: https://github.com/apache/incubator-echarts/pull/13366
… button for stack view
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
fix bug of overriding the button title of the tool box
currently, if we change the title of the magic-type button in the toolbox, it works as expected
however, if we click the button for stack view, all magic type buttons' titles revert to the default
our users just want a chart without chinese, I guess this is the final block!
### Fixed issues
- #12979
## Details
### Before: What was the problem?
to check this one, we need do sth like this
```js
toolbox: {
......
magicType: {
show: true,
type: ['line', 'bar', 'stack'],
title: {
line: 'line view',
bar: 'bar view',
stack: 'stack view',
tiled: 'tiled view',
},
},
......
}
```
as stack and tiled are sth like a pair, we need to set the title for the tiled
but it only works if we never click the stack button,
once we click the button for stack, all titles revert to the the default chinese ones
### After: How is it fixed in this PR?
the old code use magicTypeLang.title as the base to override the new title
however, this is the one of fixed chinese
and now I change the logic to flip the title of stack and tiled when we click, and use model.option to get the title dynamically
```js
newTitle = zrUtil.merge(
{
stack: model.option.title.tiled,
tiled: model.option.title.stack
}, model.option.title);
```
and now it works as expected
## Usage
### Are there any API changes?
- [ ] The API has been changed.
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on pull request #13366: [12979] fix bug of overriding magictype buttons' title when click the…
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on pull request #13366:
URL: https://github.com/apache/incubator-echarts/pull/13366#issuecomment-700529203
Check out https://github.com/apache/incubator-echarts/issues/12926
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pingf edited a comment on pull request #13366: [12979] fix bug of overriding magictype buttons' title when click the…
Posted by GitBox <gi...@apache.org>.
pingf edited a comment on pull request #13366:
URL: https://github.com/apache/incubator-echarts/pull/13366#issuecomment-700566116
@susiwen8
oops, it seems it's not fixed in next release,
the default title changes to english, just similar as I configured (sth like 'Switch to Bar Chart')
however, I think I will create a new PR then
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pingf commented on pull request #13366: [12979] fix bug of overriding magictype buttons' title when click the…
Posted by GitBox <gi...@apache.org>.
pingf commented on pull request #13366:
URL: https://github.com/apache/incubator-echarts/pull/13366#issuecomment-700544576
@susiwen8
thx, I've test the next branch, it seems the issue 12979 is already been fixed
but during test the code, find another problem, after some clicks of the buttons in the toolbox, the chart freezes!
I'll create a issue to describe it in detail
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pingf edited a comment on pull request #13366: [12979] fix bug of overriding magictype buttons' title when click the…
Posted by GitBox <gi...@apache.org>.
pingf edited a comment on pull request #13366:
URL: https://github.com/apache/incubator-echarts/pull/13366#issuecomment-700566116
@susiwen8
oops, it seems it's not fixed in next release,
the default title changes to english, just similar as I configed (sth like 'Switch to Bar Chart')
however, I think I will create a new PR then
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pingf edited a comment on pull request #13366: [12979] fix bug of overriding magictype buttons' title when click the…
Posted by GitBox <gi...@apache.org>.
pingf edited a comment on pull request #13366:
URL: https://github.com/apache/incubator-echarts/pull/13366#issuecomment-700506290
@susiwen8
sorry for the wrong branch, this is the first time I created the PR here,
and just followed the https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request#coding-standard
it seems it didn't mention the next branch.
I'll create another PR to next then
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 edited a comment on pull request #13366: [12979] fix bug of overriding magictype buttons' title when click the…
Posted by GitBox <gi...@apache.org>.
susiwen8 edited a comment on pull request #13366:
URL: https://github.com/apache/incubator-echarts/pull/13366#issuecomment-700529203
Check it out https://github.com/apache/incubator-echarts/issues/12926
We have 2 alpha release for 5.0 base on `next`. And if all things go well, 5.0 would be release in October.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on pull request #13366: [12979] fix bug of overriding magictype buttons' title when click the…
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on pull request #13366:
URL: https://github.com/apache/incubator-echarts/pull/13366#issuecomment-700499037
@pingf Thank you very much, could you submit this PR to `next` branch? Also please provide a related test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pingf commented on pull request #13366: [12979] fix bug of overriding magictype buttons' title when click the…
Posted by GitBox <gi...@apache.org>.
pingf commented on pull request #13366:
URL: https://github.com/apache/incubator-echarts/pull/13366#issuecomment-700526106
arrr... the changes in next are huge, even migrated to typescripts.....
I think it really needs a new wiki page for this, even the next is not released
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pingf edited a comment on pull request #13366: [12979] fix bug of overriding magictype buttons' title when click the…
Posted by GitBox <gi...@apache.org>.
pingf edited a comment on pull request #13366:
URL: https://github.com/apache/incubator-echarts/pull/13366#issuecomment-700506290
@susiwen8
sorry for the wrong branch, this is the first time I created the PR here,
and just followed the https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request#coding-standard
it seems it didn't mention the next branch.
I'll change the PR to next then
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pingf commented on pull request #13366: [12979] fix bug of overriding magictype buttons' title when click the…
Posted by GitBox <gi...@apache.org>.
pingf commented on pull request #13366:
URL: https://github.com/apache/incubator-echarts/pull/13366#issuecomment-700506290
@susiwen8
sorry for the wrong branch, this is the first time I created PR here,
and just followed the https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request#coding-standard
it seems it didn't mention the next branch.
I'll create another PR to next then
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13366: [12979] fix bug of overriding magictype buttons' title when click the…
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13366:
URL: https://github.com/apache/incubator-echarts/pull/13366#issuecomment-700495697
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on pull request #13366: [12979] fix bug of overriding magictype buttons' title when click the…
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on pull request #13366:
URL: https://github.com/apache/incubator-echarts/pull/13366#issuecomment-700515846
@pingf since too much conflict,, It's better to create a new PR for `next` and close this one. Base brach you chose should be `next`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pingf closed pull request #13366: [12979] fix bug of overriding magictype buttons' title when click the…
Posted by GitBox <gi...@apache.org>.
pingf closed pull request #13366:
URL: https://github.com/apache/incubator-echarts/pull/13366
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pingf commented on pull request #13366: [12979] fix bug of overriding magictype buttons' title when click the…
Posted by GitBox <gi...@apache.org>.
pingf commented on pull request #13366:
URL: https://github.com/apache/incubator-echarts/pull/13366#issuecomment-700566116
@susiwen8
oops, it seems it's not fixed in next version,
the default title changes to english, just similar as I configed (sth like 'Switch to Bar Chart')
however, I think I will create a new PR then
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pingf commented on pull request #13366: [12979] fix bug of overriding magictype buttons' title when click the…
Posted by GitBox <gi...@apache.org>.
pingf commented on pull request #13366:
URL: https://github.com/apache/incubator-echarts/pull/13366#issuecomment-700513816
@susiwen8
I've change the merge base from master to next, it seems it has a lot of conflicts
I guess all of these can be ignored as this PR only changes a small part of one file.
so if I want to create PR next time , which branch should I use as the base branch ? the master or next?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org