[jira] [Commented] (BOOKKEEPER-628) Improve bookie registration interface

["Sijie Guo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13801486#comment-13801486 ] 

Sijie Guo commented on BOOKKEEPER-628:
--------------------------------------

the interface looks good.

but I would step back asking the question: what is the goal of this interface? it sounds to me that the interface is to hide zookeeper specific implementations. but from the interface, it is already tight with zookeeper (RegistrationManager#init(AbstractConfiguration conf, ZooKeeper zk, int managerVersion)).

As this interface doesn't block other tickets and all these stuffs (e.g. bookie registration, cookies) are quite zookeeper specific operations, I'd prefer generifying the interface after fixed zookeeper session handling in BOOKEEPER-537. so we could get clearer how the interface would look like. Thoughts?

> Improve bookie registration interface
> -------------------------------------
>
>                 Key: BOOKKEEPER-628
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-628
>             Project: Bookkeeper
>          Issue Type: Improvement
>          Components: bookkeeper-client, bookkeeper-server
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>             Fix For: 4.3.0
>
>         Attachments: BOOKKEEPER-628-interface-version-1.patch, BOOKKEEPER-628-interface-version-2.patch, BOOKKEEPER-628-interface-version.patch
>
>
> The idea is to improve/generalize the bookie registration process



--
This message was sent by Atlassian JIRA
(v6.1#6144)