[GitHub] [ignite-3] alievmirza commented on a diff in pull request #970: IGNITE-16559 A log level was changed for event when a leader refreshing is failed with timeout exception.

[GitBox <gi...@apache.org>]

alievmirza commented on code in PR #970:
URL: https://github.com/apache/ignite-3/pull/970#discussion_r935163748


##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/impl/RaftGroupServiceImpl.java:
##########
@@ -176,9 +176,13 @@ public static CompletableFuture<RaftGroupService> start(
             return CompletableFuture.completedFuture(service);
 
         return service.refreshLeader().handle((unused, throwable) -> {
-            if (throwable != null)
-                LOG.error("Failed to refresh a leader [groupId={}]", throwable, groupId);
-
+            if (throwable != null) {
+                if (throwable.getCause() instanceof TimeoutException) {
+                    LOG.warn("Failed to refresh a leader [groupId={}]", groupId);

Review Comment:
   Please, reconsider logging levels according to the new guidelines https://cwiki.apache.org/confluence/display/IGNITE/Java+Logging+Guidelines#JavaLoggingGuidelines-WARN



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org