You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mxnet.apache.org by Haibin Lin <ha...@gmail.com> on 2018/01/28 08:29:17 UTC

[VOTE] Release Apache MXNet (incubating) version 1.1.0.RC0

Hi everyone,

Given that most people on dev@ are in favor of a minor release (1.1.0)
instead of a patch release due to API changes, I'd like to propose a vote
to release Apache MXNet (incubating) 1.1.0. Voting will start now (Sunday,
January 28th) and end at 1pm Wednesday, January 31th PST.

Link to release notes:
https://cwiki.apache.org/confluence/display/MXNET/Apache+MXNet+%28incubating%29+1.1.0+Release+Notes


Link to release candidate 1.1.0.rc0:
https://github.com/apache/incubator-mxnet/releases/tag/1.1.0.rc0

View this page and scroll down to “Build from Source” with source code
obtained from the 1.1.0.rc0 tag:
https://mxnet.incubator.apache.org/install/index.html

(Note: The README.md points to the 1.1.0 tag and does not work at the
moment.)

Please remember to TEST first before voting accordingly:
+1 = approve
+0 = no opinion
-1 = disapprove (provide reason)

Best,
Haibin

Re: [VOTE] Release Apache MXNet (incubating) version 1.1.0.RC0

Posted by YiZhi Liu <li...@apache.org>.
+1 (binding)

2018-01-31 9:18 GMT-08:00 sandeep krishnamurthy <sandeep.krishna98@gmail.com
>:

> @Haibin: Thanks for leading this release and quickly fixing the source tar
> issue.
>
>
> +1 (binding)
>
>
>
>    1. Download source tar from release page -
>    https://github.com/apache/incubator-mxnet/releases/
> download/1.1.0.rc0/apache-mxnet-src-1.1.0.rc0-incubating.tar.gz
>    2. Build from source on GPU machine (AWS instance p2.8x) with CUDA8.
>    3. Run work in progress Keras2 with MXNet backend (
>    https://github.com/deep-learning-tools/keras/tree/keras2_mxnet_backend)
>    test cases. All are successful and performance is as expected.
>       1. Example use cases tested end to end - MNIST_MLP, CIFAR10_MLP,
>       MNIST_CNN, CIFAR10_CNN, CIFAR10_Resnet56.
>
>
> Regards,
>
> Sandeep
>
>
> On Tue, Jan 30, 2018 at 11:01 PM, Haibin Lin <ha...@gmail.com>
> wrote:
>
> > @Sandeep, I've updated the release assets
> > with apache-mxnet-src-1.1.0.rc0-incubating.tar.gz which contains
> submodule
> > source code. Please use the apache one to build. Thanks.
> >
> > Best,
> > Haibin
> >
> > On Tue, Jan 30, 2018 at 8:47 PM, Chris Olivier <cj...@gmail.com>
> > wrote:
> >
> > > I guess that was an oversight. rc2 has the full source.
> > > I remember it generally has the source because there were complaints
> that
> > > there were licensing issues with the dmlc files.
> > >
> > > On Tue, Jan 30, 2018 at 8:38 PM, Haibin Lin <ha...@gmail.com>
> > > wrote:
> > >
> > > > @Chris Are pre-releases expected to include submodules? I checked
> > > 1.0.0.rc0
> > > > and 1.0.0.rc1, neither of them contain source code of submodules.
> > > >
> > > > On Tue, Jan 30, 2018 at 8:32 PM, Chris Olivier <
> cjolivier01@gmail.com>
> > > > wrote:
> > > >
> > > > > All other relases have the submodule sources included
> > > > >
> > > > > On Tue, Jan 30, 2018 at 8:00 PM, sandeep krishnamurthy <
> > > > > sandeep.krishna98@gmail.com> wrote:
> > > > >
> > > > > > I downloaded source from -
> > > > > > https://github.com/apache/incubator-mxnet/archive/1.1.0.
> rc0.tar.gz
> > > and
> > > > > > tried to build from source.
> > > > > > Build failed as submodules (ps-list, mshadow) are empty directory
> > in
> > > > the
> > > > > > source tar.
> > > > > >
> > > > > > Is this expected to not include submodules in source tar?
> > > > > >
> > > > > >
> > > > > > On Tue, Jan 30, 2018 at 4:15 PM, Marco de Abreu <
> > > > > > marco.g.abreu@googlemail.com> wrote:
> > > > > >
> > > > > > > +1 (binding)
> > > > > > >
> > > > > > > On Tue, Jan 30, 2018 at 3:20 PM, Indhu <
> indhubharathi@gmail.com>
> > > > > wrote:
> > > > > > >
> > > > > > > > +1 (binding)
> > > > > > > >
> > > > > > > >
> > > > > > > > On Tue, Jan 30, 2018 at 2:16 PM Chris Olivier <
> > > > cjolivier01@gmail.com
> > > > > >
> > > > > > > > wrote:
> > > > > > > >
> > > > > > > > > +1 (binding)
> > > > > > > > >
> > > > > > > > > On Sun, Jan 28, 2018 at 12:35 AM, Haibin Lin <
> > > > > > haibin.lin.aws@gmail.com
> > > > > > > >
> > > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > > Update:
> > > > > > > > > >
> > > > > > > > > > Link to release candidate 1.1.0.rc0:
> > > > > > > > > > https://dist.apache.org/repos/
> dist/dev/incubator/mxnet/1.1
> > .
> > > > > 0.rc0/
> > > > > > > > > >
> > > > > > > > > > Link to the release tag:
> > > > > > > > > > https://github.com/apache/incubator-mxnet/tree/1.1.0.rc0
> > > > > > > > > >
> > > > > > > > > > Best,
> > > > > > > > > > Haibin
> > > > > > > > > >
> > > > > > > > > > On Sun, Jan 28, 2018 at 12:29 AM, Haibin Lin <
> > > > > > > haibin.lin.aws@gmail.com
> > > > > > > > >
> > > > > > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > > > Hi everyone,
> > > > > > > > > > >
> > > > > > > > > > > Given that most people on dev@ are in favor of a minor
> > > > release
> > > > > > > > (1.1.0)
> > > > > > > > > > > instead of a patch release due to API changes, I'd like
> > to
> > > > > > propose
> > > > > > > a
> > > > > > > > > vote
> > > > > > > > > > > to release Apache MXNet (incubating) 1.1.0. Voting will
> > > start
> > > > > now
> > > > > > > > > > (Sunday,
> > > > > > > > > > > January 28th) and end at 1pm Wednesday, January 31th
> PST.
> > > > > > > > > > >
> > > > > > > > > > > Link to release notes:
> > > > > > > > > > > https://cwiki.apache.org/confluence/display/MXNET/
> > > > > > > > > > > Apache+MXNet+%28incubating%29+1.1.0+Release+Notes
> > > > > > > > > > >
> > > > > > > > > > > Link to release candidate 1.1.0.rc0:
> > > > > > > > > > > https://github.com/apache/
> incubator-mxnet/releases/tag/
> > > > > 1.1.0.rc0
> > > > > > > > > > >
> > > > > > > > > > > View this page and scroll down to “Build from Source”
> > with
> > > > > source
> > > > > > > > code
> > > > > > > > > > > obtained from the 1.1.0.rc0 tag:
> > > > > > > > > > > https://mxnet.incubator.apache.org/install/index.html
> > > > > > > > > > >
> > > > > > > > > > > (Note: The README.md points to the 1.1.0 tag and does
> not
> > > > work
> > > > > at
> > > > > > > the
> > > > > > > > > > > moment.)
> > > > > > > > > > >
> > > > > > > > > > > Please remember to TEST first before voting
> accordingly:
> > > > > > > > > > > +1 = approve
> > > > > > > > > > > +0 = no opinion
> > > > > > > > > > > -1 = disapprove (provide reason)
> > > > > > > > > > >
> > > > > > > > > > > Best,
> > > > > > > > > > > Haibin
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Sandeep Krishnamurthy
> > > > > >
> > > > >
> > > >
> > >
> >
>
>
>
> --
> Sandeep Krishnamurthy
>
> --
> Yizhi Liu
> DMLC member
> Amazon Web Services
> Vancouver, Canada
>
>

Re: [VOTE] Release Apache MXNet (incubating) version 1.1.0.RC0

Posted by sandeep krishnamurthy <sa...@gmail.com>.
@Haibin: Thanks for leading this release and quickly fixing the source tar
issue.


+1 (binding)



   1. Download source tar from release page -
   https://github.com/apache/incubator-mxnet/releases/download/1.1.0.rc0/apache-mxnet-src-1.1.0.rc0-incubating.tar.gz
   2. Build from source on GPU machine (AWS instance p2.8x) with CUDA8.
   3. Run work in progress Keras2 with MXNet backend (
   https://github.com/deep-learning-tools/keras/tree/keras2_mxnet_backend)
   test cases. All are successful and performance is as expected.
      1. Example use cases tested end to end - MNIST_MLP, CIFAR10_MLP,
      MNIST_CNN, CIFAR10_CNN, CIFAR10_Resnet56.


Regards,

Sandeep


On Tue, Jan 30, 2018 at 11:01 PM, Haibin Lin <ha...@gmail.com>
wrote:

> @Sandeep, I've updated the release assets
> with apache-mxnet-src-1.1.0.rc0-incubating.tar.gz which contains submodule
> source code. Please use the apache one to build. Thanks.
>
> Best,
> Haibin
>
> On Tue, Jan 30, 2018 at 8:47 PM, Chris Olivier <cj...@gmail.com>
> wrote:
>
> > I guess that was an oversight. rc2 has the full source.
> > I remember it generally has the source because there were complaints that
> > there were licensing issues with the dmlc files.
> >
> > On Tue, Jan 30, 2018 at 8:38 PM, Haibin Lin <ha...@gmail.com>
> > wrote:
> >
> > > @Chris Are pre-releases expected to include submodules? I checked
> > 1.0.0.rc0
> > > and 1.0.0.rc1, neither of them contain source code of submodules.
> > >
> > > On Tue, Jan 30, 2018 at 8:32 PM, Chris Olivier <cj...@gmail.com>
> > > wrote:
> > >
> > > > All other relases have the submodule sources included
> > > >
> > > > On Tue, Jan 30, 2018 at 8:00 PM, sandeep krishnamurthy <
> > > > sandeep.krishna98@gmail.com> wrote:
> > > >
> > > > > I downloaded source from -
> > > > > https://github.com/apache/incubator-mxnet/archive/1.1.0.rc0.tar.gz
> > and
> > > > > tried to build from source.
> > > > > Build failed as submodules (ps-list, mshadow) are empty directory
> in
> > > the
> > > > > source tar.
> > > > >
> > > > > Is this expected to not include submodules in source tar?
> > > > >
> > > > >
> > > > > On Tue, Jan 30, 2018 at 4:15 PM, Marco de Abreu <
> > > > > marco.g.abreu@googlemail.com> wrote:
> > > > >
> > > > > > +1 (binding)
> > > > > >
> > > > > > On Tue, Jan 30, 2018 at 3:20 PM, Indhu <in...@gmail.com>
> > > > wrote:
> > > > > >
> > > > > > > +1 (binding)
> > > > > > >
> > > > > > >
> > > > > > > On Tue, Jan 30, 2018 at 2:16 PM Chris Olivier <
> > > cjolivier01@gmail.com
> > > > >
> > > > > > > wrote:
> > > > > > >
> > > > > > > > +1 (binding)
> > > > > > > >
> > > > > > > > On Sun, Jan 28, 2018 at 12:35 AM, Haibin Lin <
> > > > > haibin.lin.aws@gmail.com
> > > > > > >
> > > > > > > > wrote:
> > > > > > > >
> > > > > > > > > Update:
> > > > > > > > >
> > > > > > > > > Link to release candidate 1.1.0.rc0:
> > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.1
> .
> > > > 0.rc0/
> > > > > > > > >
> > > > > > > > > Link to the release tag:
> > > > > > > > > https://github.com/apache/incubator-mxnet/tree/1.1.0.rc0
> > > > > > > > >
> > > > > > > > > Best,
> > > > > > > > > Haibin
> > > > > > > > >
> > > > > > > > > On Sun, Jan 28, 2018 at 12:29 AM, Haibin Lin <
> > > > > > haibin.lin.aws@gmail.com
> > > > > > > >
> > > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > > Hi everyone,
> > > > > > > > > >
> > > > > > > > > > Given that most people on dev@ are in favor of a minor
> > > release
> > > > > > > (1.1.0)
> > > > > > > > > > instead of a patch release due to API changes, I'd like
> to
> > > > > propose
> > > > > > a
> > > > > > > > vote
> > > > > > > > > > to release Apache MXNet (incubating) 1.1.0. Voting will
> > start
> > > > now
> > > > > > > > > (Sunday,
> > > > > > > > > > January 28th) and end at 1pm Wednesday, January 31th PST.
> > > > > > > > > >
> > > > > > > > > > Link to release notes:
> > > > > > > > > > https://cwiki.apache.org/confluence/display/MXNET/
> > > > > > > > > > Apache+MXNet+%28incubating%29+1.1.0+Release+Notes
> > > > > > > > > >
> > > > > > > > > > Link to release candidate 1.1.0.rc0:
> > > > > > > > > > https://github.com/apache/incubator-mxnet/releases/tag/
> > > > 1.1.0.rc0
> > > > > > > > > >
> > > > > > > > > > View this page and scroll down to “Build from Source”
> with
> > > > source
> > > > > > > code
> > > > > > > > > > obtained from the 1.1.0.rc0 tag:
> > > > > > > > > > https://mxnet.incubator.apache.org/install/index.html
> > > > > > > > > >
> > > > > > > > > > (Note: The README.md points to the 1.1.0 tag and does not
> > > work
> > > > at
> > > > > > the
> > > > > > > > > > moment.)
> > > > > > > > > >
> > > > > > > > > > Please remember to TEST first before voting accordingly:
> > > > > > > > > > +1 = approve
> > > > > > > > > > +0 = no opinion
> > > > > > > > > > -1 = disapprove (provide reason)
> > > > > > > > > >
> > > > > > > > > > Best,
> > > > > > > > > > Haibin
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Sandeep Krishnamurthy
> > > > >
> > > >
> > >
> >
>



-- 
Sandeep Krishnamurthy

Re: [VOTE] Release Apache MXNet (incubating) version 1.1.0.RC0

Posted by Haibin Lin <ha...@gmail.com>.
@Sandeep, I've updated the release assets
with apache-mxnet-src-1.1.0.rc0-incubating.tar.gz which contains submodule
source code. Please use the apache one to build. Thanks.

Best,
Haibin

On Tue, Jan 30, 2018 at 8:47 PM, Chris Olivier <cj...@gmail.com>
wrote:

> I guess that was an oversight. rc2 has the full source.
> I remember it generally has the source because there were complaints that
> there were licensing issues with the dmlc files.
>
> On Tue, Jan 30, 2018 at 8:38 PM, Haibin Lin <ha...@gmail.com>
> wrote:
>
> > @Chris Are pre-releases expected to include submodules? I checked
> 1.0.0.rc0
> > and 1.0.0.rc1, neither of them contain source code of submodules.
> >
> > On Tue, Jan 30, 2018 at 8:32 PM, Chris Olivier <cj...@gmail.com>
> > wrote:
> >
> > > All other relases have the submodule sources included
> > >
> > > On Tue, Jan 30, 2018 at 8:00 PM, sandeep krishnamurthy <
> > > sandeep.krishna98@gmail.com> wrote:
> > >
> > > > I downloaded source from -
> > > > https://github.com/apache/incubator-mxnet/archive/1.1.0.rc0.tar.gz
> and
> > > > tried to build from source.
> > > > Build failed as submodules (ps-list, mshadow) are empty directory in
> > the
> > > > source tar.
> > > >
> > > > Is this expected to not include submodules in source tar?
> > > >
> > > >
> > > > On Tue, Jan 30, 2018 at 4:15 PM, Marco de Abreu <
> > > > marco.g.abreu@googlemail.com> wrote:
> > > >
> > > > > +1 (binding)
> > > > >
> > > > > On Tue, Jan 30, 2018 at 3:20 PM, Indhu <in...@gmail.com>
> > > wrote:
> > > > >
> > > > > > +1 (binding)
> > > > > >
> > > > > >
> > > > > > On Tue, Jan 30, 2018 at 2:16 PM Chris Olivier <
> > cjolivier01@gmail.com
> > > >
> > > > > > wrote:
> > > > > >
> > > > > > > +1 (binding)
> > > > > > >
> > > > > > > On Sun, Jan 28, 2018 at 12:35 AM, Haibin Lin <
> > > > haibin.lin.aws@gmail.com
> > > > > >
> > > > > > > wrote:
> > > > > > >
> > > > > > > > Update:
> > > > > > > >
> > > > > > > > Link to release candidate 1.1.0.rc0:
> > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.1.
> > > 0.rc0/
> > > > > > > >
> > > > > > > > Link to the release tag:
> > > > > > > > https://github.com/apache/incubator-mxnet/tree/1.1.0.rc0
> > > > > > > >
> > > > > > > > Best,
> > > > > > > > Haibin
> > > > > > > >
> > > > > > > > On Sun, Jan 28, 2018 at 12:29 AM, Haibin Lin <
> > > > > haibin.lin.aws@gmail.com
> > > > > > >
> > > > > > > > wrote:
> > > > > > > >
> > > > > > > > > Hi everyone,
> > > > > > > > >
> > > > > > > > > Given that most people on dev@ are in favor of a minor
> > release
> > > > > > (1.1.0)
> > > > > > > > > instead of a patch release due to API changes, I'd like to
> > > > propose
> > > > > a
> > > > > > > vote
> > > > > > > > > to release Apache MXNet (incubating) 1.1.0. Voting will
> start
> > > now
> > > > > > > > (Sunday,
> > > > > > > > > January 28th) and end at 1pm Wednesday, January 31th PST.
> > > > > > > > >
> > > > > > > > > Link to release notes:
> > > > > > > > > https://cwiki.apache.org/confluence/display/MXNET/
> > > > > > > > > Apache+MXNet+%28incubating%29+1.1.0+Release+Notes
> > > > > > > > >
> > > > > > > > > Link to release candidate 1.1.0.rc0:
> > > > > > > > > https://github.com/apache/incubator-mxnet/releases/tag/
> > > 1.1.0.rc0
> > > > > > > > >
> > > > > > > > > View this page and scroll down to “Build from Source” with
> > > source
> > > > > > code
> > > > > > > > > obtained from the 1.1.0.rc0 tag:
> > > > > > > > > https://mxnet.incubator.apache.org/install/index.html
> > > > > > > > >
> > > > > > > > > (Note: The README.md points to the 1.1.0 tag and does not
> > work
> > > at
> > > > > the
> > > > > > > > > moment.)
> > > > > > > > >
> > > > > > > > > Please remember to TEST first before voting accordingly:
> > > > > > > > > +1 = approve
> > > > > > > > > +0 = no opinion
> > > > > > > > > -1 = disapprove (provide reason)
> > > > > > > > >
> > > > > > > > > Best,
> > > > > > > > > Haibin
> > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Sandeep Krishnamurthy
> > > >
> > >
> >
>

Re: [VOTE] Release Apache MXNet (incubating) version 1.1.0.RC0

Posted by Chris Olivier <cj...@gmail.com>.
I guess that was an oversight. rc2 has the full source.
I remember it generally has the source because there were complaints that
there were licensing issues with the dmlc files.

On Tue, Jan 30, 2018 at 8:38 PM, Haibin Lin <ha...@gmail.com>
wrote:

> @Chris Are pre-releases expected to include submodules? I checked 1.0.0.rc0
> and 1.0.0.rc1, neither of them contain source code of submodules.
>
> On Tue, Jan 30, 2018 at 8:32 PM, Chris Olivier <cj...@gmail.com>
> wrote:
>
> > All other relases have the submodule sources included
> >
> > On Tue, Jan 30, 2018 at 8:00 PM, sandeep krishnamurthy <
> > sandeep.krishna98@gmail.com> wrote:
> >
> > > I downloaded source from -
> > > https://github.com/apache/incubator-mxnet/archive/1.1.0.rc0.tar.gz and
> > > tried to build from source.
> > > Build failed as submodules (ps-list, mshadow) are empty directory in
> the
> > > source tar.
> > >
> > > Is this expected to not include submodules in source tar?
> > >
> > >
> > > On Tue, Jan 30, 2018 at 4:15 PM, Marco de Abreu <
> > > marco.g.abreu@googlemail.com> wrote:
> > >
> > > > +1 (binding)
> > > >
> > > > On Tue, Jan 30, 2018 at 3:20 PM, Indhu <in...@gmail.com>
> > wrote:
> > > >
> > > > > +1 (binding)
> > > > >
> > > > >
> > > > > On Tue, Jan 30, 2018 at 2:16 PM Chris Olivier <
> cjolivier01@gmail.com
> > >
> > > > > wrote:
> > > > >
> > > > > > +1 (binding)
> > > > > >
> > > > > > On Sun, Jan 28, 2018 at 12:35 AM, Haibin Lin <
> > > haibin.lin.aws@gmail.com
> > > > >
> > > > > > wrote:
> > > > > >
> > > > > > > Update:
> > > > > > >
> > > > > > > Link to release candidate 1.1.0.rc0:
> > > > > > > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.1.
> > 0.rc0/
> > > > > > >
> > > > > > > Link to the release tag:
> > > > > > > https://github.com/apache/incubator-mxnet/tree/1.1.0.rc0
> > > > > > >
> > > > > > > Best,
> > > > > > > Haibin
> > > > > > >
> > > > > > > On Sun, Jan 28, 2018 at 12:29 AM, Haibin Lin <
> > > > haibin.lin.aws@gmail.com
> > > > > >
> > > > > > > wrote:
> > > > > > >
> > > > > > > > Hi everyone,
> > > > > > > >
> > > > > > > > Given that most people on dev@ are in favor of a minor
> release
> > > > > (1.1.0)
> > > > > > > > instead of a patch release due to API changes, I'd like to
> > > propose
> > > > a
> > > > > > vote
> > > > > > > > to release Apache MXNet (incubating) 1.1.0. Voting will start
> > now
> > > > > > > (Sunday,
> > > > > > > > January 28th) and end at 1pm Wednesday, January 31th PST.
> > > > > > > >
> > > > > > > > Link to release notes:
> > > > > > > > https://cwiki.apache.org/confluence/display/MXNET/
> > > > > > > > Apache+MXNet+%28incubating%29+1.1.0+Release+Notes
> > > > > > > >
> > > > > > > > Link to release candidate 1.1.0.rc0:
> > > > > > > > https://github.com/apache/incubator-mxnet/releases/tag/
> > 1.1.0.rc0
> > > > > > > >
> > > > > > > > View this page and scroll down to “Build from Source” with
> > source
> > > > > code
> > > > > > > > obtained from the 1.1.0.rc0 tag:
> > > > > > > > https://mxnet.incubator.apache.org/install/index.html
> > > > > > > >
> > > > > > > > (Note: The README.md points to the 1.1.0 tag and does not
> work
> > at
> > > > the
> > > > > > > > moment.)
> > > > > > > >
> > > > > > > > Please remember to TEST first before voting accordingly:
> > > > > > > > +1 = approve
> > > > > > > > +0 = no opinion
> > > > > > > > -1 = disapprove (provide reason)
> > > > > > > >
> > > > > > > > Best,
> > > > > > > > Haibin
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Sandeep Krishnamurthy
> > >
> >
>

Re: [VOTE] Release Apache MXNet (incubating) version 1.1.0.RC0

Posted by Haibin Lin <ha...@gmail.com>.
@Chris Are pre-releases expected to include submodules? I checked 1.0.0.rc0
and 1.0.0.rc1, neither of them contain source code of submodules.

On Tue, Jan 30, 2018 at 8:32 PM, Chris Olivier <cj...@gmail.com>
wrote:

> All other relases have the submodule sources included
>
> On Tue, Jan 30, 2018 at 8:00 PM, sandeep krishnamurthy <
> sandeep.krishna98@gmail.com> wrote:
>
> > I downloaded source from -
> > https://github.com/apache/incubator-mxnet/archive/1.1.0.rc0.tar.gz and
> > tried to build from source.
> > Build failed as submodules (ps-list, mshadow) are empty directory in the
> > source tar.
> >
> > Is this expected to not include submodules in source tar?
> >
> >
> > On Tue, Jan 30, 2018 at 4:15 PM, Marco de Abreu <
> > marco.g.abreu@googlemail.com> wrote:
> >
> > > +1 (binding)
> > >
> > > On Tue, Jan 30, 2018 at 3:20 PM, Indhu <in...@gmail.com>
> wrote:
> > >
> > > > +1 (binding)
> > > >
> > > >
> > > > On Tue, Jan 30, 2018 at 2:16 PM Chris Olivier <cjolivier01@gmail.com
> >
> > > > wrote:
> > > >
> > > > > +1 (binding)
> > > > >
> > > > > On Sun, Jan 28, 2018 at 12:35 AM, Haibin Lin <
> > haibin.lin.aws@gmail.com
> > > >
> > > > > wrote:
> > > > >
> > > > > > Update:
> > > > > >
> > > > > > Link to release candidate 1.1.0.rc0:
> > > > > > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.1.
> 0.rc0/
> > > > > >
> > > > > > Link to the release tag:
> > > > > > https://github.com/apache/incubator-mxnet/tree/1.1.0.rc0
> > > > > >
> > > > > > Best,
> > > > > > Haibin
> > > > > >
> > > > > > On Sun, Jan 28, 2018 at 12:29 AM, Haibin Lin <
> > > haibin.lin.aws@gmail.com
> > > > >
> > > > > > wrote:
> > > > > >
> > > > > > > Hi everyone,
> > > > > > >
> > > > > > > Given that most people on dev@ are in favor of a minor release
> > > > (1.1.0)
> > > > > > > instead of a patch release due to API changes, I'd like to
> > propose
> > > a
> > > > > vote
> > > > > > > to release Apache MXNet (incubating) 1.1.0. Voting will start
> now
> > > > > > (Sunday,
> > > > > > > January 28th) and end at 1pm Wednesday, January 31th PST.
> > > > > > >
> > > > > > > Link to release notes:
> > > > > > > https://cwiki.apache.org/confluence/display/MXNET/
> > > > > > > Apache+MXNet+%28incubating%29+1.1.0+Release+Notes
> > > > > > >
> > > > > > > Link to release candidate 1.1.0.rc0:
> > > > > > > https://github.com/apache/incubator-mxnet/releases/tag/
> 1.1.0.rc0
> > > > > > >
> > > > > > > View this page and scroll down to “Build from Source” with
> source
> > > > code
> > > > > > > obtained from the 1.1.0.rc0 tag:
> > > > > > > https://mxnet.incubator.apache.org/install/index.html
> > > > > > >
> > > > > > > (Note: The README.md points to the 1.1.0 tag and does not work
> at
> > > the
> > > > > > > moment.)
> > > > > > >
> > > > > > > Please remember to TEST first before voting accordingly:
> > > > > > > +1 = approve
> > > > > > > +0 = no opinion
> > > > > > > -1 = disapprove (provide reason)
> > > > > > >
> > > > > > > Best,
> > > > > > > Haibin
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> >
> >
> > --
> > Sandeep Krishnamurthy
> >
>

Re: [VOTE] Release Apache MXNet (incubating) version 1.1.0.RC0

Posted by Chris Olivier <cj...@gmail.com>.
All other relases have the submodule sources included

On Tue, Jan 30, 2018 at 8:00 PM, sandeep krishnamurthy <
sandeep.krishna98@gmail.com> wrote:

> I downloaded source from -
> https://github.com/apache/incubator-mxnet/archive/1.1.0.rc0.tar.gz and
> tried to build from source.
> Build failed as submodules (ps-list, mshadow) are empty directory in the
> source tar.
>
> Is this expected to not include submodules in source tar?
>
>
> On Tue, Jan 30, 2018 at 4:15 PM, Marco de Abreu <
> marco.g.abreu@googlemail.com> wrote:
>
> > +1 (binding)
> >
> > On Tue, Jan 30, 2018 at 3:20 PM, Indhu <in...@gmail.com> wrote:
> >
> > > +1 (binding)
> > >
> > >
> > > On Tue, Jan 30, 2018 at 2:16 PM Chris Olivier <cj...@gmail.com>
> > > wrote:
> > >
> > > > +1 (binding)
> > > >
> > > > On Sun, Jan 28, 2018 at 12:35 AM, Haibin Lin <
> haibin.lin.aws@gmail.com
> > >
> > > > wrote:
> > > >
> > > > > Update:
> > > > >
> > > > > Link to release candidate 1.1.0.rc0:
> > > > > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.1.0.rc0/
> > > > >
> > > > > Link to the release tag:
> > > > > https://github.com/apache/incubator-mxnet/tree/1.1.0.rc0
> > > > >
> > > > > Best,
> > > > > Haibin
> > > > >
> > > > > On Sun, Jan 28, 2018 at 12:29 AM, Haibin Lin <
> > haibin.lin.aws@gmail.com
> > > >
> > > > > wrote:
> > > > >
> > > > > > Hi everyone,
> > > > > >
> > > > > > Given that most people on dev@ are in favor of a minor release
> > > (1.1.0)
> > > > > > instead of a patch release due to API changes, I'd like to
> propose
> > a
> > > > vote
> > > > > > to release Apache MXNet (incubating) 1.1.0. Voting will start now
> > > > > (Sunday,
> > > > > > January 28th) and end at 1pm Wednesday, January 31th PST.
> > > > > >
> > > > > > Link to release notes:
> > > > > > https://cwiki.apache.org/confluence/display/MXNET/
> > > > > > Apache+MXNet+%28incubating%29+1.1.0+Release+Notes
> > > > > >
> > > > > > Link to release candidate 1.1.0.rc0:
> > > > > > https://github.com/apache/incubator-mxnet/releases/tag/1.1.0.rc0
> > > > > >
> > > > > > View this page and scroll down to “Build from Source” with source
> > > code
> > > > > > obtained from the 1.1.0.rc0 tag:
> > > > > > https://mxnet.incubator.apache.org/install/index.html
> > > > > >
> > > > > > (Note: The README.md points to the 1.1.0 tag and does not work at
> > the
> > > > > > moment.)
> > > > > >
> > > > > > Please remember to TEST first before voting accordingly:
> > > > > > +1 = approve
> > > > > > +0 = no opinion
> > > > > > -1 = disapprove (provide reason)
> > > > > >
> > > > > > Best,
> > > > > > Haibin
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
>
>
> --
> Sandeep Krishnamurthy
>

Re: [VOTE] Release Apache MXNet (incubating) version 1.1.0.RC0

Posted by sandeep krishnamurthy <sa...@gmail.com>.
I downloaded source from -
https://github.com/apache/incubator-mxnet/archive/1.1.0.rc0.tar.gz and
tried to build from source.
Build failed as submodules (ps-list, mshadow) are empty directory in the
source tar.

Is this expected to not include submodules in source tar?


On Tue, Jan 30, 2018 at 4:15 PM, Marco de Abreu <
marco.g.abreu@googlemail.com> wrote:

> +1 (binding)
>
> On Tue, Jan 30, 2018 at 3:20 PM, Indhu <in...@gmail.com> wrote:
>
> > +1 (binding)
> >
> >
> > On Tue, Jan 30, 2018 at 2:16 PM Chris Olivier <cj...@gmail.com>
> > wrote:
> >
> > > +1 (binding)
> > >
> > > On Sun, Jan 28, 2018 at 12:35 AM, Haibin Lin <haibin.lin.aws@gmail.com
> >
> > > wrote:
> > >
> > > > Update:
> > > >
> > > > Link to release candidate 1.1.0.rc0:
> > > > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.1.0.rc0/
> > > >
> > > > Link to the release tag:
> > > > https://github.com/apache/incubator-mxnet/tree/1.1.0.rc0
> > > >
> > > > Best,
> > > > Haibin
> > > >
> > > > On Sun, Jan 28, 2018 at 12:29 AM, Haibin Lin <
> haibin.lin.aws@gmail.com
> > >
> > > > wrote:
> > > >
> > > > > Hi everyone,
> > > > >
> > > > > Given that most people on dev@ are in favor of a minor release
> > (1.1.0)
> > > > > instead of a patch release due to API changes, I'd like to propose
> a
> > > vote
> > > > > to release Apache MXNet (incubating) 1.1.0. Voting will start now
> > > > (Sunday,
> > > > > January 28th) and end at 1pm Wednesday, January 31th PST.
> > > > >
> > > > > Link to release notes:
> > > > > https://cwiki.apache.org/confluence/display/MXNET/
> > > > > Apache+MXNet+%28incubating%29+1.1.0+Release+Notes
> > > > >
> > > > > Link to release candidate 1.1.0.rc0:
> > > > > https://github.com/apache/incubator-mxnet/releases/tag/1.1.0.rc0
> > > > >
> > > > > View this page and scroll down to “Build from Source” with source
> > code
> > > > > obtained from the 1.1.0.rc0 tag:
> > > > > https://mxnet.incubator.apache.org/install/index.html
> > > > >
> > > > > (Note: The README.md points to the 1.1.0 tag and does not work at
> the
> > > > > moment.)
> > > > >
> > > > > Please remember to TEST first before voting accordingly:
> > > > > +1 = approve
> > > > > +0 = no opinion
> > > > > -1 = disapprove (provide reason)
> > > > >
> > > > > Best,
> > > > > Haibin
> > > > >
> > > > >
> > > >
> > >
> >
>



-- 
Sandeep Krishnamurthy

Re: [VOTE] Release Apache MXNet (incubating) version 1.1.0.RC0

Posted by Marco de Abreu <ma...@googlemail.com>.
+1 (binding)

On Tue, Jan 30, 2018 at 3:20 PM, Indhu <in...@gmail.com> wrote:

> +1 (binding)
>
>
> On Tue, Jan 30, 2018 at 2:16 PM Chris Olivier <cj...@gmail.com>
> wrote:
>
> > +1 (binding)
> >
> > On Sun, Jan 28, 2018 at 12:35 AM, Haibin Lin <ha...@gmail.com>
> > wrote:
> >
> > > Update:
> > >
> > > Link to release candidate 1.1.0.rc0:
> > > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.1.0.rc0/
> > >
> > > Link to the release tag:
> > > https://github.com/apache/incubator-mxnet/tree/1.1.0.rc0
> > >
> > > Best,
> > > Haibin
> > >
> > > On Sun, Jan 28, 2018 at 12:29 AM, Haibin Lin <haibin.lin.aws@gmail.com
> >
> > > wrote:
> > >
> > > > Hi everyone,
> > > >
> > > > Given that most people on dev@ are in favor of a minor release
> (1.1.0)
> > > > instead of a patch release due to API changes, I'd like to propose a
> > vote
> > > > to release Apache MXNet (incubating) 1.1.0. Voting will start now
> > > (Sunday,
> > > > January 28th) and end at 1pm Wednesday, January 31th PST.
> > > >
> > > > Link to release notes:
> > > > https://cwiki.apache.org/confluence/display/MXNET/
> > > > Apache+MXNet+%28incubating%29+1.1.0+Release+Notes
> > > >
> > > > Link to release candidate 1.1.0.rc0:
> > > > https://github.com/apache/incubator-mxnet/releases/tag/1.1.0.rc0
> > > >
> > > > View this page and scroll down to “Build from Source” with source
> code
> > > > obtained from the 1.1.0.rc0 tag:
> > > > https://mxnet.incubator.apache.org/install/index.html
> > > >
> > > > (Note: The README.md points to the 1.1.0 tag and does not work at the
> > > > moment.)
> > > >
> > > > Please remember to TEST first before voting accordingly:
> > > > +1 = approve
> > > > +0 = no opinion
> > > > -1 = disapprove (provide reason)
> > > >
> > > > Best,
> > > > Haibin
> > > >
> > > >
> > >
> >
>

Re: [VOTE] Release Apache MXNet (incubating) version 1.1.0.RC0

Posted by Indhu <in...@gmail.com>.
+1 (binding)


On Tue, Jan 30, 2018 at 2:16 PM Chris Olivier <cj...@gmail.com> wrote:

> +1 (binding)
>
> On Sun, Jan 28, 2018 at 12:35 AM, Haibin Lin <ha...@gmail.com>
> wrote:
>
> > Update:
> >
> > Link to release candidate 1.1.0.rc0:
> > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.1.0.rc0/
> >
> > Link to the release tag:
> > https://github.com/apache/incubator-mxnet/tree/1.1.0.rc0
> >
> > Best,
> > Haibin
> >
> > On Sun, Jan 28, 2018 at 12:29 AM, Haibin Lin <ha...@gmail.com>
> > wrote:
> >
> > > Hi everyone,
> > >
> > > Given that most people on dev@ are in favor of a minor release (1.1.0)
> > > instead of a patch release due to API changes, I'd like to propose a
> vote
> > > to release Apache MXNet (incubating) 1.1.0. Voting will start now
> > (Sunday,
> > > January 28th) and end at 1pm Wednesday, January 31th PST.
> > >
> > > Link to release notes:
> > > https://cwiki.apache.org/confluence/display/MXNET/
> > > Apache+MXNet+%28incubating%29+1.1.0+Release+Notes
> > >
> > > Link to release candidate 1.1.0.rc0:
> > > https://github.com/apache/incubator-mxnet/releases/tag/1.1.0.rc0
> > >
> > > View this page and scroll down to “Build from Source” with source code
> > > obtained from the 1.1.0.rc0 tag:
> > > https://mxnet.incubator.apache.org/install/index.html
> > >
> > > (Note: The README.md points to the 1.1.0 tag and does not work at the
> > > moment.)
> > >
> > > Please remember to TEST first before voting accordingly:
> > > +1 = approve
> > > +0 = no opinion
> > > -1 = disapprove (provide reason)
> > >
> > > Best,
> > > Haibin
> > >
> > >
> >
>

Re: [VOTE] Release Apache MXNet (incubating) version 1.1.0.RC0

Posted by Chris Olivier <cj...@gmail.com>.
+1 (binding)

On Sun, Jan 28, 2018 at 12:35 AM, Haibin Lin <ha...@gmail.com>
wrote:

> Update:
>
> Link to release candidate 1.1.0.rc0:
> https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.1.0.rc0/
>
> Link to the release tag:
> https://github.com/apache/incubator-mxnet/tree/1.1.0.rc0
>
> Best,
> Haibin
>
> On Sun, Jan 28, 2018 at 12:29 AM, Haibin Lin <ha...@gmail.com>
> wrote:
>
> > Hi everyone,
> >
> > Given that most people on dev@ are in favor of a minor release (1.1.0)
> > instead of a patch release due to API changes, I'd like to propose a vote
> > to release Apache MXNet (incubating) 1.1.0. Voting will start now
> (Sunday,
> > January 28th) and end at 1pm Wednesday, January 31th PST.
> >
> > Link to release notes:
> > https://cwiki.apache.org/confluence/display/MXNET/
> > Apache+MXNet+%28incubating%29+1.1.0+Release+Notes
> >
> > Link to release candidate 1.1.0.rc0:
> > https://github.com/apache/incubator-mxnet/releases/tag/1.1.0.rc0
> >
> > View this page and scroll down to “Build from Source” with source code
> > obtained from the 1.1.0.rc0 tag:
> > https://mxnet.incubator.apache.org/install/index.html
> >
> > (Note: The README.md points to the 1.1.0 tag and does not work at the
> > moment.)
> >
> > Please remember to TEST first before voting accordingly:
> > +1 = approve
> > +0 = no opinion
> > -1 = disapprove (provide reason)
> >
> > Best,
> > Haibin
> >
> >
>

Re: [VOTE] Release Apache MXNet (incubating) version 1.1.0.RC0

Posted by kellen sunderland <ke...@gmail.com>.
Thanks to Haibin for putting this release together, and to everyone who has
been working on technical debt (bug fixes, flaky test fixes) or RAT
issues.  I also appreciate the thinking around API changes, and the
decision to deprecate rather than make a change in a single release.  This
release looks like it will add a lot of polish to MXNet.

VERSION: With the updated release notes this is certainly not a patch fix,
so consider my objection there removed.
INCUBATING IN RELEASE FILE: check.
LICENSE check.
NOTICE check.
SIGNATURE check.
HASH check.
DISCLAIMER check.
SOURCE COMPILES check.
TESTS PASS check.
NO 3RD PARTY BINS check.

+1 (non-binding)

-Kellen

On Sun, Jan 28, 2018 at 9:35 AM, Haibin Lin <ha...@gmail.com>
wrote:

> Update:
>
> Link to release candidate 1.1.0.rc0:
> https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.1.0.rc0/
>
> Link to the release tag:
> https://github.com/apache/incubator-mxnet/tree/1.1.0.rc0
>
> Best,
> Haibin
>
> On Sun, Jan 28, 2018 at 12:29 AM, Haibin Lin <ha...@gmail.com>
> wrote:
>
> > Hi everyone,
> >
> > Given that most people on dev@ are in favor of a minor release (1.1.0)
> > instead of a patch release due to API changes, I'd like to propose a vote
> > to release Apache MXNet (incubating) 1.1.0. Voting will start now
> (Sunday,
> > January 28th) and end at 1pm Wednesday, January 31th PST.
> >
> > Link to release notes:
> > https://cwiki.apache.org/confluence/display/MXNET/
> > Apache+MXNet+%28incubating%29+1.1.0+Release+Notes
> >
> > Link to release candidate 1.1.0.rc0:
> > https://github.com/apache/incubator-mxnet/releases/tag/1.1.0.rc0
> >
> > View this page and scroll down to “Build from Source” with source code
> > obtained from the 1.1.0.rc0 tag:
> > https://mxnet.incubator.apache.org/install/index.html
> >
> > (Note: The README.md points to the 1.1.0 tag and does not work at the
> > moment.)
> >
> > Please remember to TEST first before voting accordingly:
> > +1 = approve
> > +0 = no opinion
> > -1 = disapprove (provide reason)
> >
> > Best,
> > Haibin
> >
> >
>

Re: [VOTE] Release Apache MXNet (incubating) version 1.1.0.RC0

Posted by Haibin Lin <ha...@gmail.com>.
Update:

Link to release candidate 1.1.0.rc0:
https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.1.0.rc0/

Link to the release tag:
https://github.com/apache/incubator-mxnet/tree/1.1.0.rc0

Best,
Haibin

On Sun, Jan 28, 2018 at 12:29 AM, Haibin Lin <ha...@gmail.com>
wrote:

> Hi everyone,
>
> Given that most people on dev@ are in favor of a minor release (1.1.0)
> instead of a patch release due to API changes, I'd like to propose a vote
> to release Apache MXNet (incubating) 1.1.0. Voting will start now (Sunday,
> January 28th) and end at 1pm Wednesday, January 31th PST.
>
> Link to release notes:
> https://cwiki.apache.org/confluence/display/MXNET/
> Apache+MXNet+%28incubating%29+1.1.0+Release+Notes
>
> Link to release candidate 1.1.0.rc0:
> https://github.com/apache/incubator-mxnet/releases/tag/1.1.0.rc0
>
> View this page and scroll down to “Build from Source” with source code
> obtained from the 1.1.0.rc0 tag:
> https://mxnet.incubator.apache.org/install/index.html
>
> (Note: The README.md points to the 1.1.0 tag and does not work at the
> moment.)
>
> Please remember to TEST first before voting accordingly:
> +1 = approve
> +0 = no opinion
> -1 = disapprove (provide reason)
>
> Best,
> Haibin
>
>