You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2007/07/17 14:48:24 UTC
[Bug 5564] New: __RDNS_DYNAMIC_IPADDR does not hit all of its test patterns
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5564
Summary: __RDNS_DYNAMIC_IPADDR does not hit all of its test
patterns
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P5
Component: Rules
AssignedTo: dev@spamassassin.apache.org
ReportedBy: henry@stern.ca
__RDNS_DYNAMIC_IPADDR does not hit the following patterns in its test set:
NNN-NNN-NNN-NNN.fibertel.com.ar
NN.NN.NNN.NNN.ap.yournet.ne.jp
NN.NNN.NN-NN.rev.gaoland.net
200-171-228-6.customer.telesp.net.br
80-218-47-160.dclient.hispeed.ch
74.67-201-80.adsl.skynet.be
12-218-225-223.client.mchsi.com
The comment:
# (require an alpha first, as legit HELO'ing-as-IP-address is hit otherwise)
indicates that this is intentional. However, we are not looking at HELO but at
RDNS. To fix this, simply drop the [a-z] at the beginning. The latter part of
the regex keeps it from matching raw IPs.
The regex also does not match 'pptp-81-30-186-139.ufanet.ru' and I think that it
should. It's written in an odd manner so that it needs three .foo groups when
the IP address is not followed by a non-digit (such as a letter). The regex
would match something like 'pptp-81-30-186-139a.ufanet.ru,' which is just plain
weird.
The regex will be changed in two places:
--1-- ------2------
[a-z]\S*\d+[^\d\s]\d+[^\d\s]\d+[^\d\s]\d+[^\d\s][^\.]*\.\S+\.\S+
\S*\d+[^\d\s]\d+[^\d\s]\d+[^\d\s]\d+ \S* \.\S+\.\S+
Place 1 eliminates the unnecessary requirement for the IP to be preceded by
alphanumerics.
Place 2 simplifies the pattern and corrects the above-mentioned issue.
In English, the regex is now:
header matter
IP address-like string
trailer matter
.domain.name
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5564] __RDNS_DYNAMIC_IPADDR does not hit all of its test patterns
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5564
------- Additional Comments From jm@jmason.org 2007-07-17 05:49 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5564] __RDNS_DYNAMIC_IPADDR does not hit all of its test patterns
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5564
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
BugsThisDependsOn| |5563
Severity|normal |minor
Status Whiteboard| |needs 2 votes for 3.2
Target Milestone|Undefined |3.2.3
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5564] __RDNS_DYNAMIC_IPADDR does not hit all of its test patterns
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5564
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution| |DUPLICATE
------- Additional Comments From jm@jmason.org 2007-07-30 13:33 -------
this is a total mess; closing this bug in favour of a combined megapatch in bug
5397.
*** This bug has been marked as a duplicate of 5397 ***
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5564] __RDNS_DYNAMIC_IPADDR does not hit all of its test patterns
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5564
Bug 5564 depends on bug 5563, which changed state.
Bug 5563 Summary: [review] 17 of the RDNS_DYNAMIC rules use order-dependent fields
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5563
What |Old Value |New Value
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution| |DUPLICATE
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5564] __RDNS_DYNAMIC_IPADDR does not hit all of its test patterns
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5564
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO| |5397
nThis| |
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5564] __RDNS_DYNAMIC_IPADDR does not hit all of its test patterns
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5564
------- Additional Comments From jm@jmason.org 2007-07-17 06:07 -------
(In reply to comment #3)
> We'll drop the __RDNS_DYNAMIC_IPADDR2 predicate as, when fixed as per part 2, it
> is the same regex as the new RDNS_DYNAMIC_IPADDR without the \S* at the
> beginning, which makes IPADDR2 a proper subset of IPADDR. Since they're being
> OR'ed, there's no reason to keep it around.
+1 to this one too ;)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5564] __RDNS_DYNAMIC_IPADDR does not hit all of its test patterns
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5564
henry@stern.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |
------- Additional Comments From henry@stern.ca 2007-07-17 06:05 -------
Justin points out that this makes __RDNS_DYNAMIC_IPADDR2 redundant.
--1-- ------2------
[a-z]\S*\d+[^\d\s]\d+[^\d\s]\d+[^\d\s]\d+[^\d\s][^\.]*\.\S+\.\S+ (orig)
\S*\d+[^\d\s]\d+[^\d\s]\d+[^\d\s]\d+ \S* \.\S+\.\S+ (new)
\d+[^\d\s]\d+[^\d\s]\d+[^\d\s]\d+[^\d\s][^\.]*\.\S+\.\S+ (IPADDR2)
We'll drop the __RDNS_DYNAMIC_IPADDR2 predicate as, when fixed as per part 2, it
is the same regex as the new RDNS_DYNAMIC_IPADDR without the \S* at the
beginning, which makes IPADDR2 a proper subset of IPADDR. Since they're being
OR'ed, there's no reason to keep it around.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5564] __RDNS_DYNAMIC_IPADDR does not hit all of its test patterns
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5564
------- Additional Comments From jm@jmason.org 2007-07-19 09:16 -------
Created an attachment (id=4053)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=4053&action=view)
backport for 3.2.x
here's those 2 changes as a patch for 3.2.x. this requires bug 5563 be
resolved first.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5564] __RDNS_DYNAMIC_IPADDR does not hit all of its test patterns
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5564
------- Additional Comments From henry@stern.ca 2007-07-17 06:09 -------
Sending rules/20_dynrdns.cf
Transmitting file data .
Committed revision 556923.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5564] __RDNS_DYNAMIC_IPADDR does not hit all of its test patterns
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5564
henry@stern.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From henry@stern.ca 2007-07-17 05:51 -------
Sending rules/20_dynrdns.cf
Transmitting file data .
Committed revision 556911.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.