You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2017/08/29 14:32:36 UTC

gateway-test-release-utils module

Any objections if I move the two classes in the gateway-test-release-utils
module  into gateway-test-utils instead?

Those two classes are used fairly extensively in the gateway-tests module,
as well as in the gateway-test-release modules. I think it makes sense to
have a single module containing the test utility code.

Colm.


-- 
Colm O hEigeartaigh

Talend Community Coder
http://coders.talend.com

Re: gateway-test-release-utils module

Posted by larry mccay <lm...@apache.org>.
Ahhh - yes, that rings a bell.

On Wed, Aug 30, 2017 at 10:51 AM, Colm O hEigeartaigh <co...@apache.org>
wrote:

> Actually, further examination shows that there is a reason for that module
> - you end up with circular dependencies involving the gateway-test-utils
> module otherwise.
>
> Colm.
>
> On Tue, Aug 29, 2017 at 4:13 PM, larry mccay <lm...@apache.org> wrote:
>
> > That seems reasonable to me.
> >
> > On Tue, Aug 29, 2017 at 10:32 AM, Colm O hEigeartaigh <
> coheigea@apache.org
> > > wrote:
> >
> >> Any objections if I move the two classes in the
> gateway-test-release-utils
> >> module  into gateway-test-utils instead?
> >>
> >> Those two classes are used fairly extensively in the gateway-tests
> module,
> >> as well as in the gateway-test-release modules. I think it makes sense
> to
> >> have a single module containing the test utility code.
> >>
> >> Colm.
> >>
> >>
> >> --
> >> Colm O hEigeartaigh
> >>
> >> Talend Community Coder
> >> http://coders.talend.com
> >>
> >
> >
>
>
> --
> Colm O hEigeartaigh
>
> Talend Community Coder
> http://coders.talend.com
>

Re: gateway-test-release-utils module

Posted by Colm O hEigeartaigh <co...@apache.org>.
Actually, further examination shows that there is a reason for that module
- you end up with circular dependencies involving the gateway-test-utils
module otherwise.

Colm.

On Tue, Aug 29, 2017 at 4:13 PM, larry mccay <lm...@apache.org> wrote:

> That seems reasonable to me.
>
> On Tue, Aug 29, 2017 at 10:32 AM, Colm O hEigeartaigh <coheigea@apache.org
> > wrote:
>
>> Any objections if I move the two classes in the gateway-test-release-utils
>> module  into gateway-test-utils instead?
>>
>> Those two classes are used fairly extensively in the gateway-tests module,
>> as well as in the gateway-test-release modules. I think it makes sense to
>> have a single module containing the test utility code.
>>
>> Colm.
>>
>>
>> --
>> Colm O hEigeartaigh
>>
>> Talend Community Coder
>> http://coders.talend.com
>>
>
>


-- 
Colm O hEigeartaigh

Talend Community Coder
http://coders.talend.com

Re: gateway-test-release-utils module

Posted by larry mccay <lm...@apache.org>.
That seems reasonable to me.

On Tue, Aug 29, 2017 at 10:32 AM, Colm O hEigeartaigh <co...@apache.org>
wrote:

> Any objections if I move the two classes in the gateway-test-release-utils
> module  into gateway-test-utils instead?
>
> Those two classes are used fairly extensively in the gateway-tests module,
> as well as in the gateway-test-release modules. I think it makes sense to
> have a single module containing the test utility code.
>
> Colm.
>
>
> --
> Colm O hEigeartaigh
>
> Talend Community Coder
> http://coders.talend.com
>