[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #708: MINIFICPP-1118 - MiNiFi C++ on Windows stops running in a secure env …

[GitBox <gi...@apache.org>]

arpadboda commented on a change in pull request #708: MINIFICPP-1118 - MiNiFi C++ on Windows stops running in a secure env …
URL: https://github.com/apache/nifi-minifi-cpp/pull/708#discussion_r366255210
 
 

 ##########
 File path: libminifi/src/io/tls/TLSSocket.cpp
 ##########
 @@ -182,7 +182,15 @@ int16_t TLSSocket::initialize(bool blocking) {
     setNonBlocking();
   logger_->log_trace("Initializing TLSSocket %d", is_server);
   int16_t ret = context_->initialize(is_server);
-  Socket::initialize();
+
+  if (ret == 0) {
 
 Review comment:
   Fair point, simplified a bit. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services