You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "kitswas (via GitHub)" <gi...@apache.org> on 2023/03/09 12:39:28 UTC
[GitHub] [commons-numbers] kitswas opened a new pull request, #128: Updated the checkstyle supressions file
kitswas opened a new pull request, #128:
URL: https://github.com/apache/commons-numbers/pull/128
Added missing regexes for paths to support both Windows and *nix.
On Windows, the path separator is `\` not `/`.
As a result, the build fails due to Checkstyle violations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-numbers] codecov-commenter commented on pull request #128: Updated the checkstyle supressions file
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #128:
URL: https://github.com/apache/commons-numbers/pull/128#issuecomment-1462005439
# [Codecov](https://codecov.io/gh/apache/commons-numbers/pull/128?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#128](https://codecov.io/gh/apache/commons-numbers/pull/128?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3681d27) into [master](https://codecov.io/gh/apache/commons-numbers/commit/c1febffbdd0988465bda33224ea6e03823e155cd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1febff) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #128 +/- ##
=========================================
Coverage 99.14% 99.14%
Complexity 1681 1681
=========================================
Files 65 65
Lines 4310 4310
Branches 855 855
=========================================
Hits 4273 4273
Misses 10 10
Partials 27 27
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-numbers] aherbert merged pull request #128: Updated the checkstyle supressions file
Posted by "aherbert (via GitHub)" <gi...@apache.org>.
aherbert merged PR #128:
URL: https://github.com/apache/commons-numbers/pull/128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-numbers] kitswas commented on pull request #128: Updated the checkstyle supressions file
Posted by "kitswas (via GitHub)" <gi...@apache.org>.
kitswas commented on PR #128:
URL: https://github.com/apache/commons-numbers/pull/128#issuecomment-1461988755
@aherbert Is this alright?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-numbers] aherbert commented on pull request #128: Updated the checkstyle supressions file
Posted by "aherbert (via GitHub)" <gi...@apache.org>.
aherbert commented on PR #128:
URL: https://github.com/apache/commons-numbers/pull/128#issuecomment-1461999842
Looks good. Please feedback any other issues you have with building on Windows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org