You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/12/22 21:23:00 UTC
Review Request 64814: Renamed isCommandExecutor to
isGeneratedForCommandTask.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64814/
-----------------------------------------------------------
Review request for mesos and Chun-Hung Hsiao.
Repository: mesos
Description
-------
The name `isCommandExecutor` is not really precise because it could also
for Docker Executor. This patch renamed this method to be more accurate.
Diffs
-----
src/slave/slave.hpp e0f0c82981b735b2ae1d94309a9e84f673d20cce
src/slave/slave.cpp dde3dac19b8fe32b9a08d89acca918be8d7f38c5
Diff: https://reviews.apache.org/r/64814/diff/1/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 64814: Renamed isCommandExecutor to
isGeneratedForCommandTask.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64814/#review194464
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On Dec. 22, 2017, 9:22 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64814/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2017, 9:22 p.m.)
>
>
> Review request for mesos and Chun-Hung Hsiao.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The name `isCommandExecutor` is not really precise because it could also
> for Docker Executor. This patch renamed this method to be more accurate.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp e0f0c82981b735b2ae1d94309a9e84f673d20cce
> src/slave/slave.cpp dde3dac19b8fe32b9a08d89acca918be8d7f38c5
>
>
> Diff: https://reviews.apache.org/r/64814/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>