[jira] [Comment Edited] (SOLR-11763) Upgrade Guava to 23.0

["Uwe Schindler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-11763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452691#comment-16452691 ] 

Uwe Schindler edited comment on SOLR-11763 at 4/25/18 5:25 PM:
---------------------------------------------------------------

+1. I know that Elasticsearch did this 2 years ago and the code looks much cleaner now. Most of the Guava stuff can be replaced by some Java 8 streams constructs. Only the parts using immutable collections as static final fields is harder, but can be easily fixed by a utility class that emulates Java 9 Apis like Set.of(...), List.of(...), Map.of(....).


was (Author: thetaphi):
+1. I know that Elasticsearch started to do this and the code looks much cleaner now. Most of the Guava stuff can be replaced by some Java 8 streams constructs. Only the parts using immutable collections as static final fields is harder, but can be easily fixed by a utility class that emulates Java 9 Apis like Set.of(...), List.of(...), Map.of(....).

> Upgrade Guava to 23.0
> ---------------------
>
>                 Key: SOLR-11763
>                 URL: https://issues.apache.org/jira/browse/SOLR-11763
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: 7.1
>            Reporter: Markus Jelsma
>            Priority: Minor
>             Fix For: master (8.0)
>
>         Attachments: SOLR-11763.patch, SOLR-11763.patch
>
>
> Our code is running into version conflicts with Solr's old Guava dependency. This fixes it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org