You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "hussein-awala (via GitHub)" <gi...@apache.org> on 2023/02/13 01:12:50 UTC

[GitHub] [airflow] hussein-awala commented on a diff in pull request #29490: Add execution_date attribute to TaskFail

hussein-awala commented on code in PR #29490:
URL: https://github.com/apache/airflow/pull/29490#discussion_r1103914729


##########
airflow/models/taskfail.py:
##########
@@ -76,6 +76,7 @@ def __init__(self, ti):
             self.duration = int((self.end_date - self.start_date).total_seconds())
         else:
             self.duration = None
+        self.execution_date = None

Review Comment:
   This attribute was replaced by `run_id` in this [PR](https://github.com/apache/airflow/pull/22260/files#diff-2311f4d526a373d3bfce455397245e2358a4fccccbfb2d132f78eae9e5f74fceL30-R35), and I don't think we need to recreate it. It is difficult to know if this can solve the issue without being able to reproduce it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org