You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/17 15:37:09 UTC

[GitHub] [doris] 924060929 commented on a diff in pull request #10240: [Refactor](nereids) Abstract interface of statistics framework for new optimizer reuse

924060929 commented on code in PR #10240:
URL: https://github.com/apache/doris/pull/10240#discussion_r900267355


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/PlaceHolderPlan.java:
##########
@@ -81,4 +85,34 @@ public PlaceHolderPlan withChildren(List<Plan> children) {
         Preconditions.checkArgument(children.size() == 0);
         return new PlaceHolderPlan(logicalProperties);
     }
+
+    @Override
+    public List<? extends PlanStats> getChildrenStats() {
+        return null;
+    }
+
+    @Override
+    public StatsDeriveResult getStatsDeriveResult() {
+        return null;
+    }
+
+    @Override
+    public StatisticalType getNodeType() {

Review Comment:
   ```suggestion
       public StatisticalType getStatisticalType() {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org