[GitHub] [tinkerpop] divijvaidya commented on a change in pull request #1168: TINKERPOP-2246 Use ResponseHandlerContext to ensure single final response to client

[GitBox <gi...@apache.org>]

divijvaidya commented on a change in pull request #1168: TINKERPOP-2246 Use ResponseHandlerContext to ensure single final response to client
URL: https://github.com/apache/tinkerpop/pull/1168#discussion_r307549120
 
 

 ##########
 File path: gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/ResponseHandlerContextTest.java
 ##########
 @@ -57,32 +56,32 @@
     public static Iterable<Object[]> data() {
         return Arrays.asList(new Object[][] {
                 {
-                    new BiFunction<ResponseHandlerContext, ResponseStatusCode, Void>() {
-                        @Override
-                        public Void apply(final ResponseHandlerContext context, final ResponseStatusCode code) {
-                            context.writeAndFlush(code, "testMessage");
-                            return null;
+                        new BiFunction<Context, ResponseStatusCode, Void>() {
 
 Review comment:
   nit
   
   seems like alignment is inconsistent with the next BiFunction block

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services