You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2009/04/22 07:03:47 UTC
[jira] Created: (HADOOP-5717) Create public enum class for the
Framework counters in org.apache.hadoop.mapreduce
Create public enum class for the Framework counters in org.apache.hadoop.mapreduce
----------------------------------------------------------------------------------
Key: HADOOP-5717
URL: https://issues.apache.org/jira/browse/HADOOP-5717
Project: Hadoop Core
Issue Type: Improvement
Reporter: Owen O'Malley
Assignee: Amareshwari Sriramadasu
We need to make the counters from the framework visible, but they should be in the new package (org.apache.hadoop.mapreduce).
For compatibility, we need the old class of counters to recognize the old class and package names and convert them over to the new names.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5717) Create public enum class for the
Framework counters in org.apache.hadoop.mapreduce
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5717:
--------------------------------------------
Status: Patch Available (was: Open)
> Create public enum class for the Framework counters in org.apache.hadoop.mapreduce
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-5717
> URL: https://issues.apache.org/jira/browse/HADOOP-5717
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5717-1.txt, patch-5717.txt
>
>
> We need to make the counters from the framework visible, but they should be in the new package (org.apache.hadoop.mapreduce).
> For compatibility, we need the old class of counters to recognize the old class and package names and convert them over to the new names.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5717) Create public enum class for the
Framework counters in org.apache.hadoop.mapreduce
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705693#action_12705693 ]
Hudson commented on HADOOP-5717:
--------------------------------
Integrated in Hadoop-trunk #826 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/826/])
. Create public enum class for the Framework counters. Contributed by Amareshwari Sriramadasu.
> Create public enum class for the Framework counters in org.apache.hadoop.mapreduce
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-5717
> URL: https://issues.apache.org/jira/browse/HADOOP-5717
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5717-1.txt, patch-5717-2.txt, patch-5717.txt
>
>
> We need to make the counters from the framework visible, but they should be in the new package (org.apache.hadoop.mapreduce).
> For compatibility, we need the old class of counters to recognize the old class and package names and convert them over to the new names.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5717) Create public enum class for the
Framework counters in org.apache.hadoop.mapreduce
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5717:
--------------------------------------------
Attachment: patch-5717.txt
Attaching patch for moving framework counters to public class in mapreduce package. and providing the support for old group names in Counters class.
> Create public enum class for the Framework counters in org.apache.hadoop.mapreduce
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-5717
> URL: https://issues.apache.org/jira/browse/HADOOP-5717
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Attachments: patch-5717.txt
>
>
> We need to make the counters from the framework visible, but they should be in the new package (org.apache.hadoop.mapreduce).
> For compatibility, we need the old class of counters to recognize the old class and package names and convert them over to the new names.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5717) Create public enum class for the
Framework counters in org.apache.hadoop.mapreduce
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703995#action_12703995 ]
Hadoop QA commented on HADOOP-5717:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12406596/patch-5717-1.txt
against trunk revision 769623.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 24 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/257/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/257/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/257/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/257/console
This message is automatically generated.
> Create public enum class for the Framework counters in org.apache.hadoop.mapreduce
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-5717
> URL: https://issues.apache.org/jira/browse/HADOOP-5717
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5717-1.txt, patch-5717.txt
>
>
> We need to make the counters from the framework visible, but they should be in the new package (org.apache.hadoop.mapreduce).
> For compatibility, we need the old class of counters to recognize the old class and package names and convert them over to the new names.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5717) Create public enum class for the
Framework counters in org.apache.hadoop.mapreduce
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5717:
--------------------------------------------
Status: Open (was: Patch Available)
> Create public enum class for the Framework counters in org.apache.hadoop.mapreduce
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-5717
> URL: https://issues.apache.org/jira/browse/HADOOP-5717
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5717-1.txt, patch-5717-2.txt, patch-5717.txt
>
>
> We need to make the counters from the framework visible, but they should be in the new package (org.apache.hadoop.mapreduce).
> For compatibility, we need the old class of counters to recognize the old class and package names and convert them over to the new names.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5717) Create public enum class for the
Framework counters in org.apache.hadoop.mapreduce
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5717:
--------------------------------------------
Attachment: patch-5717-1.txt
Patch fixing the test failure.
> Create public enum class for the Framework counters in org.apache.hadoop.mapreduce
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-5717
> URL: https://issues.apache.org/jira/browse/HADOOP-5717
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5717-1.txt, patch-5717.txt
>
>
> We need to make the counters from the framework visible, but they should be in the new package (org.apache.hadoop.mapreduce).
> For compatibility, we need the old class of counters to recognize the old class and package names and convert them over to the new names.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5717) Create public enum class for the
Framework counters in org.apache.hadoop.mapreduce
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703323#action_12703323 ]
Hadoop QA commented on HADOOP-5717:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12406500/patch-5717.txt
against trunk revision 768376.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 21 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/251/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/251/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/251/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/251/console
This message is automatically generated.
> Create public enum class for the Framework counters in org.apache.hadoop.mapreduce
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-5717
> URL: https://issues.apache.org/jira/browse/HADOOP-5717
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5717.txt
>
>
> We need to make the counters from the framework visible, but they should be in the new package (org.apache.hadoop.mapreduce).
> For compatibility, we need the old class of counters to recognize the old class and package names and convert them over to the new names.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5717) Create public enum class for the
Framework counters in org.apache.hadoop.mapreduce
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5717:
--------------------------------------------
Status: Open (was: Patch Available)
> Create public enum class for the Framework counters in org.apache.hadoop.mapreduce
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-5717
> URL: https://issues.apache.org/jira/browse/HADOOP-5717
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5717.txt
>
>
> We need to make the counters from the framework visible, but they should be in the new package (org.apache.hadoop.mapreduce).
> For compatibility, we need the old class of counters to recognize the old class and package names and convert them over to the new names.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5717) Create public enum class for the
Framework counters in org.apache.hadoop.mapreduce
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5717:
--------------------------------------------
Fix Version/s: 0.21.0
Status: Patch Available (was: Open)
All tests passed on my machine.
Existing unit tests in core test the new counters. contrib-tests test the deprecation for old group names.
> Create public enum class for the Framework counters in org.apache.hadoop.mapreduce
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-5717
> URL: https://issues.apache.org/jira/browse/HADOOP-5717
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5717.txt
>
>
> We need to make the counters from the framework visible, but they should be in the new package (org.apache.hadoop.mapreduce).
> For compatibility, we need the old class of counters to recognize the old class and package names and convert them over to the new names.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5717) Create public enum class for the
Framework counters in org.apache.hadoop.mapreduce
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5717:
--------------------------------------------
Attachment: patch-5717-2.txt
Patch incorporating review comments.
> Create public enum class for the Framework counters in org.apache.hadoop.mapreduce
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-5717
> URL: https://issues.apache.org/jira/browse/HADOOP-5717
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5717-1.txt, patch-5717-2.txt, patch-5717.txt
>
>
> We need to make the counters from the framework visible, but they should be in the new package (org.apache.hadoop.mapreduce).
> For compatibility, we need the old class of counters to recognize the old class and package names and convert them over to the new names.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5717) Create public enum class for the
Framework counters in org.apache.hadoop.mapreduce
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5717:
--------------------------------------------
Status: Patch Available (was: Open)
test-patch result:
{noformat}
[exec]
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 24 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
{noformat}
> Create public enum class for the Framework counters in org.apache.hadoop.mapreduce
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-5717
> URL: https://issues.apache.org/jira/browse/HADOOP-5717
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5717-1.txt, patch-5717-2.txt, patch-5717.txt
>
>
> We need to make the counters from the framework visible, but they should be in the new package (org.apache.hadoop.mapreduce).
> For compatibility, we need the old class of counters to recognize the old class and package names and convert them over to the new names.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5717) Create public enum class for the
Framework counters in org.apache.hadoop.mapreduce
Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704517#action_12704517 ]
Sharad Agarwal commented on HADOOP-5717:
----------------------------------------
The resource bundle files - (Task_Counter.properties and JobInProgress_Counter.properties) should be renamed as per the new class names and moved to mapreduce package.
> Create public enum class for the Framework counters in org.apache.hadoop.mapreduce
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-5717
> URL: https://issues.apache.org/jira/browse/HADOOP-5717
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5717-1.txt, patch-5717.txt
>
>
> We need to make the counters from the framework visible, but they should be in the new package (org.apache.hadoop.mapreduce).
> For compatibility, we need the old class of counters to recognize the old class and package names and convert them over to the new names.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5717) Create public enum class for the
Framework counters in org.apache.hadoop.mapreduce
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704598#action_12704598 ]
Amareshwari Sriramadasu commented on HADOOP-5717:
-------------------------------------------------
All unit tests passed on my machine.
> Create public enum class for the Framework counters in org.apache.hadoop.mapreduce
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-5717
> URL: https://issues.apache.org/jira/browse/HADOOP-5717
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5717-1.txt, patch-5717-2.txt, patch-5717.txt
>
>
> We need to make the counters from the framework visible, but they should be in the new package (org.apache.hadoop.mapreduce).
> For compatibility, we need the old class of counters to recognize the old class and package names and convert them over to the new names.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5717) Create public enum class for the
Framework counters in org.apache.hadoop.mapreduce
Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sharad Agarwal updated HADOOP-5717:
-----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks Amareshwari!
> Create public enum class for the Framework counters in org.apache.hadoop.mapreduce
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-5717
> URL: https://issues.apache.org/jira/browse/HADOOP-5717
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Owen O'Malley
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5717-1.txt, patch-5717-2.txt, patch-5717.txt
>
>
> We need to make the counters from the framework visible, but they should be in the new package (org.apache.hadoop.mapreduce).
> For compatibility, we need the old class of counters to recognize the old class and package names and convert them over to the new names.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.