You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Thorhallur Sverrisson <to...@toti.is> on 2015/07/26 15:18:45 UTC

Review Request 36818: Wrong label on table heading for in progress updates

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36818/
-----------------------------------------------------------

Review request for Aurora.


Bugs: AURORA-1241
    https://issues.apache.org/jira/browse/AURORA-1241


Repository: aurora


Description
-------

Simple change of the column heading from ended to last modified.

Bugs closed: AURORA-1241


Diffs
-----

  src/main/resources/scheduler/assets/latestUpdates.html bcdb70f8680ebd79b424580a048cfdb611a56f0d 

Diff: https://reviews.apache.org/r/36818/diff/


Testing
-------


Thanks,

Thorhallur Sverrisson


Re: Review Request 36818: Wrong label on table heading for in progress updates

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36818/#review93058
-----------------------------------------------------------


Master (da18d14) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On July 26, 2015, 8:22 p.m., Thorhallur Sverrisson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36818/
> -----------------------------------------------------------
> 
> (Updated July 26, 2015, 8:22 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-1241
>     https://issues.apache.org/jira/browse/AURORA-1241
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Simple change of the column heading from ended to last modified.
> 
> Bugs closed: AURORA-1241
> 
> 
> Diffs
> -----
> 
>   src/main/resources/scheduler/assets/job.html 0c8fd54d7d11318fc0dd2bdd56769dfb3ead9849 
>   src/main/resources/scheduler/assets/latestUpdates.html bcdb70f8680ebd79b424580a048cfdb611a56f0d 
> 
> Diff: https://reviews.apache.org/r/36818/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thorhallur Sverrisson
> 
>


Re: Review Request 36818: Wrong label on table heading for in progress updates

Posted by Thorhallur Sverrisson <to...@toti.is>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36818/
-----------------------------------------------------------

(Updated July 26, 2015, 8:22 p.m.)


Review request for Aurora.


Changes
-------

Found another 'ended' column in job.html, including in change set.


Bugs: AURORA-1241
    https://issues.apache.org/jira/browse/AURORA-1241


Repository: aurora


Description
-------

Simple change of the column heading from ended to last modified.

Bugs closed: AURORA-1241


Diffs (updated)
-----

  src/main/resources/scheduler/assets/job.html 0c8fd54d7d11318fc0dd2bdd56769dfb3ead9849 
  src/main/resources/scheduler/assets/latestUpdates.html bcdb70f8680ebd79b424580a048cfdb611a56f0d 

Diff: https://reviews.apache.org/r/36818/diff/


Testing
-------


Thanks,

Thorhallur Sverrisson


Re: Review Request 36818: Wrong label on table heading for in progress updates

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36818/#review93041
-----------------------------------------------------------


Master (da18d14) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On July 26, 2015, 1:18 p.m., Thorhallur Sverrisson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36818/
> -----------------------------------------------------------
> 
> (Updated July 26, 2015, 1:18 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-1241
>     https://issues.apache.org/jira/browse/AURORA-1241
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Simple change of the column heading from ended to last modified.
> 
> Bugs closed: AURORA-1241
> 
> 
> Diffs
> -----
> 
>   src/main/resources/scheduler/assets/latestUpdates.html bcdb70f8680ebd79b424580a048cfdb611a56f0d 
> 
> Diff: https://reviews.apache.org/r/36818/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thorhallur Sverrisson
> 
>