You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by JervenBolleman <gi...@git.apache.org> on 2017/10/23 09:35:34 UTC
[GitHub] jena pull request #291: Bad regular expression patterns should throw ExprEva...
GitHub user JervenBolleman opened a pull request:
https://github.com/apache/jena/pull/291
Bad regular expression patterns should throw ExprEvalException
instead of PatternSyntaxException
This is a minimal patch that throws and ExprEvalException when given bad regular expressions in str replace.
Per internal SIB policies I am authorized to make small patches such as this available under the Apache v2 license.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JervenBolleman/jena master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/291.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #291
----
commit fb1a171323a504c96713e3be6cc4f59e02e43629
Author: Jerven Bolleman <je...@isb-sib.ch>
Date: 2017-10-23T09:30:15Z
Bad regular expression patterns should throw ExprEvalException instead of PatternSyntaxException
----
---
[GitHub] jena issue #291: Bad regular expression patterns should throw ExprEvalExcept...
Posted by rvesse <gi...@git.apache.org>.
Github user rvesse commented on the issue:
https://github.com/apache/jena/pull/291
LGTM +1
---
[GitHub] jena pull request #291: Bad regular expression patterns should throw ExprEva...
Posted by JervenBolleman <gi...@git.apache.org>.
Github user JervenBolleman closed the pull request at:
https://github.com/apache/jena/pull/291
---
[GitHub] jena issue #291: Bad regular expression patterns should throw ExprEvalExcept...
Posted by afs <gi...@git.apache.org>.
Github user afs commented on the issue:
https://github.com/apache/jena/pull/291
PR#292 includes this - I pulled it so the commit here is in the commits for #292. Should be in 3.5.0.
@JervenBolleman Thanks for closing.
---
[GitHub] jena issue #291: Bad regular expression patterns should throw ExprEvalExcept...
Posted by JervenBolleman <gi...@git.apache.org>.
Github user JervenBolleman commented on the issue:
https://github.com/apache/jena/pull/291
@afs @rvesse thanks for improving the patch looking forward to see it in a production release (hopefully 3.5). The JENA-1403 pull request includes this one so I will close this one
---
[GitHub] jena issue #291: Bad regular expression patterns should throw ExprEvalExcept...
Posted by afs <gi...@git.apache.org>.
Github user afs commented on the issue:
https://github.com/apache/jena/pull/291
[JENA-1304](https://issues.apache.org/jira/browse/JENA-1403)
---