You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2016/09/19 16:02:37 UTC
[GitHub] zeppelin pull request #1438: [ZEPPELIN-1458] Fix compiling error on branch-0...
GitHub user minahlee opened a pull request:
https://github.com/apache/zeppelin/pull/1438
[ZEPPELIN-1458] Fix compiling error on branch-0.6
### What is this PR for?
Fix compiling error on branch-0.6.
- Revert #1333
- Change `InterpreterProperty.getValue` -> `SparkInterpreter.getSystemDefault` method since `InterpreterProperty.getValue` only exists in master.
### What type of PR is it?
Hot Fix
### What is the Jira issue?
[ZEPPELIN-1458](https://issues.apache.org/jira/browse/ZEPPELIN-1458)
### How should this be tested?
Try mvn build on branch-0.6 and see if compile error is gone.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/minahlee/zeppelin ZEPPELIN-1458
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1438.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1438
----
commit da622bbfdac58fc60d8c12d984796e5ec8615fa7
Author: Mina Lee <mi...@apache.org>
Date: 2016-09-19T15:26:18Z
Revert "[ZEPPELIN-1334] Environment variable defined in interpreter setting doesn't take effect"
This reverts commit 074ce6f972e0538b618a5b060ad131f576cf8a66.
commit 438452c72b4caf759fb82da91bbb9809df6cf1e4
Author: Mina Lee <mi...@apache.org>
Date: 2016-09-19T15:41:51Z
Use old way of getting default property to prevent compiling error
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1438: [ZEPPELIN-1458] Fix compiling error on branch-0.6
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1438
@minahlee diff of InterpreterFactory.java looks different than https://github.com/apache/zeppelin/pull/1333/files#diff-53b87ca4f9616e88837a1b0dd050c01aR995
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1438: [ZEPPELIN-1458] Fix compiling error on branch-0.6
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1438
@prabhjyotsingh diff looks different because diff of #1333 is based on master branch. https://github.com/apache/zeppelin/commit/074ce6f972e0538b618a5b060ad131f576cf8a66 this would be the proper view where you can check diff based on branch-0.6.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1438: [HOTFIX][ZEPPELIN-1458] Fix compiling error on branch-...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1438
Merge if there is no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1438: [HOTFIX][ZEPPELIN-1458] Fix compiling error on branch-...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1438
@minahlee @prabhjyotsingh Please ignore my last comment. I just found that the issue of ZEPPELIN-1458 doesn't exist in branch-0.6. But found another issue, @jongyoul It seems creating new interpreter breaks in branch-0.6. I created a new interpreter called spark2, but will hit the following error.
It looks like in branch-0.6, we still load interpreter from Interpreter.registeredInterpreters rather than InterpereterSetting. (NoteInterpreterLoader.java)
```
Interpreter.RegisteredInterpreter registeredInterpreter = Interpreter.registeredInterpreters
.get(group + "." + name);
if (registeredInterpreter == null
|| registeredInterpreter.getClassName() == null) {
throw new InterpreterException(replName + " interpreter not found");
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1438: [HOTFIX][ZEPPELIN-1458] Fix compiling error on branch-...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1438
@minahlee @prabhjyotsingh This is a blocker of 0.6.2 release, I will make another PR for branch-0.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1438: [ZEPPELIN-1458] Fix compiling error on branch-0.6
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1438
Got it, thanks for the explanation. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1438: [ZEPPELIN-1458] Fix compiling error on branch-0.6
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1438
Rest tried, compiled, build. Tested with spark and jdbc interpreter, both works normally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1438: [HOTFIX][ZEPPELIN-1458] Fix compiling error on branch-...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1438
@minahlee Thanks for letting me know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1438: [HOTFIX][ZEPPELIN-1458] Fix compiling error on branch-...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1438
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1438: [HOTFIX][ZEPPELIN-1458] Fix compiling error on branch-...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1438
@zjffdu using interpreter alias name is available only in master branch. You will need to use `%spark` instead of `%spark2` in branch-0.6.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1438: [HOTFIX][ZEPPELIN-1458] Fix compiling error on ...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee closed the pull request at:
https://github.com/apache/zeppelin/pull/1438
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---