You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by praetp <gi...@git.apache.org> on 2018/08/08 12:08:10 UTC
[GitHub] spark pull request #21518: [SPARK-24502][SQL] flaky test: UnsafeRowSerialize...
Github user praetp commented on a diff in the pull request:
https://github.com/apache/spark/pull/21518#discussion_r208555306
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/UnsafeRowSerializerSuite.scala ---
@@ -45,6 +44,14 @@ class ClosableByteArrayInputStream(buf: Array[Byte]) extends ByteArrayInputStrea
class UnsafeRowSerializerSuite extends SparkFunSuite with LocalSparkContext {
+ override def beforeAll() {
+ super.beforeAll()
+ // This test suite calls `UnsafeProjection.create` which accesses `SQLConf.get`, we should make
+ // sure active session is cleaned so that `SQLConf.get` won't refer to a stopped session.
+ SparkSession.clearActiveSession()
+ SparkSession.clearDefaultSession()
--- End diff --
@squito @cloud-fan : we are facing similar issues in our own Spark tests. Are you saying just closing the sparkSession is not enough ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org