You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "AMashenkov (via GitHub)" <gi...@apache.org> on 2023/09/28 10:13:56 UTC
[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2637: IGNITE-20502 Sql. Rework fragment mapping
AMashenkov commented on code in PR #2637:
URL: https://github.com/apache/ignite-3/pull/2637#discussion_r1339876829
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/mapping/ColocationGroup.java:
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.sql.engine.exec.mapping;
+
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.Objects;
+import org.apache.ignite.internal.sql.engine.exec.NodeWithTerm;
+import org.apache.ignite.internal.sql.engine.exec.PartitionWithTerm;
+
+/**
+ * A group of a sources which shares common set of nodes and assignments to be executed.
+ *
+ * <p>Although source is essentially a leaf node of the fragment represented by scan operator or receiver,
+ * there might be intermediate relations that require to be mapped to the certain topology, thus having
+ * its own "source" identifier, and, as a result, being part of the colocation group.
+ */
+public class ColocationGroup implements Serializable {
+ private static final long serialVersionUID = 1370403193139083025L;
+
+ private final List<Long> sourceIds;
+
+ private final List<String> nodeNames;
+
+ private final List<NodeWithTerm> assignments;
+
+ /** Constructor. */
+ public ColocationGroup(List<Long> sourceIds, List<String> nodeNames, List<NodeWithTerm> assignments) {
+ this.sourceIds = sourceIds;
+ this.nodeNames = nodeNames;
+ this.assignments = assignments;
+ }
+
+ /**
+ * Get lists of colocation group sources.
+ */
+ public List<Long> sourceIds() {
+ return sourceIds == null ? Collections.emptyList() : sourceIds;
Review Comment:
Should we mark constructor arguments as @Nullable and initialize fields with `emptyList()` in constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org