You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/08/22 13:17:46 UTC
Review Request 71350: Used `local` master in
`ExampleTest.DiskFullFramework`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71350/
-----------------------------------------------------------
Review request for mesos and Till Toenshoff.
Bugs: MESOS-9952
https://issues.apache.org/jira/browse/MESOS-9952
Repository: mesos
Description
-------
This removes up to 4s runtime from the test as we do not have to wait
for the master or agent to be up and running in the script.
Diffs
-----
src/tests/disk_full_framework_test.sh 83ae0947d4f5ec0a960e8cefa925cacbe6c6808e
Diff: https://reviews.apache.org/r/71350/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 71350: Used `local` master in
`ExampleTest.DiskFullFramework`.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71350/
-----------------------------------------------------------
(Updated Aug. 23, 2019, 1:08 p.m.)
Review request for mesos and Till Toenshoff.
Changes
-------
Address issue raised by Jan
Bugs: MESOS-9952
https://issues.apache.org/jira/browse/MESOS-9952
Repository: mesos
Description
-------
This removes up to 4s runtime from the test as we do not have to wait
for the master or agent to be up and running in the script.
Diffs (updated)
-----
cmake/MesosConfigure.cmake 83d41addcd2c14358fba8bab2ac654475626a3e8
src/tests/disk_full_framework_test.sh 83ae0947d4f5ec0a960e8cefa925cacbe6c6808e
Diff: https://reviews.apache.org/r/71350/diff/2/
Changes: https://reviews.apache.org/r/71350/diff/1-2/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 71350: Used `local` master in
`ExampleTest.DiskFullFramework`.
Posted by Jan Schlicht <ja...@d2iq.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71350/#review217395
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/disk_full_framework_test.sh
Line 15 (original), 13 (patched)
<https://reviews.apache.org/r/71350/#comment304681>
s/MESOS_RUNTIME_DIR/MESOS_WORK_DIR/
- Jan Schlicht
On Aug. 22, 2019, 3:17 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71350/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2019, 3:17 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9952
> https://issues.apache.org/jira/browse/MESOS-9952
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This removes up to 4s runtime from the test as we do not have to wait
> for the master or agent to be up and running in the script.
>
>
> Diffs
> -----
>
> src/tests/disk_full_framework_test.sh 83ae0947d4f5ec0a960e8cefa925cacbe6c6808e
>
>
> Diff: https://reviews.apache.org/r/71350/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>