[GitHub] [ranger] mneethiraj commented on a change in pull request #135: RANGER-3010. Change the function of addUsersAndGroups & removeUsersAn…

[GitBox <gi...@apache.org>]

mneethiraj commented on a change in pull request #135:
URL: https://github.com/apache/ranger/pull/135#discussion_r820275599



##########
File path: security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java
##########
@@ -745,18 +745,20 @@ public RangerRole getRole(@PathParam("id") Long id, @Context HttpServletRequest
     	This API is used to add users and groups with/without GRANT privileges to this Role. It follows add-or-update semantics
  	 */
 	@PUT
-	@Path("/api/roles/{id}/addUsersAndGroups")
-	public RangerRole addUsersAndGroups(@PathParam("id") Long roleId, List<String> users, List<String> groups, Boolean isAdmin, @Context HttpServletRequest request) {
-		return roleREST.addUsersAndGroups(roleId, users, groups, isAdmin);

Review comment:
       @ted12138  - thank you for the patch. The changes look good.
   
   One suggestion: to be consistent with use of` {id}` and `{name}` in APIs, I would suggest to retain `{id}` in this API and introduce another API for using `{name}` - like: `/api/roles/name/{name}/addUserAndGroups`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org