You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/23 10:02:07 UTC
[GitHub] [apisix] Firstsawyou opened a new pull request #3645: docs: update install-dependencies.md doc
Firstsawyou opened a new pull request #3645:
URL: https://github.com/apache/apisix/pull/3645
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
The Mac OSX environment lacks the installation steps of `LuaRocks`. so it needs to be added.
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #3645: docs: update install-dependencies.md doc
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #3645:
URL: https://github.com/apache/apisix/pull/3645#discussion_r580971709
##########
File path: doc/install-dependencies.md
##########
@@ -150,6 +150,9 @@ nohup etcd &
# install OpenResty, etcd and some compilation tools
brew install openresty/brew/openresty etcd luarocks curl git
Review comment:
Since we will install luarocks from source, I think it can be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #3645: docs: update install-dependencies.md doc
Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on a change in pull request #3645:
URL: https://github.com/apache/apisix/pull/3645#discussion_r580970214
##########
File path: doc/install-dependencies.md
##########
@@ -150,6 +150,9 @@ nohup etcd &
# install OpenResty, etcd and some compilation tools
brew install openresty/brew/openresty etcd luarocks curl git
Review comment:
To ensure that the installed version of LuaRocks is correct, I think it should be added. This is an error problem encountered when installing according to the document:
<img width="493" alt="截屏2021-02-23 下午7 18 18" src="https://user-images.githubusercontent.com/52862365/108838928-50602f80-760f-11eb-85fb-09f48ef0cd1f.png">
<img width="525" alt="截屏2021-02-23 下午7 19 56" src="https://user-images.githubusercontent.com/52862365/108839001-6bcb3a80-760f-11eb-87e8-df8889c62628.png">
<img width="547" alt="截屏2021-02-23 下午7 42 04" src="https://user-images.githubusercontent.com/52862365/108839043-74bc0c00-760f-11eb-84f6-82db83065b30.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou closed pull request #3645: docs: update install-dependencies.md doc
Posted by GitBox <gi...@apache.org>.
Firstsawyou closed pull request #3645:
URL: https://github.com/apache/apisix/pull/3645
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on pull request #3645: docs: update install-dependencies.md doc
Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on pull request #3645:
URL: https://github.com/apache/apisix/pull/3645#issuecomment-793879331
It has been fixed by https://github.com/apache/apisix/pull/3718.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] idbeta commented on a change in pull request #3645: docs: update install-dependencies.md doc
Posted by GitBox <gi...@apache.org>.
idbeta commented on a change in pull request #3645:
URL: https://github.com/apache/apisix/pull/3645#discussion_r580931339
##########
File path: doc/install-dependencies.md
##########
@@ -150,6 +150,9 @@ nohup etcd &
# install OpenResty, etcd and some compilation tools
brew install openresty/brew/openresty etcd luarocks curl git
Review comment:
this can be removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org