You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2021/07/21 11:33:37 UTC
[GitHub] [incubator-eventmesh] ruanwenjun opened a new pull request #450: [ISSUE #442] update checkStyle file
ruanwenjun opened a new pull request #450:
URL: https://github.com/apache/incubator-eventmesh/pull/450
Since the `sChat2.jks` has been removed, we can remove the filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] SteveYurongSu commented on pull request #450: [ISSUE #442] update checkStyle file
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on pull request #450:
URL: https://github.com/apache/incubator-eventmesh/pull/450#issuecomment-884641231
> @SteveYurongSu This file is used for ssl configure, it can be changed by user.
> https://github.com/apache/incubator-eventmesh/blob/4eaebde2506a582f8c211143b8d22dedf21e4f5c/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/SSLContextFactory.java#L44-L55
Thanks!
I don't know if we should keep the binary file in our repo, especially when we don't know what content is in.
Maybe documentation is needed for this file?
> What content is in?
> Or how to generate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on pull request #450: [ISSUE #442] update checkStyle file
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #450:
URL: https://github.com/apache/incubator-eventmesh/pull/450#issuecomment-884602231
@SteveYurongSu This file is used for ssl configure, it can be changed by user.
https://github.com/apache/incubator-eventmesh/blob/4eaebde2506a582f8c211143b8d22dedf21e4f5c/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/SSLContextFactory.java#L44-L55
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] SteveYurongSu commented on pull request #450: [ISSUE #442] update checkStyle file
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on pull request #450:
URL: https://github.com/apache/incubator-eventmesh/pull/450#issuecomment-884960236
> Maybe we can enhance this doc. So do you agree to keep this file, if this file is needed, we may need to filter this file in checkStyle file.
@ruanwenjun Yes, I agree. Let's keep this file in repo and add a filter in our checkStyle file. π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun closed pull request #450: [ISSUE #442] update checkStyle file
Posted by GitBox <gi...@apache.org>.
ruanwenjun closed pull request #450:
URL: https://github.com/apache/incubator-eventmesh/pull/450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on pull request #450: [ISSUE #442] update checkStyle file
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #450:
URL: https://github.com/apache/incubator-eventmesh/pull/450#issuecomment-884591491
@SteveYurongSu Hi, `sChat2.jks` has been added again, do you think we still need to remove this filter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] SteveYurongSu commented on pull request #450: [ISSUE #442] update checkStyle file
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on pull request #450:
URL: https://github.com/apache/incubator-eventmesh/pull/450#issuecomment-884597338
> @SteveYurongSu Hi, `sChat2.jks` has been added again, do you think we still need to remove this filter?
I have noticed that. @qqeasonchen What is the file used for? π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on pull request #450: [ISSUE #442] update checkStyle file
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #450:
URL: https://github.com/apache/incubator-eventmesh/pull/450#issuecomment-884836917
@SteveYurongSu Yes, there already has a doc about enable ssl, https://github.com/apache/incubator-eventmesh/blob/develop/docs/cn/features/https.zh-CN.md.
Maybe we can enhance this doc. So do you agree to keep this file, if this file is needed, we may need to filter this file in checkStyle file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov-commenter commented on pull request #450: [ISSUE #442] update checkStyle file
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #450:
URL: https://github.com/apache/incubator-eventmesh/pull/450#issuecomment-884124502
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/450?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#450](https://codecov.io/gh/apache/incubator-eventmesh/pull/450?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0b7a55c) into [develop](https://codecov.io/gh/apache/incubator-eventmesh/commit/7850620da2909b4b9b47916aebc355bcc3549502?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7850620) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-eventmesh/pull/450?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #450 +/- ##
=========================================
Coverage 9.84% 9.84%
Complexity 283 283
=========================================
Files 228 228
Lines 10829 10829
Branches 923 923
=========================================
Hits 1066 1066
Misses 9666 9666
Partials 97 97
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/450?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/450?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7850620...0b7a55c](https://codecov.io/gh/apache/incubator-eventmesh/pull/450?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org