You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by Andy Seaborne <an...@apache.org> on 2014/01/10 12:25:35 UTC
Build for jena 2.11.1 (jena-maven-tools)
I don't think this is ready for release.
Either we need to delay 2.11.1 or make it wait until the next release.
Removing from this release seems the better course to me so there is no
time issue on cleaning it up.
1/ I fixed up all the source files yesterday assuming it was just an
oversight.
2/ LICENSE wrong. I can fix that for the AL part but whether there is
more to add because ...
3/ there is no NOTICE
I see org.eclipse in the dependency tree so presumably EPL licensed
which needs mentioning.
Not fixed. I don't know how the dependencies are used.
4/ Package space is org.openjena (minor but easier to fix now?)
If cleanup is going to take a while, we ought to move it out of trunk
for the moment.
Andy
Re: Build for jena 2.11.1 (jena-maven-tools)
Posted by Andy Seaborne <an...@apache.org>.
On 17/01/14 14:45, Andy Seaborne wrote:
> On 15/01/14 23:31, Ian Dickinson wrote:
>> I've added the README, and committed all of the recent changes to the
>> version in Experimental (thanks Rob!). Is there anything remaining
>> blocking moving the code back to trunk?
>
> I don't see anything.
>
> I had a quick look for "openjena". The only occurrence that looks odd
> to me is plugin groupId in demo/pom.xml : not a blocker.
>
Done - I'll restart building a release to include this module.
Andy
Re: Build for jena 2.11.1 (jena-maven-tools)
Posted by Andy Seaborne <an...@apache.org>.
On 15/01/14 23:31, Ian Dickinson wrote:
> I've added the README, and committed all of the recent changes to the
> version in Experimental (thanks Rob!). Is there anything remaining
> blocking moving the code back to trunk?
I don't see anything.
I had a quick look for "openjena". The only occurrence that looks odd
to me is plugin groupId in demo/pom.xml : not a blocker.
Andy
>
> Ian
>
>
> On Wed, Jan 15, 2014 at 4:13 PM, Ian Dickinson <i....@gmail.com> wrote:
>> On Wed, Jan 15, 2014 at 3:47 PM, Andy Seaborne <an...@apache.org> wrote:
>>> On 15/01/14 15:21, Ian Dickinson wrote:
>>>>
>>>> Oh, and I've added a copy of the LICENSE file from the main project.
>>>> I'm not sure what else I need to put in there - do I need to
>>>> acknowledge the contribution from Shane St Clair that was submitted
>>>> via Jira?
>>
>>> Do either of the the top-level LICENCE or NOTICE files need to change to
>>> reflect dependencies of jena-maven-tools? These need to cover everything in
>>> trunk and ideally the project.
>> Not as far as I can tell. The only source code we distribute is
>> licensed under the Apache license. There are dependencies in the
>> pom.xml related to the process of running a Maven plugin, but we do
>> not distribute any of those dependencies (they will be pulled in, as
>> necessary, when the end user runs that Maven target).
>>
>>>
>>> See
>>> http://www.apache.org/legal/3party.html
>>>
>>> esp category B
>>>
>>> dependency:tree -->
>>>
>>> +- org.apache.maven:maven-plugin-api:jar:3.1.1:compile
>>> | +- org.apache.maven:maven-model:jar:3.1.1:compile
>>> | \- org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.0.0.M5:compile
>>> | +- javax.enterprise:cdi-api:jar:1.0:compile
>>> | | +- javax.annotation:jsr250-api:jar:1.0:compile
>>> | | \- javax.inject:javax.inject:jar:1:compile
>>> | +- com.google.guava:guava:jar:10.0.1:compile
>>> | | \- com.google.code.findbugs:jsr305:jar:1.3.9:compile
>>> | +- org.sonatype.sisu:sisu-guice:jar:no_aop:3.1.0:compile
>>> | | \- aopalliance:aopalliance:jar:1.0:compile
>>> | +- org.eclipse.sisu:org.eclipse.sisu.inject:jar:0.0.0.M5:compile
>>> | +- org.codehaus.plexus:plexus-component-annotations:jar:1.5.5:compile
>>> | \- org.codehaus.plexus:plexus-classworlds:jar:2.4:compile
>>>
>>> org.eclipse.sisu caught my attention and there are others that I don't know
>>> the status of. At that point I didn't know enough to sort it out at the
>>> time.
>>
>> As far as I can tell, the Sisu dependencies are related to running
>> certain kinds of Maven plugins, such as for OSGi. Since we don't
>> depend on that capability, I have excluded the dependency and
>> everything seems to be working OK. The revised dependency tree is:
>>
>> $ mvn dependency:tree
>> [INFO] Scanning for projects...
>> [INFO]
>> [INFO] ------------------------------------------------------------------------
>> [INFO] Building Jena plugins for Apache Maven,including schemagen 0.4-SNAPSHOT
>> [INFO] ------------------------------------------------------------------------
>> [INFO]
>> [INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ jena-maven-tools ---
>> [INFO] org.apache.jena:jena-maven-tools:maven-plugin:0.4-SNAPSHOT
>> [INFO] +- org.apache.maven.plugin-tools:maven-plugin-annotations:jar:3.2:provided
>> [INFO] | \- org.apache.maven:maven-artifact:jar:3.0:compile
>> [INFO] +- org.apache.maven:maven-plugin-api:jar:3.1.1:compile
>> [INFO] | \- org.apache.maven:maven-model:jar:3.1.1:compile
>> [INFO] +- org.apache.jena:jena-core:jar:2.11.1-SNAPSHOT:compile
>> [INFO] | +- org.apache.jena:jena-iri:jar:1.0.1-SNAPSHOT:compile
>> [INFO] | \- xerces:xercesImpl:jar:2.11.0:compile
>> [INFO] | \- xml-apis:xml-apis:jar:1.4.01:compile
>> [INFO] +- org.codehaus.plexus:plexus-utils:jar:3.0.15:compile
>> [INFO] +- junit:junit:jar:4.8.1:compile
>> [INFO] +- org.apache.maven.shared:maven-verifier:jar:1.2:compile
>> [INFO] +- org.slf4j:slf4j-api:jar:1.6.4:compile
>> [INFO] +- org.slf4j:slf4j-log4j12:jar:1.6.4:compile
>> [INFO] \- log4j:log4j:jar:1.2.16:compile
>>
>> There's nothing there that I can see that's not (a) already a Jena
>> dependency, or (b) an Apache product.
>>
>>> Acknowledgements are different - common ways include putting in a README,
>>> ReleaseNotes or ACKNOWLEDGEMENTS file for the module.
>> I'll add a README.
>>
>> Ian
Re: Build for jena 2.11.1 (jena-maven-tools)
Posted by Ian Dickinson <i....@gmail.com>.
I've added the README, and committed all of the recent changes to the
version in Experimental (thanks Rob!). Is there anything remaining
blocking moving the code back to trunk?
Ian
On Wed, Jan 15, 2014 at 4:13 PM, Ian Dickinson <i....@gmail.com> wrote:
> On Wed, Jan 15, 2014 at 3:47 PM, Andy Seaborne <an...@apache.org> wrote:
>> On 15/01/14 15:21, Ian Dickinson wrote:
>>>
>>> Oh, and I've added a copy of the LICENSE file from the main project.
>>> I'm not sure what else I need to put in there - do I need to
>>> acknowledge the contribution from Shane St Clair that was submitted
>>> via Jira?
>
>> Do either of the the top-level LICENCE or NOTICE files need to change to
>> reflect dependencies of jena-maven-tools? These need to cover everything in
>> trunk and ideally the project.
> Not as far as I can tell. The only source code we distribute is
> licensed under the Apache license. There are dependencies in the
> pom.xml related to the process of running a Maven plugin, but we do
> not distribute any of those dependencies (they will be pulled in, as
> necessary, when the end user runs that Maven target).
>
>>
>> See
>> http://www.apache.org/legal/3party.html
>>
>> esp category B
>>
>> dependency:tree -->
>>
>> +- org.apache.maven:maven-plugin-api:jar:3.1.1:compile
>> | +- org.apache.maven:maven-model:jar:3.1.1:compile
>> | \- org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.0.0.M5:compile
>> | +- javax.enterprise:cdi-api:jar:1.0:compile
>> | | +- javax.annotation:jsr250-api:jar:1.0:compile
>> | | \- javax.inject:javax.inject:jar:1:compile
>> | +- com.google.guava:guava:jar:10.0.1:compile
>> | | \- com.google.code.findbugs:jsr305:jar:1.3.9:compile
>> | +- org.sonatype.sisu:sisu-guice:jar:no_aop:3.1.0:compile
>> | | \- aopalliance:aopalliance:jar:1.0:compile
>> | +- org.eclipse.sisu:org.eclipse.sisu.inject:jar:0.0.0.M5:compile
>> | +- org.codehaus.plexus:plexus-component-annotations:jar:1.5.5:compile
>> | \- org.codehaus.plexus:plexus-classworlds:jar:2.4:compile
>>
>> org.eclipse.sisu caught my attention and there are others that I don't know
>> the status of. At that point I didn't know enough to sort it out at the
>> time.
>
> As far as I can tell, the Sisu dependencies are related to running
> certain kinds of Maven plugins, such as for OSGi. Since we don't
> depend on that capability, I have excluded the dependency and
> everything seems to be working OK. The revised dependency tree is:
>
> $ mvn dependency:tree
> [INFO] Scanning for projects...
> [INFO]
> [INFO] ------------------------------------------------------------------------
> [INFO] Building Jena plugins for Apache Maven,including schemagen 0.4-SNAPSHOT
> [INFO] ------------------------------------------------------------------------
> [INFO]
> [INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ jena-maven-tools ---
> [INFO] org.apache.jena:jena-maven-tools:maven-plugin:0.4-SNAPSHOT
> [INFO] +- org.apache.maven.plugin-tools:maven-plugin-annotations:jar:3.2:provided
> [INFO] | \- org.apache.maven:maven-artifact:jar:3.0:compile
> [INFO] +- org.apache.maven:maven-plugin-api:jar:3.1.1:compile
> [INFO] | \- org.apache.maven:maven-model:jar:3.1.1:compile
> [INFO] +- org.apache.jena:jena-core:jar:2.11.1-SNAPSHOT:compile
> [INFO] | +- org.apache.jena:jena-iri:jar:1.0.1-SNAPSHOT:compile
> [INFO] | \- xerces:xercesImpl:jar:2.11.0:compile
> [INFO] | \- xml-apis:xml-apis:jar:1.4.01:compile
> [INFO] +- org.codehaus.plexus:plexus-utils:jar:3.0.15:compile
> [INFO] +- junit:junit:jar:4.8.1:compile
> [INFO] +- org.apache.maven.shared:maven-verifier:jar:1.2:compile
> [INFO] +- org.slf4j:slf4j-api:jar:1.6.4:compile
> [INFO] +- org.slf4j:slf4j-log4j12:jar:1.6.4:compile
> [INFO] \- log4j:log4j:jar:1.2.16:compile
>
> There's nothing there that I can see that's not (a) already a Jena
> dependency, or (b) an Apache product.
>
>> Acknowledgements are different - common ways include putting in a README,
>> ReleaseNotes or ACKNOWLEDGEMENTS file for the module.
> I'll add a README.
>
> Ian
Re: Build for jena 2.11.1 (jena-maven-tools)
Posted by Ian Dickinson <i....@gmail.com>.
On Wed, Jan 15, 2014 at 3:47 PM, Andy Seaborne <an...@apache.org> wrote:
> On 15/01/14 15:21, Ian Dickinson wrote:
>>
>> Oh, and I've added a copy of the LICENSE file from the main project.
>> I'm not sure what else I need to put in there - do I need to
>> acknowledge the contribution from Shane St Clair that was submitted
>> via Jira?
> Do either of the the top-level LICENCE or NOTICE files need to change to
> reflect dependencies of jena-maven-tools? These need to cover everything in
> trunk and ideally the project.
Not as far as I can tell. The only source code we distribute is
licensed under the Apache license. There are dependencies in the
pom.xml related to the process of running a Maven plugin, but we do
not distribute any of those dependencies (they will be pulled in, as
necessary, when the end user runs that Maven target).
>
> See
> http://www.apache.org/legal/3party.html
>
> esp category B
>
> dependency:tree -->
>
> +- org.apache.maven:maven-plugin-api:jar:3.1.1:compile
> | +- org.apache.maven:maven-model:jar:3.1.1:compile
> | \- org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.0.0.M5:compile
> | +- javax.enterprise:cdi-api:jar:1.0:compile
> | | +- javax.annotation:jsr250-api:jar:1.0:compile
> | | \- javax.inject:javax.inject:jar:1:compile
> | +- com.google.guava:guava:jar:10.0.1:compile
> | | \- com.google.code.findbugs:jsr305:jar:1.3.9:compile
> | +- org.sonatype.sisu:sisu-guice:jar:no_aop:3.1.0:compile
> | | \- aopalliance:aopalliance:jar:1.0:compile
> | +- org.eclipse.sisu:org.eclipse.sisu.inject:jar:0.0.0.M5:compile
> | +- org.codehaus.plexus:plexus-component-annotations:jar:1.5.5:compile
> | \- org.codehaus.plexus:plexus-classworlds:jar:2.4:compile
>
> org.eclipse.sisu caught my attention and there are others that I don't know
> the status of. At that point I didn't know enough to sort it out at the
> time.
As far as I can tell, the Sisu dependencies are related to running
certain kinds of Maven plugins, such as for OSGi. Since we don't
depend on that capability, I have excluded the dependency and
everything seems to be working OK. The revised dependency tree is:
$ mvn dependency:tree
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building Jena plugins for Apache Maven,including schemagen 0.4-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ jena-maven-tools ---
[INFO] org.apache.jena:jena-maven-tools:maven-plugin:0.4-SNAPSHOT
[INFO] +- org.apache.maven.plugin-tools:maven-plugin-annotations:jar:3.2:provided
[INFO] | \- org.apache.maven:maven-artifact:jar:3.0:compile
[INFO] +- org.apache.maven:maven-plugin-api:jar:3.1.1:compile
[INFO] | \- org.apache.maven:maven-model:jar:3.1.1:compile
[INFO] +- org.apache.jena:jena-core:jar:2.11.1-SNAPSHOT:compile
[INFO] | +- org.apache.jena:jena-iri:jar:1.0.1-SNAPSHOT:compile
[INFO] | \- xerces:xercesImpl:jar:2.11.0:compile
[INFO] | \- xml-apis:xml-apis:jar:1.4.01:compile
[INFO] +- org.codehaus.plexus:plexus-utils:jar:3.0.15:compile
[INFO] +- junit:junit:jar:4.8.1:compile
[INFO] +- org.apache.maven.shared:maven-verifier:jar:1.2:compile
[INFO] +- org.slf4j:slf4j-api:jar:1.6.4:compile
[INFO] +- org.slf4j:slf4j-log4j12:jar:1.6.4:compile
[INFO] \- log4j:log4j:jar:1.2.16:compile
There's nothing there that I can see that's not (a) already a Jena
dependency, or (b) an Apache product.
> Acknowledgements are different - common ways include putting in a README,
> ReleaseNotes or ACKNOWLEDGEMENTS file for the module.
I'll add a README.
Ian
Re: Build for jena 2.11.1 (jena-maven-tools)
Posted by Andy Seaborne <an...@apache.org>.
On 15/01/14 15:21, Ian Dickinson wrote:
> Oh, and I've added a copy of the LICENSE file from the main project.
> I'm not sure what else I need to put in there - do I need to
> acknowledge the contribution from Shane St Clair that was submitted
> via Jira?
>
> Ian
>
Do either of the the top-level LICENCE or NOTICE files need to change to
reflect dependencies of jena-maven-tools? These need to cover
everything in trunk and ideally the project.
See
http://www.apache.org/legal/3party.html
esp category B
dependency:tree -->
+- org.apache.maven:maven-plugin-api:jar:3.1.1:compile
| +- org.apache.maven:maven-model:jar:3.1.1:compile
| \- org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.0.0.M5:compile
| +- javax.enterprise:cdi-api:jar:1.0:compile
| | +- javax.annotation:jsr250-api:jar:1.0:compile
| | \- javax.inject:javax.inject:jar:1:compile
| +- com.google.guava:guava:jar:10.0.1:compile
| | \- com.google.code.findbugs:jsr305:jar:1.3.9:compile
| +- org.sonatype.sisu:sisu-guice:jar:no_aop:3.1.0:compile
| | \- aopalliance:aopalliance:jar:1.0:compile
| +- org.eclipse.sisu:org.eclipse.sisu.inject:jar:0.0.0.M5:compile
| +- org.codehaus.plexus:plexus-component-annotations:jar:1.5.5:compile
| \- org.codehaus.plexus:plexus-classworlds:jar:2.4:compile
org.eclipse.sisu caught my attention and there are others that I don't
know the status of. At that point I didn't know enough to sort it out
at the time.
Acknowledgements are different - common ways include putting in a
README, ReleaseNotes or ACKNOWLEDGEMENTS file for the module.
Andy
Re: Build for jena 2.11.1 (jena-maven-tools)
Posted by Ian Dickinson <i....@gmail.com>.
Oh, and I've added a copy of the LICENSE file from the main project.
I'm not sure what else I need to put in there - do I need to
acknowledge the contribution from Shane St Clair that was submitted
via Jira?
Ian
Re: Build for jena 2.11.1 (jena-maven-tools)
Posted by Ian Dickinson <i....@gmail.com>.
Hi Andy,
On Wed, Jan 15, 2014 at 2:52 PM, Andy Seaborne <an...@apache.org> wrote:
> On 10/01/14 11:25, Andy Seaborne wrote:
>>
>> I don't think this is ready for release.
>>
>> Either we need to delay 2.11.1 or make it wait until the next release.
>>
>> Removing from this release seems the better course to me so there is no
>> time issue on cleaning it up.
>>
>>
>> 1/ I fixed up all the source files yesterday assuming it was just an
>> oversight.
>>
>> 2/ LICENSE wrong. I can fix that for the AL part but whether there is
>> more to add because ...
>>
>> 3/ there is no NOTICE
>>
>> I see org.eclipse in the dependency tree so presumably EPL licensed
>> which needs mentioning.
>>
>> Not fixed. I don't know how the dependencies are used.
>>
>> 4/ Package space is org.openjena (minor but easier to fix now?)
>>
>> If cleanup is going to take a while, we ought to move it out of trunk
>> for the moment.
>>
>> Andy
>>
>
> Move to /Experimental/jena-maven-tools - this is very far from ideal but if
> it's in /trunk, it's in the formal source-release artifact, which it can't
> be and I don't have time at the moment to sort the L&N out. Therefore, it
> would hold up the release for a significant period of time unless moved.
>
> Is there any reason to leave the code in org.openjena? Is so, what about
> placeholder classes redriecting to the org.apache.jena ones?
I have:
* moved the code to org.apache.jena
* added the missing license headers
* removed some of the obsolete code (src/site, for example)
* run Rat:
ian@ian-desktop $ mvn apache-rat:check
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building Jena plugins for Apache Maven,including schemagen 0.4-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- apache-rat-plugin:0.10:check (default-cli) @ jena-maven-tools ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: **/target/**/*
[INFO] Exclude: **/*.log
[INFO] 31 resources included (use -debug for more details)
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0
generated: 0 approved: 29 licence.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1.543s
[INFO] Finished at: Wed Jan 15 15:14:56 GMT 2014
[INFO] Final Memory: 11M/216M
[INFO] ------------------------------------------------------------------------
[~/workspace/jena/jena-maven-tools]
I can't commit the code at the moment, due to a conflict in svn. I'll
try to sort that out now.
Ian
Re: Build for jena 2.11.1 (jena-maven-tools)
Posted by Ian Dickinson <i....@gmail.com>.
Andy asked:
> Is there any reason to leave the code in org.openjena? Is so, what about
> placeholder classes redriecting to the org.apache.jena ones?
There's no need to leave it in org.openjena, so I've moved it. I don't
think there's a need for placeholder classes, because the whole point
of schemagen-maven is to run the code from a pom target. So, with the
new version of the plugin (I've bumped to 0.4-snapshot for the time
being), existing pom configurations should work apart from changing
the version dependency.
Ian
Re: Build for jena 2.11.1 (jena-maven-tools)
Posted by Andy Seaborne <an...@apache.org>.
On 10/01/14 11:25, Andy Seaborne wrote:
> I don't think this is ready for release.
>
> Either we need to delay 2.11.1 or make it wait until the next release.
>
> Removing from this release seems the better course to me so there is no
> time issue on cleaning it up.
>
>
> 1/ I fixed up all the source files yesterday assuming it was just an
> oversight.
>
> 2/ LICENSE wrong. I can fix that for the AL part but whether there is
> more to add because ...
>
> 3/ there is no NOTICE
>
> I see org.eclipse in the dependency tree so presumably EPL licensed
> which needs mentioning.
>
> Not fixed. I don't know how the dependencies are used.
>
> 4/ Package space is org.openjena (minor but easier to fix now?)
>
> If cleanup is going to take a while, we ought to move it out of trunk
> for the moment.
>
> Andy
>
Move to /Experimental/jena-maven-tools - this is very far from ideal but
if it's in /trunk, it's in the formal source-release artifact, which it
can't be and I don't have time at the moment to sort the L&N out.
Therefore, it would hold up the release for a significant period of time
unless moved.
Is there any reason to leave the code in org.openjena? Is so, what about
placeholder classes redriecting to the org.apache.jena ones?
Andy