You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/08 15:32:39 UTC

[GitHub] [dubbo-go-pixiu] MasterKenway opened a new pull request #249: Feat： cors policy implement

MasterKenway opened a new pull request #249:
URL: https://github.com/apache/dubbo-go-pixiu/pull/249


   - Implement cors policy defined in the HttpConnectionManage
   
   - Style improvement


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #249: Feat: cors policy implement

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #249:
URL: https://github.com/apache/dubbo-go-pixiu/pull/249#issuecomment-915362443


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#249](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c1cfdd8) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/32c6ba5a48e7f4e261c51e3b217849159d1713f8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32c6ba5) will **decrease** coverage by `0.26%`.
   > The diff coverage is `28.57%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #249      +/-   ##
   ===========================================
   - Coverage    40.93%   40.67%   -0.27%     
   ===========================================
     Files           51       51              
     Lines         2587     2606      +19     
   ===========================================
   + Hits          1059     1060       +1     
   - Misses        1415     1432      +17     
   - Partials       113      114       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `6.81% <ø> (ø)` | |
   | [pkg/filter/response/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yZXNwb25zZS9yZXNwb25zZS5nbw==) | `34.17% <0.00%> (ø)` | |
   | [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/server/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/common/extension/filter/filter\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vZmlsdGVyL2ZpbHRlcl9tYW5hZ2VyLmdv) | `39.62% <10.00%> (-19.21%)` | :arrow_down: |
   | [pkg/filter/accesslog/access\_log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvYWNjZXNzX2xvZy5nbw==) | `6.15% <16.66%> (ø)` | |
   | [pkg/filter/host/host.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9ob3N0L2hvc3QuZ28=) | `43.75% <28.57%> (ø)` | |
   | [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `64.70% <37.50%> (ø)` | |
   | [pkg/filter/recovery/recovery.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yZWNvdmVyeS9yZWNvdmVyeS5nbw==) | `56.52% <42.85%> (ø)` | |
   | [pkg/filter/header/header.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9oZWFkZXIvaGVhZGVyLmdv) | `66.66% <50.00%> (ø)` | |
   | ... and [3 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [32c6ba5...c1cfdd8](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] mark4z commented on pull request #249: Feat: cors policy implement

Posted by GitBox <gi...@apache.org>.
mark4z commented on pull request #249:
URL: https://github.com/apache/dubbo-go-pixiu/pull/249#issuecomment-922275081


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #249: Feat: cors policy implement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #249:
URL: https://github.com/apache/dubbo-go-pixiu/pull/249#issuecomment-915362443


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#249](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (04318dc) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/32c6ba5a48e7f4e261c51e3b217849159d1713f8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32c6ba5) will **decrease** coverage by `0.18%`.
   > The diff coverage is `30.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #249      +/-   ##
   ===========================================
   - Coverage    40.93%   40.75%   -0.19%     
   ===========================================
     Files           51       51              
     Lines         2587     2601      +14     
   ===========================================
   + Hits          1059     1060       +1     
   - Misses        1415     1428      +13     
     Partials       113      113              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `6.81% <ø> (ø)` | |
   | [pkg/filter/response/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yZXNwb25zZS9yZXNwb25zZS5nbw==) | `34.17% <0.00%> (ø)` | |
   | [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/server/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/common/extension/filter/filter\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vZmlsdGVyL2ZpbHRlcl9tYW5hZ2VyLmdv) | `43.75% <12.50%> (-15.08%)` | :arrow_down: |
   | [pkg/filter/accesslog/access\_log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvYWNjZXNzX2xvZy5nbw==) | `6.15% <16.66%> (ø)` | |
   | [pkg/filter/host/host.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9ob3N0L2hvc3QuZ28=) | `43.75% <28.57%> (ø)` | |
   | [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `64.70% <37.50%> (ø)` | |
   | [pkg/filter/recovery/recovery.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yZWNvdmVyeS9yZWNvdmVyeS5nbw==) | `56.52% <42.85%> (ø)` | |
   | [pkg/filter/header/header.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9oZWFkZXIvaGVhZGVyLmdv) | `66.66% <50.00%> (ø)` | |
   | ... and [3 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [32c6ba5...04318dc](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #249: Feat: cors policy implement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #249:
URL: https://github.com/apache/dubbo-go-pixiu/pull/249#issuecomment-915362443


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#249](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bafddfb) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/efae1befc92bc767e466b640b012749d00871e82?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (efae1be) will **not change** coverage.
   > The diff coverage is `33.84%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff            @@
   ##           develop     #249   +/-   ##
   ========================================
     Coverage    40.93%   40.93%           
   ========================================
     Files           51       51           
     Lines         2587     2587           
   ========================================
     Hits          1059     1059           
     Misses        1415     1415           
     Partials       113      113           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/common/extension/filter/filter\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vZmlsdGVyL2ZpbHRlcl9tYW5hZ2VyLmdv) | `58.82% <0.00%> (ø)` | |
   | [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `6.81% <ø> (ø)` | |
   | [pkg/filter/response/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yZXNwb25zZS9yZXNwb25zZS5nbw==) | `34.17% <0.00%> (ø)` | |
   | [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/server/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/filter/accesslog/access\_log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvYWNjZXNzX2xvZy5nbw==) | `6.15% <16.66%> (ø)` | |
   | [pkg/filter/host/host.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9ob3N0L2hvc3QuZ28=) | `43.75% <28.57%> (ø)` | |
   | [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `64.70% <37.50%> (ø)` | |
   | [pkg/filter/recovery/recovery.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yZWNvdmVyeS9yZWNvdmVyeS5nbw==) | `56.52% <42.85%> (ø)` | |
   | [pkg/filter/header/header.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9oZWFkZXIvaGVhZGVyLmdv) | `66.66% <50.00%> (ø)` | |
   | ... and [3 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [efae1be...bafddfb](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] mark4z merged pull request #249: Feat: cors policy implement

Posted by GitBox <gi...@apache.org>.
mark4z merged pull request #249:
URL: https://github.com/apache/dubbo-go-pixiu/pull/249


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] ztelur commented on a change in pull request #249: Feat: cors policy implement

Posted by GitBox <gi...@apache.org>.
ztelur commented on a change in pull request #249:
URL: https://github.com/apache/dubbo-go-pixiu/pull/249#discussion_r704880450



##########
File path: pkg/common/extension/filter/filter_manager.go
##########
@@ -18,6 +18,7 @@
 package filter
 
 import (
+	"github.com/apache/dubbo-go-pixiu/pkg/common/constant"

Review comment:
       import顺序处理一下




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #249: Feat: cors policy implement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #249:
URL: https://github.com/apache/dubbo-go-pixiu/pull/249#issuecomment-915362443


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#249](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (370295a) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/32c6ba5a48e7f4e261c51e3b217849159d1713f8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32c6ba5) will **decrease** coverage by `0.26%`.
   > The diff coverage is `28.57%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #249      +/-   ##
   ===========================================
   - Coverage    40.93%   40.67%   -0.27%     
   ===========================================
     Files           51       51              
     Lines         2587     2606      +19     
   ===========================================
   + Hits          1059     1060       +1     
   - Misses        1415     1432      +17     
   - Partials       113      114       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `6.81% <ø> (ø)` | |
   | [pkg/filter/response/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yZXNwb25zZS9yZXNwb25zZS5nbw==) | `34.17% <0.00%> (ø)` | |
   | [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/server/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/common/extension/filter/filter\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vZmlsdGVyL2ZpbHRlcl9tYW5hZ2VyLmdv) | `39.62% <10.00%> (-19.21%)` | :arrow_down: |
   | [pkg/filter/accesslog/access\_log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvYWNjZXNzX2xvZy5nbw==) | `6.15% <16.66%> (ø)` | |
   | [pkg/filter/host/host.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9ob3N0L2hvc3QuZ28=) | `43.75% <28.57%> (ø)` | |
   | [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `64.70% <37.50%> (ø)` | |
   | [pkg/filter/recovery/recovery.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yZWNvdmVyeS9yZWNvdmVyeS5nbw==) | `56.52% <42.85%> (ø)` | |
   | [pkg/filter/header/header.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9oZWFkZXIvaGVhZGVyLmdv) | `66.66% <50.00%> (ø)` | |
   | ... and [3 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [32c6ba5...370295a](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #249: Feat: cors policy implement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #249:
URL: https://github.com/apache/dubbo-go-pixiu/pull/249#issuecomment-915362443


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#249](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (01fdbfc) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/32c6ba5a48e7f4e261c51e3b217849159d1713f8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32c6ba5) will **decrease** coverage by `0.26%`.
   > The diff coverage is `28.57%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #249      +/-   ##
   ===========================================
   - Coverage    40.93%   40.67%   -0.27%     
   ===========================================
     Files           51       51              
     Lines         2587     2606      +19     
   ===========================================
   + Hits          1059     1060       +1     
   - Misses        1415     1432      +17     
   - Partials       113      114       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `6.81% <ø> (ø)` | |
   | [pkg/filter/response/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yZXNwb25zZS9yZXNwb25zZS5nbw==) | `34.17% <0.00%> (ø)` | |
   | [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/server/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/common/extension/filter/filter\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vZmlsdGVyL2ZpbHRlcl9tYW5hZ2VyLmdv) | `39.62% <10.00%> (-19.21%)` | :arrow_down: |
   | [pkg/filter/accesslog/access\_log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvYWNjZXNzX2xvZy5nbw==) | `6.15% <16.66%> (ø)` | |
   | [pkg/filter/host/host.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9ob3N0L2hvc3QuZ28=) | `43.75% <28.57%> (ø)` | |
   | [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `64.70% <37.50%> (ø)` | |
   | [pkg/filter/recovery/recovery.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yZWNvdmVyeS9yZWNvdmVyeS5nbw==) | `56.52% <42.85%> (ø)` | |
   | [pkg/filter/header/header.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9oZWFkZXIvaGVhZGVyLmdv) | `66.66% <50.00%> (ø)` | |
   | ... and [3 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [32c6ba5...01fdbfc](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #249: Feat: cors policy implement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #249:
URL: https://github.com/apache/dubbo-go-pixiu/pull/249#issuecomment-915362443


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#249](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (13cbc0d) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/32c6ba5a48e7f4e261c51e3b217849159d1713f8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32c6ba5) will **not change** coverage.
   > The diff coverage is `33.84%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff            @@
   ##           develop     #249   +/-   ##
   ========================================
     Coverage    40.93%   40.93%           
   ========================================
     Files           51       51           
     Lines         2587     2587           
   ========================================
     Hits          1059     1059           
     Misses        1415     1415           
     Partials       113      113           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/common/extension/filter/filter\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vZmlsdGVyL2ZpbHRlcl9tYW5hZ2VyLmdv) | `58.82% <0.00%> (ø)` | |
   | [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `6.81% <ø> (ø)` | |
   | [pkg/filter/response/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yZXNwb25zZS9yZXNwb25zZS5nbw==) | `34.17% <0.00%> (ø)` | |
   | [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/server/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/filter/accesslog/access\_log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvYWNjZXNzX2xvZy5nbw==) | `6.15% <16.66%> (ø)` | |
   | [pkg/filter/host/host.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9ob3N0L2hvc3QuZ28=) | `43.75% <28.57%> (ø)` | |
   | [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `64.70% <37.50%> (ø)` | |
   | [pkg/filter/recovery/recovery.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yZWNvdmVyeS9yZWNvdmVyeS5nbw==) | `56.52% <42.85%> (ø)` | |
   | [pkg/filter/header/header.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9oZWFkZXIvaGVhZGVyLmdv) | `66.66% <50.00%> (ø)` | |
   | ... and [3 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [32c6ba5...13cbc0d](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #249: Feat: cors policy implement

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #249:
URL: https://github.com/apache/dubbo-go-pixiu/pull/249#issuecomment-915362443


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#249](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bafddfb) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/efae1befc92bc767e466b640b012749d00871e82?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (efae1be) will **not change** coverage.
   > The diff coverage is `33.84%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff            @@
   ##           develop     #249   +/-   ##
   ========================================
     Coverage    40.93%   40.93%           
   ========================================
     Files           51       51           
     Lines         2587     2587           
   ========================================
     Hits          1059     1059           
     Misses        1415     1415           
     Partials       113      113           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/common/extension/filter/filter\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vZmlsdGVyL2ZpbHRlcl9tYW5hZ2VyLmdv) | `58.82% <0.00%> (ø)` | |
   | [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `6.81% <ø> (ø)` | |
   | [pkg/filter/response/response.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yZXNwb25zZS9yZXNwb25zZS5nbw==) | `34.17% <0.00%> (ø)` | |
   | [pkg/server/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9odHRwLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/server/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/filter/accesslog/access\_log.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hY2Nlc3Nsb2cvYWNjZXNzX2xvZy5nbw==) | `6.15% <16.66%> (ø)` | |
   | [pkg/filter/host/host.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9ob3N0L2hvc3QuZ28=) | `43.75% <28.57%> (ø)` | |
   | [pkg/filter/metric/metric.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9tZXRyaWMvbWV0cmljLmdv) | `64.70% <37.50%> (ø)` | |
   | [pkg/filter/recovery/recovery.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9yZWNvdmVyeS9yZWNvdmVyeS5nbw==) | `56.52% <42.85%> (ø)` | |
   | [pkg/filter/header/header.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9oZWFkZXIvaGVhZGVyLmdv) | `66.66% <50.00%> (ø)` | |
   | ... and [3 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [efae1be...bafddfb](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/249?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org