[GitHub] [airflow] natanweinberger commented on pull request #15425: Fix CLI connections import and migrate logic from secrets to Connection model

[GitBox <gi...@apache.org>]

natanweinberger commented on pull request #15425:
URL: https://github.com/apache/airflow/pull/15425#issuecomment-834672218


   Hey @ashb, thanks for taking a look! I appreciate it.
   
   I want to point out that most changes here are based on the feedback from @mik-laj above in this PR. I can change or undo some of these things, but it'll be undoing some of the work that was based on that feedback, so I just want to make sure we're all on the same page.
   
   Moving the secrets parsing logic to a utils file: https://github.com/apache/airflow/pull/15425#discussion_r625638195
   I haven't changed much (if any) code in the parsing, just moved it to a new file (`utils/parse.py`) so that it's not coupled to the secrets backend. Effectively, copied and pasted. I can commit those suggested changes that improve efficiency or wording of it here though.
   
   Add a method `Connection.from_dict()`: https://github.com/apache/airflow/pull/15425#discussion_r615929569
   
   What do you think? Do you want me to revert anything?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org