You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/23 09:48:16 UTC

[GitHub] [airflow] ashb commented on a change in pull request #14368: Use latest Pip version when building image.

ashb commented on a change in pull request #14368:
URL: https://github.com/apache/airflow/pull/14368#discussion_r580895024



##########
File path: Dockerfile
##########
@@ -190,7 +190,7 @@ ENV AIRFLOW_INSTALL_USER_FLAG="--user"
 ENV AIRFLOW_INSTALL_EDITABLE_FLAG=""
 
 # Upgrade to specific PIP version
-RUN pip install --upgrade "pip==${AIRFLOW_PIP_VERSION}"
+RUN pip install --upgrade "pip~=${AIRFLOW_PIP_VERSION}"

Review comment:
       https://www.python.org/dev/peps/pep-0440/#compatible-release
   
   `pip~=21.0.1` is equivalent to `piip>=21.0.1, ==21.0.*`
   
   Which from the PR description is not what I think you intended.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org