You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@helix.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/09 20:23:00 UTC
[jira] [Commented] (HELIX-680) Zookeeper 3.4.11 upgrade breaks
TestZkCallbackHandlerLeak
[ https://issues.apache.org/jira/browse/HELIX-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393487#comment-16393487 ]
ASF GitHub Bot commented on HELIX-680:
--------------------------------------
GitHub user zhan849 opened a pull request:
https://github.com/apache/helix/pull/146
[HELIX-680] add system setting to unblock TestZkCallbackHandlerLeak test with zookeeper 3.4.11 upgrade
By adding system property in ZkUnitTestBase `beforeSuite()`, `TestZkCallbackHandlerLeak` can pass now
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhan849/helix harry/zk-test-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/helix/pull/146.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #146
----
commit e4de3c2247042754ed193789b8a8671012576e7d
Author: hrzhang <hr...@...>
Date: 2018-03-09T20:20:16Z
[HELIX-680] add system setting to unblock TestZkCallbackHandlerLeak test with zookeeper 3.4.11 upgrade
----
> Zookeeper 3.4.11 upgrade breaks TestZkCallbackHandlerLeak
> ---------------------------------------------------------
>
> Key: HELIX-680
> URL: https://issues.apache.org/jira/browse/HELIX-680
> Project: Apache Helix
> Issue Type: Bug
> Reporter: Hao Zhang
> Priority: Major
>
> Zookeeper 3.4.11 upgrade breaks TestZkCallbackHandlerLeak as I'm seeing the following problems:
> {noformat}
> Results :
> Failed tests:
> TestZkCallbackHandlerLeak.testCbHandlerLeakOnControllerSessionExpiry:266 » NullPointer
> TestZkCallbackHandlerLeak.testCbHandlerLeakOnParticipantSessionExpiry:82 » NullPointer
> TestZkCallbackHandlerLeak.testCbHdlrLeakOnControllerSessionExpiry:262 » NullPointer
> TestZkCallbackHandlerLeak.testCbHdlrLeakOnParticipantSessionExpiry:85 » NullPointer
> Tests run: 6, Failures: 4, Errors: 0, Skipped: 0
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 16.744 s
> [INFO] Finished at: 2018-03-08T17:13:00-08:00
> [INFO] Final Memory: 22M/961M
> [INFO] ------------------------------------------------------------------------
> {noformat}
>
> Because of [https://github.com/apache/zookeeper/pull/179,] `ZkTestHelper.getListenersByZkPath()` will always return null, and break test. We need to set whitelist before we run test.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)