You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by prafullat <gi...@git.apache.org> on 2014/05/26 20:05:14 UTC
[GitHub] tajo pull request: TAJO-699: Create a table using LIKE
GitHub user prafullat opened a pull request:
https://github.com/apache/tajo/pull/21
TAJO-699: Create a table using LIKE
This commit implements following DDL in Tajo.
create table <table_name> like <existing_table_name>;
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prafullat/tajo tajo-699
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/21.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21
----
commit a3f0bf85641a58b0b344d0aaca1c037c608d1295
Author: Prafulla Tekawade <pr...@users.sourceforge.net>
Date: 2014-05-26T17:24:45Z
TAJO-699: Create a table using LIKE
This commit implements following DDL in Tajo.
create table <table_name> like <existing_table_name>;
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-699: Create a table using LIKE
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/21#issuecomment-44229679
Hi Prafulla,
I reviewed your patch in more detail. Excellent! You work is very nice. It works well. I leave only some trivial comments.
Although we do not use maven checkstyle plugin to strictly check coding convention, we already use some coding style. Please take a look at this [1]. We use 2 space instead of tab. Other conventions you use look nice to me.
In addition, it would be better if you use ```assertTrue(message : string, condition:boolean)``` and ```assertEquals(message : string, obj1:Object, obj2:Object)``` instead of using ```System.out.println``` in ```isClonedSchema```. It usually generates more comprehensive output messages in the tail of maven message when the test is failed.
* [1] https://cwiki.apache.org/confluence/display/TAJO/Code+Style
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-699: Create a table using LIKE
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/21
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-699: Create a table using LIKE
Posted by prafullat <gi...@git.apache.org>.
Github user prafullat commented on the pull request:
https://github.com/apache/tajo/pull/21#issuecomment-44233163
Thanks for comments.
I have implemented review comments in latest commit in this pull request.
Should I also update it on Jira?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-699: Create a table using LIKE
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/21#issuecomment-44233976
I think that updating github pull request is enough for us. I'll review your latest change. Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-699: Create a table using LIKE
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/21#issuecomment-44316512
+1
The latest patch looks good to me. I'll commit it shortly. Thank you for your contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-699: Create a table using LIKE
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/21#issuecomment-44213036
Thank you for contribution.
I've just briefly reviewed your patch. The patch looks nice and includes sufficient unit tests. Actually, now I'd like to check more cases using your 'CREATE TABLE LIKE', but here is already 4:30 AM. So, I'll review your patch tomorrow, and I'll comment soon!
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---