You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by sb...@apache.org on 2018/11/20 20:54:13 UTC

ignite git commit: ignite-10044

Repository: ignite
Updated Branches:
  refs/heads/ignite-10044 1a60eafc9 -> 0f71f1358


ignite-10044


Project: http://git-wip-us.apache.org/repos/asf/ignite/repo
Commit: http://git-wip-us.apache.org/repos/asf/ignite/commit/0f71f135
Tree: http://git-wip-us.apache.org/repos/asf/ignite/tree/0f71f135
Diff: http://git-wip-us.apache.org/repos/asf/ignite/diff/0f71f135

Branch: refs/heads/ignite-10044
Commit: 0f71f1358a2eb3cbcd6a458a1f6dc95a346efeb9
Parents: 1a60eaf
Author: sboikov <sb...@apache.org>
Authored: Tue Nov 20 23:49:55 2018 +0300
Committer: sboikov <sb...@apache.org>
Committed: Tue Nov 20 23:53:56 2018 +0300

----------------------------------------------------------------------
 .../IgniteCachePartitionLossPolicySelfTest.java           | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ignite/blob/0f71f135/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteCachePartitionLossPolicySelfTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteCachePartitionLossPolicySelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteCachePartitionLossPolicySelfTest.java
index 26ef0b7..6f4b260 100644
--- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteCachePartitionLossPolicySelfTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/IgniteCachePartitionLossPolicySelfTest.java
@@ -417,7 +417,7 @@ public class IgniteCachePartitionLossPolicySelfTest extends GridCommonAbstractTe
 
         // TODO aliveNodes should include node 4, but it fails due to https://issues.apache.org/jira/browse/IGNITE-5078.
         // TODO need to add 4 to the aliveNodes after IGNITE-5078 is fixed.
-        // TopologyChanger onlyCrdIsAlive = new TopologyChanger(false, Arrays.asList(1, 2, 3), Arrays.asList(0, 4), 0);
+        // TopologyChanger onlyCrdIsAlive = new TopologyChanger(4, false, Arrays.asList(1, 2, 3), Arrays.asList(0, 4), 0);
         TopologyChanger onlyCrdIsAlive = new TopologyChanger(4, false, asList(1, 2, 3), singletonList(0), 0);
 
         checkIgnore(onlyCrdIsAlive);
@@ -665,7 +665,7 @@ public class IgniteCachePartitionLossPolicySelfTest extends GridCommonAbstractTe
             IgniteEx cl = startGrid("newNode");
 
             for (String cacheName : CACHE_NAMES) {
-                cl.cache(cacheName); // Make sure cache started on node.`
+                cl.cache(cacheName); // Make sure cache is started on node.`
 
                 CacheGroupContext grpCtx = cl.context().cache().cacheGroup(CU.cacheId(cacheName));
 
@@ -784,6 +784,7 @@ public class IgniteCachePartitionLossPolicySelfTest extends GridCommonAbstractTe
      *
      * @param safe Safe flag.
      * @param node Node.
+     * @param cacheName Cache name.
      */
     private void validateQuery(boolean safe, Ignite node, String cacheName) {
         // Get node lost and remaining partitions.
@@ -848,6 +849,9 @@ public class IgniteCachePartitionLossPolicySelfTest extends GridCommonAbstractTe
     }
 
     /**
+     * @param node Node.
+     * @param cacheName Cache name.
+     * @param parts Partitions.
      * @return true if the given node is primary for all given partitions.
      */
     private boolean shouldExecuteLocalQuery(Ignite node, String cacheName, int... parts) {
@@ -869,6 +873,7 @@ public class IgniteCachePartitionLossPolicySelfTest extends GridCommonAbstractTe
     /**
      * @param node Node.
      * @param loc Local flag.
+     * @param cacheName Cache name.
      * @param parts Partitions.
      */
     protected void checkQueryPasses(Ignite node, boolean loc, String cacheName, int... parts) {
@@ -896,6 +901,7 @@ public class IgniteCachePartitionLossPolicySelfTest extends GridCommonAbstractTe
     /**
      * @param node Node.
      * @param loc Local flag.
+     * @param cacheName Cache name.
      * @param parts Partitions.
      */
     protected void checkQueryFails(Ignite node, boolean loc, String cacheName, int... parts) {