You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/04/09 13:28:25 UTC
[GitHub] [ozone] elek opened a new pull request #2140: Include HISTORY.md/SECURITY.md/CONTRIBUTING.md in the release artifacts.
elek opened a new pull request #2140:
URL: https://github.com/apache/ozone/pull/2140
## What changes were proposed in this pull request?
During the ozone-1.1.0 vote I realized that `HISTORY.md`/`SECURITY.md`/`CONTRIBUTING.md` files are missing from the `bin` and `src` artifacts. I think they include very useful information and would be better to include them in the release artifacts.
## How was this patch tested?
```
mvn clean install -Dmaven.javadoc.skip=true -DskipTests -Psign,dist,src -Dtar -Dgpg.keyname=$CODESIGNINGKEY
cd hadoop-ozone/dist/target/
tar tzf hadoop-ozone-1.1.0-SNAPSHOT.tar.gz
tar tzf hadoop-ozone-1.1.0-src-SNAPSHOT.tar.gz
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2140: HDDS-5084. Include HISTORY.md/SECURITY.md/CONTRIBUTING.md in the release artifacts.
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2140:
URL: https://github.com/apache/ozone/pull/2140#issuecomment-816780377
> We should update the History.md, it is quite old right now.
@mukul1987 This is a good suggestion, but I disagree with the other statement:
> Including it in the current form in the release doesn't makes sense.
1. It is not going to be part of the 1.1.0 release, so there is plenty of time to update it until the next one.
2. It's not only about HISTORY.md, but other two docs as well.
3. Writing prose for the history doc is quite distinct from updating a script to copy some files. It may very well be updated by other people, not necessarily @elek.
So I think this change is fine in its scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] elek commented on pull request #2140: HDDS-5084. Include HISTORY.md/SECURITY.md/CONTRIBUTING.md in the release artifacts.
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #2140:
URL: https://github.com/apache/ozone/pull/2140#issuecomment-817600322
Thanks the suggestion @mukul1987, very good point.
It seems to be a small update, so I created the patch itself (please see #2149). And agree: as we have PRs for both problems in our radar we can merge the two PRs in any order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] elek merged pull request #2140: HDDS-5084. Include HISTORY.md/SECURITY.md/CONTRIBUTING.md in the release artifacts.
Posted by GitBox <gi...@apache.org>.
elek merged pull request #2140:
URL: https://github.com/apache/ozone/pull/2140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] mukul1987 edited a comment on pull request #2140: HDDS-5084. Include HISTORY.md/SECURITY.md/CONTRIBUTING.md in the release artifacts.
Posted by GitBox <gi...@apache.org>.
mukul1987 edited a comment on pull request #2140:
URL: https://github.com/apache/ozone/pull/2140#issuecomment-816782925
Fair point @adoroszlai. Can we please create a followup jira for updating the History.md and other files and mark it as a blocker for 1.2.0 release? I feel if we will update the history by the next release, then we should be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] mukul1987 commented on pull request #2140: HDDS-5084. Include HISTORY.md/SECURITY.md/CONTRIBUTING.md in the release artifacts.
Posted by GitBox <gi...@apache.org>.
mukul1987 commented on pull request #2140:
URL: https://github.com/apache/ozone/pull/2140#issuecomment-817601489
Thanks Marton. +1 for this patch as well.
I have already added +1 to the other patch.
Thanks for updating the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] mukul1987 commented on pull request #2140: HDDS-5084. Include HISTORY.md/SECURITY.md/CONTRIBUTING.md in the release artifacts.
Posted by GitBox <gi...@apache.org>.
mukul1987 commented on pull request #2140:
URL: https://github.com/apache/ozone/pull/2140#issuecomment-816782925
Fair point @adoroszlai. Can we please create a followup jira and mark it as a blocker for 1.2.0 release? I feel if we will update the history by the next release, then we should be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] elek commented on pull request #2140: HDDS-5084. Include HISTORY.md/SECURITY.md/CONTRIBUTING.md in the release artifacts.
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #2140:
URL: https://github.com/apache/ozone/pull/2140#issuecomment-822308367
Thanks the review @mukul1987 @ayushtkn and @adoroszlai
I am merging it after the green build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org