You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "zjacom (via GitHub)" <gi...@apache.org> on 2025/11/04 14:29:20 UTC
[PR] docs: remove outdated Bazel circular dependency warning from installation guide [airflow]
zjacom opened a new pull request, #57807:
URL: https://github.com/apache/airflow/pull/57807
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
**[DOCS] Remove outdated Bazel circular dependency warning**
This PR removes an outdated note in the "Installing from PyPI" section that warned users about possible circular dependency issues when installing Airflow with Bazel.
The referenced issue in the Bazel ecosystem has already been resolved and merged in
**bazelbuild/rules_python#1166**.
Because the problem no longer exists, the warning is misleading and unnecessarily discourages users from using Bazel-based tooling.
This update ensures the documentation remains accurate, up-to-date, and aligned with the current state of Bazel’s Python rules.
### What was changed
- Deleted the paragraph that stated Bazel may lead to circular dependencies during Airflow installation.
- Verified that the surrounding text flows naturally after the removal.
- No functional changes; documentation only.
### Why this change is needed
- The Bazel circular dependency issue has been resolved upstream.
- Retaining the warning provides inaccurate guidance to users.
- Helps maintain documentation correctness and reduce confusion.
### Related references
- Upstream fix: bazelbuild/rules_python#1166
- No Airflow issue associated (documentation cleanup).
<!-- Please keep an empty line above the dashes. -->
---
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: remove outdated Bazel circular dependency warning from installation guide [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #57807:
URL: https://github.com/apache/airflow/pull/57807#issuecomment-3486286547
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: remove outdated Bazel circular dependency warning from installation guide [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #57807:
URL: https://github.com/apache/airflow/pull/57807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: remove outdated Bazel circular dependency warning from installation guide [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #57807:
URL: https://github.com/apache/airflow/pull/57807#issuecomment-3487450698
Nice. Thanks for cleaning it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: remove outdated Bazel circular dependency warning from installation guide [airflow]
Posted by "arrdem (via GitHub)" <gi...@apache.org>.
arrdem commented on PR #57807:
URL: https://github.com/apache/airflow/pull/57807#issuecomment-3500038737
Just a note as the person who wrote that cycles support PR -- `rules_python` lists the Airflow cycle workaround as part of their docs but manual intervention is still required of `rules_python` (majority Bazel) users.
I have some new experimental work which can automatically resolve cycles, but that's very much not ecosystem status quo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: remove outdated Bazel circular dependency warning from installation guide [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #57807:
URL: https://github.com/apache/airflow/pull/57807#issuecomment-3500104835
> Just a note as the person who wrote that cycles support PR -- rules_python lists the Airflow cycle workaround as part of their docs but manual intervention is still required of rules_python (majority Bazel) users.
Bazel is kinda niche for us - and it's not even supported - because airflow strongly recommends to use constraints when installing https://airflow.apache.org/docs/apache-airflow/stable/installation/installing-from-pypi.html - at least until this discussion concludes https://discuss.python.org/t/pre-pep-add-ability-to-install-a-package-with-reproducible-dependencies/99497/19 and we will be able to use https://peps.python.org/pep-0751/ package lock for that purpose.
It means that officially `pip` (also `uv` supports it ) is the right way of installing Airlfow, we mention that in the docs that we "hear" some people use other managers but this might lead to problems. I generally prefer that users learn from bazel documentation how to solve cycle problems when they see them happening, so having those docs in bazel not airflow seems like a good idea.
> I have some new experimental work which can automatically resolve cycles, but that's very much not ecosystem status quo.
I wonder if you are talking about Bazel ecosystem, or PyPA (Python packaging one) ?
I belive PyPA ecosystem status is that yes - cycles are supported and nothing unusual - there are a number reasons why you would llike to have cycles - especially when there is a mutual dependency on versions of dependent packages (a requires b > 1.0, b requires a > 3.4) etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: remove outdated Bazel circular dependency warning from installation guide [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #57807:
URL: https://github.com/apache/airflow/pull/57807#issuecomment-3487497461
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org