[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13594: KAFKA-14913: Using ThreadUtils.shutdownExecutorServiceQuietly to close executors in Connect Runtime

["vamossagar12 (via GitHub)" <gi...@apache.org>]

vamossagar12 commented on code in PR #13594:
URL: https://github.com/apache/kafka/pull/13594#discussion_r1170934924


##########
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaStatusBackingStoreFormatTest.java:
##########
@@ -216,7 +219,12 @@ public void putTopicStateRetriableFailure() {
         }).when(kafkaBasedLog).send(eq(key), valueCaptor.capture(), any(Callback.class));
 
         store.put(topicStatus);
-        verify(kafkaBasedLog, times(2)).send(any(), any(), any());
+        try {
+            verify(kafkaBasedLog, times(2)).send(any(), any(), any());

Review Comment:
   @urbandan , that's what I am suspecting. Ok I wanted to verify if this was the case with this hackish fix ( and also was not aware of timeout option). Let me set a timeout of 300ms and see if that helps.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org