You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/10/27 10:39:45 UTC

[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #12207: [Bug] [API]After we delete the worker group, but this task group still keep in the task setting.

caishunfeng commented on code in PR #12207:
URL: https://github.com/apache/dolphinscheduler/pull/12207#discussion_r1006703499


##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessTaskRelationMapper.xml:
##########
@@ -200,7 +200,11 @@
             and post_task_code = #{postTaskCode}
         </if>
     </select>
-
+    <select id="queryByWorkGroupName" resultType="org.apache.dolphinscheduler.dao.entity.ProcessTaskRelation">
+        select
+            relation.id
+        from t_ds_process_task_relation relation, t_ds_task_definition_log log where
+        log.code = relation.post_task_code and log.worker_group = #{workerGroupName}

Review Comment:
   It looks miss `</select>`, Why not query `t_ds_task_definition_log` directly?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org