You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "chibenwa (via GitHub)" <gi...@apache.org> on 2024/01/17 19:54:54 UTC

[PR] [FIX] Enable dynamic translation of LDAP entries [james-project]

chibenwa opened a new pull request, #1932:
URL: https://github.com/apache/james-project/pull/1932

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] [FIX] Enable dynamic translation of LDAP entries [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa merged PR #1932:
URL: https://github.com/apache/james-project/pull/1932


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] [FIX] Enable dynamic translation of LDAP entries [james-project]

Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on code in PR #1932:
URL: https://github.com/apache/james-project/pull/1932#discussion_r1461319821


##########
server/data/data-ldap/src/main/java/org/apache/james/user/ldap/LdapRepositoryConfiguration.java:
##########
@@ -282,10 +287,16 @@ public static LdapRepositoryConfiguration from(HierarchicalConfiguration<Immutab
     /**
      * The value of this field is taken from the configuration attribute
      * &quot;userIdAttribute&quot;. This is the LDAP attribute type which holds
-     * the userId value. Note that this is not the same as the email address
-     * attribute.
+     * the userId value. This value is used to identify the LDAP entry used for authentication,
+     * and by default is used to retrie the associated username.

Review Comment:
   ```suggestion
        * and by default is used to retrieve the associated username.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org