You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "taowenjun (via GitHub)" <gi...@apache.org> on 2025/08/03 14:45:27 UTC
Re: [PR] [CELEBORN-2058] Add retry to avoid commtting failed with HDFS storage [celeborn]
taowenjun commented on code in PR #3360:
URL: https://github.com/apache/celeborn/pull/3360#discussion_r2250006161
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/TierWriter.scala:
##########
@@ -643,13 +643,43 @@ class DfsTierWriter(
hadoopFs.delete(hdfsFileInfo.getDfsPath, false)
deleted = true
} else {
- hadoopFs.create(hdfsFileInfo.getDfsWriterSuccessPath).close()
- val indexOutputStream = hadoopFs.create(hdfsFileInfo.getDfsIndexPath)
- indexOutputStream.writeInt(hdfsFileInfo.getReduceFileMeta.getChunkOffsets.size)
- for (offset <- hdfsFileInfo.getReduceFileMeta.getChunkOffsets.asScala) {
- indexOutputStream.writeLong(offset)
+ def retry(operationName: String)(action: => Unit): Unit = {
Review Comment:
> Could we reuse `Utils#withRetryOnTimeoutOrIOException`?
With this method, we can not increase sleep time according to the retry count which noted above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org