[GitHub] [spark] wangshuo128 opened a new pull request #26924: [SPARK-30285][CORE]Fix race condition between LiveListenerBus#stop and AsyncEventQueue#removeListenerOnError

[GitBox <gi...@apache.org>]

wangshuo128 opened a new pull request #26924: [SPARK-30285][CORE]Fix race condition between LiveListenerBus#stop and AsyncEventQueue#removeListenerOnError
URL: https://github.com/apache/spark/pull/26924
 
 
   
   
   ### What changes were proposed in this pull request?
   
   There is a race condition between `LiveListenerBus#stop` and `AsyncEventQueue#removeListenerOnError`.
   
   We can reproduce as follows:
   
   1. Post some events to `LiveListenerBus`
   2. Call `LiveListenerBus#stop` and hold the synchronized lock of `bus`(https://github.com/apache/spark/blob/5e92301723464d0876b5a7eec59c15fed0c5b98c/core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala#L229), waiting until all the events are processed by listeners, then remove all the queues
   3. Event queue would drain out events by posting to its listeners. If a listener is interrupted, it will call `AsyncEventQueue#removeListenerOnError`,  inside it will call `bus.removeListener`(https://github.com/apache/spark/blob/7b1b60c7583faca70aeab2659f06d4e491efa5c0/core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala#L207), trying to acquire synchronized lock of bus, resulting in deadlock
   
   This PR marks interrupted listeners as dead and don't  call `LiveListenerBus#stop` or post event to  them during LiveListenerBus is stopping. 
   
   ### Why are the changes needed?
   To fix race condition.
   
   ### Does this PR introduce any user-facing change?
   No.
   
   ### How was this patch tested?
   New UT.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org