You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/11/09 12:57:27 UTC
[GitHub] [incubator-doris] killxdcj opened a new pull request #7067: [Feature] Support config scheduling strategy.
killxdcj opened a new pull request #7067:
URL: https://github.com/apache/incubator-doris/pull/7067
## Proposed changes
Support config scheduling strategy. More detail in: #7066
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
More detail in: #7066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Gabriel39 commented on a change in pull request #7067: [Feature] Add a scheduling strategy for high-throughput point query scenarios.
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on a change in pull request #7067:
URL: https://github.com/apache/incubator-doris/pull/7067#discussion_r750899047
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java
##########
@@ -1359,7 +1360,13 @@ private void computeScanRangeAssignment() throws Exception {
bucketShuffleJoinController.computeScanRangeAssignmentByBucket((OlapScanNode) scanNode, idToBackend, addressToBackendID);
}
if (!(fragmentContainsColocateJoin | fragmentContainsBucketShuffleJoin)) {
- computeScanRangeAssignmentByScheduler(scanNode, locations, assignment, assignedBytesPerHost);
+ long schedulingStrategy = (ConnectContext.get() == null ? ExecSchedulingStrategy.EVENLY_BACKEND.getValue() :
+ ConnectContext.get().getSessionVariable().getExecSchedulingStrategy());
+ if (schedulingStrategy == ExecSchedulingStrategy.MIN_BACKEND.getValue()) {
+ computeScanRangeAssignmentWithMinNodeStrategy(scanNode, locations, assignment, assignedBytesPerHost);
Review comment:
could you supplement UT for this new strategy?
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -154,17 +154,19 @@
public static final long DEFAULT_INSERT_VISIBLE_TIMEOUT_MS = 10_000;
public static final String EXTRACT_WIDE_RANGE_EXPR = "extract_wide_range_expr";
-
Review comment:
unnecessary update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] killxdcj commented on a change in pull request #7067: [Feature] Support config scheduling strategy.
Posted by GitBox <gi...@apache.org>.
killxdcj commented on a change in pull request #7067:
URL: https://github.com/apache/incubator-doris/pull/7067#discussion_r748059630
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java
##########
@@ -1456,6 +1463,47 @@ private void computeScanRangeAssignmentByScheduler(
}
}
+ private void computeScanRangeAssignmentWithMinNodeStrategy(
Review comment:
comments resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] killxdcj commented on a change in pull request #7067: [Feature] Support config scheduling strategy.
Posted by GitBox <gi...@apache.org>.
killxdcj commented on a change in pull request #7067:
URL: https://github.com/apache/incubator-doris/pull/7067#discussion_r748059948
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -384,6 +386,9 @@
@VariableMgr.VarAttr(name = ENABLE_LATERAL_VIEW, needForward = true)
public boolean enableLateralView = false;
+ @VariableMgr.VarAttr(name = EXEC_SCHEDULING_STRATEGY)
+ public String execSchedulingStrategy = ExecSchedulingStrategy.EVENLY_BACKEND.name();
Review comment:
Resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #7067: [Feature] Support config scheduling strategy.
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #7067:
URL: https://github.com/apache/incubator-doris/pull/7067#discussion_r747603771
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -384,6 +386,9 @@
@VariableMgr.VarAttr(name = ENABLE_LATERAL_VIEW, needForward = true)
public boolean enableLateralView = false;
+ @VariableMgr.VarAttr(name = EXEC_SCHEDULING_STRATEGY)
+ public String execSchedulingStrategy = ExecSchedulingStrategy.EVENLY_BACKEND.name();
Review comment:
For `String` type session variable, user may set any unexpected values.
I think you refer `sql_mode` or `runtime_filter_type`.
And also refer to the `VariableVarConverters.java`
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java
##########
@@ -1456,6 +1463,47 @@ private void computeScanRangeAssignmentByScheduler(
}
}
+ private void computeScanRangeAssignmentWithMinNodeStrategy(
Review comment:
Could you please add some comment to explain the logic of this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org