You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by rscrimojr <gi...@git.apache.org> on 2017/03/08 22:51:30 UTC
[GitHub] incubator-trafficcontrol pull request #340: [TC-177] changed psql to use URI...
GitHub user rscrimojr opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/340
[TC-177] changed psql to use URI.
This fixes [TC-177](https://issues.apache.org/jira/browse/TC-177)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rscrimojr/incubator-trafficcontrol TC177
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/340.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #340
----
commit a92d8a024b12b74a65fdffd8d0a9e5e805a03abd
Author: Robert Scrimo <ro...@comcast.com>
Date: 2017-03-08T22:42:14Z
changed psql to use URI.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #340: [TC-177] changed psql to use URI.
Posted by dangogh <gi...@git.apache.org>.
Github user dangogh commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/340
can you change the title to mention admin.pl? I want to be able to find this a year from now..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #340: [TC-177] changed psql to use URI for ad...
Posted by dangogh <gi...@git.apache.org>.
Github user dangogh commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/340
`[--admuser (Postgres Admin User)] [--admpwd (Postgres Admin Password)]` -- this requires a password on the cmd line -- not a good idea either, since it ends up in the shell history. what we talked about was having the user deal with being a user that has db admin privileges. Don't you think that would be better?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #340: [TC-177] changed psql to use URI...
Posted by rscrimojr <gi...@git.apache.org>.
Github user rscrimojr closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/340
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #340: [TC-177] changed psql to use URI for ad...
Posted by dangogh <gi...@git.apache.org>.
Github user dangogh commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/340
we ended up taking a different direction for running these commands, so this change isn't needed. Please close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #340: [TC-177] changed psql to use URI for ad...
Posted by dangogh <gi...@git.apache.org>.
Github user dangogh commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/340
no -- they should be able to make their own user able to connect as a db admin or create postgres user with the same. dbconf.yml is for goose. don't change that. I think this aspect of admin.pl should not have changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #340: [TC-177] changed psql to use URI for ad...
Posted by rscrimojr <gi...@git.apache.org>.
Github user rscrimojr commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/340
okay. I will try to do what you want when I have time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #340: [TC-177] changed psql to use URI for ad...
Posted by rscrimojr <gi...@git.apache.org>.
Github user rscrimojr commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/340
So you want the user installing trafficops to create a postges unix user or some other admin user?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #340: [TC-177] changed psql to use URI for ad...
Posted by rscrimojr <gi...@git.apache.org>.
Github user rscrimojr commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/340
The other thing to do is add the admin user and password as a new key in the dbconf.yml file? Does this sound okay as an alternative?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---