You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/18 20:57:09 UTC
[GitHub] [arrow] westonpace opened a new pull request, #13639: ARROW-16964: [C++] TSAN error in asof-join-node tests
westonpace opened a new pull request, #13639:
URL: https://github.com/apache/arrow/pull/13639
Converted `total_batches_` and `batches_processed_` to atomic variables since they are accessed simultaneously by the input received and process threads
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #13639: ARROW-16964: [C++] TSAN error in asof-join-node tests
Posted by GitBox <gi...@apache.org>.
westonpace commented on PR #13639:
URL: https://github.com/apache/arrow/pull/13639#issuecomment-1188305259
CC @icexelloss
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13639: ARROW-16964: [C++] TSAN error in asof-join-node tests
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13639:
URL: https://github.com/apache/arrow/pull/13639#issuecomment-1189996759
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/e17909c38e4f4ae1a6dfff960b0b77af...b90a899591084ca88f6d9bc322b11ced/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13639: ARROW-16964: [C++] TSAN error in asof-join-node tests
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13639:
URL: https://github.com/apache/arrow/pull/13639#issuecomment-1189996598
Benchmark runs are scheduled for baseline = 3a5284fc29a2b6906ecdb0d89a581051645d7549 and contender = 97fb0d5eae1fdfe55a0cf1c0e433dbe235a629da. 97fb0d5eae1fdfe55a0cf1c0e433dbe235a629da is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/819b6b9459b548a5847b36cfaefc97b8...eb5b514b8e1a412c8a732b8573c7e8ef/)
[Failed :arrow_down:0.94% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ece815bd45774a5c8a7ffa8b67ec366d...090f5ce38bc2453a9d5eddb080713ae2/)
[Failed :arrow_down:0.95% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/e17909c38e4f4ae1a6dfff960b0b77af...b90a899591084ca88f6d9bc322b11ced/)
[Finished :arrow_down:1.39% :arrow_up:1.54%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/3bced2f853d54dc4b35fd8a87e429127...8df13abbd8004a8cbc9bd6ad2aca693f/)
Buildkite builds:
[Failed] [`97fb0d5e` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1143)
[Failed] [`97fb0d5e` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1148)
[Failed] [`97fb0d5e` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1135)
[Finished] [`97fb0d5e` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1152)
[Failed] [`3a5284fc` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1142)
[Failed] [`3a5284fc` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1147)
[Failed] [`3a5284fc` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1134)
[Finished] [`3a5284fc` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1151)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #13639: ARROW-16964: [C++] TSAN error in asof-join-node tests
Posted by GitBox <gi...@apache.org>.
pitrou merged PR #13639:
URL: https://github.com/apache/arrow/pull/13639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] icexelloss commented on pull request #13639: ARROW-16964: [C++] TSAN error in asof-join-node tests
Posted by GitBox <gi...@apache.org>.
icexelloss commented on PR #13639:
URL: https://github.com/apache/arrow/pull/13639#issuecomment-1189170485
Thanks @westonpace! And sorry I missed Jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13639: ARROW-16964: [C++] TSAN error in asof-join-node tests
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13639:
URL: https://github.com/apache/arrow/pull/13639#issuecomment-1188779494
Revision: cd78260b9ca170107e00870cba0a138d081edabf
Submitted crossbow builds: [ursacomputing/crossbow @ actions-f9994f26c6](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f9994f26c6)
|Task|Status|
|----|------|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-f9994f26c6-github-test-build-cpp-fuzz)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-f9994f26c6-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-f9994f26c6-azure-test-conda-cpp-valgrind)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-f9994f26c6-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-f9994f26c6-github-test-debian-10-cpp-i386)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-f9994f26c6-github-test-debian-11-cpp-amd64)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-f9994f26c6-github-test-debian-11-cpp-i386)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-f9994f26c6-github-test-fedora-35-cpp)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-f9994f26c6-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-f9994f26c6-github-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-f9994f26c6-github-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-f9994f26c6-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-f9994f26c6-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-f9994f26c6-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-f9994f26c6-github-test-ubuntu-20.04-cpp-bundled)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-f9994f26c6-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-f9994f26c6-github-test-ubuntu-22.04-cpp)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #13639: ARROW-16964: [C++] TSAN error in asof-join-node tests
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13639:
URL: https://github.com/apache/arrow/pull/13639#issuecomment-1188778386
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #13639: ARROW-16964: [C++] TSAN error in asof-join-node tests
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13639:
URL: https://github.com/apache/arrow/pull/13639#issuecomment-1188973925
CI results are quite noisy... but I'm assuming the failures aren't due to this (innocuous?) change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13639: ARROW-16964: [C++] TSAN error in asof-join-node tests
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13639:
URL: https://github.com/apache/arrow/pull/13639#issuecomment-1188302574
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13639: ARROW-16964: [C++] TSAN error in asof-join-node tests
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13639:
URL: https://github.com/apache/arrow/pull/13639#issuecomment-1188302547
https://issues.apache.org/jira/browse/ARROW-16964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org