You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shiro.apache.org by GitBox <gi...@apache.org> on 2021/09/16 22:02:25 UTC
[GitHub] [shiro-site] bdemers opened a new pull request #91: jbake footer fix
bdemers opened a new pull request #91:
URL: https://github.com/apache/shiro-site/pull/91
jbake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro-site] bdemers commented on a change in pull request #91: Moved footer out of page content containe
Posted by GitBox <gi...@apache.org>.
bdemers commented on a change in pull request #91:
URL: https://github.com/apache/shiro-site/pull/91#discussion_r711143836
##########
File path: jbake/templates/index.ftl
##########
@@ -110,70 +110,64 @@
</a>
</div>
- <div class="panel panel-primary">
- <div class=" panel-heading" style="text-align: center;">
- <h3>Latest news:</h3>
+ <div class="card border-primary mb-4 shadow-sm">
+ <div class="card-header bg-primary text-white" style="text-align: center;">
+ <h3 class="card-title">Latest news:</h3>
</div>
- <div class="panel-body">
+ <div class="card-body">
<#list posts as post>
<#if (post.status == "published" && post?index >= (currentPageNumber-1) * config.index_posts_per_page?eval && post?index < currentPageNumber * config.index_posts_per_page?eval)>
<div>
- <a href="${post.uri}"><small><h4>${post.title}</h4></small></a>
+ <a href="${post.uri}"><small>${post.title}</small></a>
<p><small>by ${(post.author)!"The Apache Shiro Team"} on ${post.date?string("yyyy-MM-dd")}</small></p>
</div>
</#if>
</#list>
<hr/>
- <nav aria-label="News Pagination">
- <ul class="pagination">
+ <div class="btn-group d-flex justify-content-center" role="group" aria-label="News Pagination">
<#if (currentPageNumber > 1)>
- <li class="page-item"><a class="page-link" href="<#if (content.rootpath)??>${content.rootpath}</#if>/${(currentPageNumber==2)?then('', currentPageNumber-1)}">Previous</a></li>
+ <a class="btn btn-outline-primary" href="<#if (content.rootpath)??>${content.rootpath}</#if>/${(currentPageNumber==2)?then('', currentPageNumber-1)}">Previous</a>
</#if>
<#if (currentPageNumber > 1 && currentPageNumber != numberOfPages)>
- <li class="page-item"><a class="page-link" href="${currentPageNumber}">${currentPageNumber}</a></li>
+ <a class="btn btn-outline-primary " href="${currentPageNumber}">${currentPageNumber}</a>
</#if>
<#if (currentPageNumber < numberOfPages)>
- <li class="page-item"><a class="page-link" href="<#if (content.rootpath)??>${content.rootpath}</#if>${currentPageNumber + 1}">Next</a></li>
+ <a class="btn btn-outline-primary" href="<#if (content.rootpath)??>${content.rootpath}</#if>${currentPageNumber + 1}">Next</a>
</#if>
Review comment:
Actually, I think I was just trying to fix the centering and didn't realize it was an existing component 🤦
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro-site] bmarwell commented on a change in pull request #91: Moved footer out of page content containe
Posted by GitBox <gi...@apache.org>.
bmarwell commented on a change in pull request #91:
URL: https://github.com/apache/shiro-site/pull/91#discussion_r710768859
##########
File path: jbake/templates/index.ftl
##########
@@ -110,70 +110,64 @@
</a>
</div>
- <div class="panel panel-primary">
- <div class=" panel-heading" style="text-align: center;">
- <h3>Latest news:</h3>
+ <div class="card border-primary mb-4 shadow-sm">
+ <div class="card-header bg-primary text-white" style="text-align: center;">
+ <h3 class="card-title">Latest news:</h3>
</div>
- <div class="panel-body">
+ <div class="card-body">
<#list posts as post>
<#if (post.status == "published" && post?index >= (currentPageNumber-1) * config.index_posts_per_page?eval && post?index < currentPageNumber * config.index_posts_per_page?eval)>
<div>
- <a href="${post.uri}"><small><h4>${post.title}</h4></small></a>
+ <a href="${post.uri}"><small>${post.title}</small></a>
<p><small>by ${(post.author)!"The Apache Shiro Team"} on ${post.date?string("yyyy-MM-dd")}</small></p>
</div>
</#if>
</#list>
<hr/>
- <nav aria-label="News Pagination">
- <ul class="pagination">
+ <div class="btn-group d-flex justify-content-center" role="group" aria-label="News Pagination">
<#if (currentPageNumber > 1)>
- <li class="page-item"><a class="page-link" href="<#if (content.rootpath)??>${content.rootpath}</#if>/${(currentPageNumber==2)?then('', currentPageNumber-1)}">Previous</a></li>
+ <a class="btn btn-outline-primary" href="<#if (content.rootpath)??>${content.rootpath}</#if>/${(currentPageNumber==2)?then('', currentPageNumber-1)}">Previous</a>
</#if>
<#if (currentPageNumber > 1 && currentPageNumber != numberOfPages)>
- <li class="page-item"><a class="page-link" href="${currentPageNumber}">${currentPageNumber}</a></li>
+ <a class="btn btn-outline-primary " href="${currentPageNumber}">${currentPageNumber}</a>
</#if>
<#if (currentPageNumber < numberOfPages)>
- <li class="page-item"><a class="page-link" href="<#if (content.rootpath)??>${content.rootpath}</#if>${currentPageNumber + 1}">Next</a></li>
+ <a class="btn btn-outline-primary" href="<#if (content.rootpath)??>${content.rootpath}</#if>${currentPageNumber + 1}">Next</a>
</#if>
Review comment:
I need to fix those links btw :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro-site] bdemers commented on a change in pull request #91: Moved footer out of page content containe
Posted by GitBox <gi...@apache.org>.
bdemers commented on a change in pull request #91:
URL: https://github.com/apache/shiro-site/pull/91#discussion_r711139786
##########
File path: jbake/templates/index.ftl
##########
@@ -110,70 +110,64 @@
</a>
</div>
- <div class="panel panel-primary">
- <div class=" panel-heading" style="text-align: center;">
- <h3>Latest news:</h3>
+ <div class="card border-primary mb-4 shadow-sm">
+ <div class="card-header bg-primary text-white" style="text-align: center;">
+ <h3 class="card-title">Latest news:</h3>
</div>
- <div class="panel-body">
+ <div class="card-body">
<#list posts as post>
<#if (post.status == "published" && post?index >= (currentPageNumber-1) * config.index_posts_per_page?eval && post?index < currentPageNumber * config.index_posts_per_page?eval)>
<div>
- <a href="${post.uri}"><small><h4>${post.title}</h4></small></a>
+ <a href="${post.uri}"><small>${post.title}</small></a>
Review comment:
ahh, ok, we might just need to style them a bit to reduce the font size
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro-site] bmarwell merged pull request #91: Moved footer out of page content containe
Posted by GitBox <gi...@apache.org>.
bmarwell merged pull request #91:
URL: https://github.com/apache/shiro-site/pull/91
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro-site] bmarwell commented on a change in pull request #91: Moved footer out of page content containe
Posted by GitBox <gi...@apache.org>.
bmarwell commented on a change in pull request #91:
URL: https://github.com/apache/shiro-site/pull/91#discussion_r710770525
##########
File path: jbake/templates/index.ftl
##########
@@ -110,70 +110,64 @@
</a>
</div>
- <div class="panel panel-primary">
- <div class=" panel-heading" style="text-align: center;">
- <h3>Latest news:</h3>
+ <div class="card border-primary mb-4 shadow-sm">
+ <div class="card-header bg-primary text-white" style="text-align: center;">
+ <h3 class="card-title">Latest news:</h3>
</div>
- <div class="panel-body">
+ <div class="card-body">
<#list posts as post>
<#if (post.status == "published" && post?index >= (currentPageNumber-1) * config.index_posts_per_page?eval && post?index < currentPageNumber * config.index_posts_per_page?eval)>
<div>
- <a href="${post.uri}"><small><h4>${post.title}</h4></small></a>
+ <a href="${post.uri}"><small>${post.title}</small></a>
Review comment:
Important links to other pages should have a heading from what I know, at least all major SEO sites are still doing this, too (and wordpress if you enable snippets and jekyll and jbake in their default templates...).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro-site] bdemers commented on pull request #91: Moved footer out of page content containe
Posted by GitBox <gi...@apache.org>.
bdemers commented on pull request #91:
URL: https://github.com/apache/shiro-site/pull/91#issuecomment-921919454
@bmarwell the `git mv` of the images required a rebase/force-push, but I think I address all three issues, take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro-site] bmarwell commented on a change in pull request #91: Moved footer out of page content containe
Posted by GitBox <gi...@apache.org>.
bmarwell commented on a change in pull request #91:
URL: https://github.com/apache/shiro-site/pull/91#discussion_r710768540
##########
File path: jbake/templates/index.ftl
##########
@@ -110,70 +110,64 @@
</a>
</div>
- <div class="panel panel-primary">
- <div class=" panel-heading" style="text-align: center;">
- <h3>Latest news:</h3>
+ <div class="card border-primary mb-4 shadow-sm">
+ <div class="card-header bg-primary text-white" style="text-align: center;">
+ <h3 class="card-title">Latest news:</h3>
</div>
- <div class="panel-body">
+ <div class="card-body">
<#list posts as post>
<#if (post.status == "published" && post?index >= (currentPageNumber-1) * config.index_posts_per_page?eval && post?index < currentPageNumber * config.index_posts_per_page?eval)>
<div>
- <a href="${post.uri}"><small><h4>${post.title}</h4></small></a>
+ <a href="${post.uri}"><small>${post.title}</small></a>
<p><small>by ${(post.author)!"The Apache Shiro Team"} on ${post.date?string("yyyy-MM-dd")}</small></p>
</div>
</#if>
</#list>
<hr/>
- <nav aria-label="News Pagination">
- <ul class="pagination">
+ <div class="btn-group d-flex justify-content-center" role="group" aria-label="News Pagination">
<#if (currentPageNumber > 1)>
- <li class="page-item"><a class="page-link" href="<#if (content.rootpath)??>${content.rootpath}</#if>/${(currentPageNumber==2)?then('', currentPageNumber-1)}">Previous</a></li>
+ <a class="btn btn-outline-primary" href="<#if (content.rootpath)??>${content.rootpath}</#if>/${(currentPageNumber==2)?then('', currentPageNumber-1)}">Previous</a>
</#if>
<#if (currentPageNumber > 1 && currentPageNumber != numberOfPages)>
- <li class="page-item"><a class="page-link" href="${currentPageNumber}">${currentPageNumber}</a></li>
+ <a class="btn btn-outline-primary " href="${currentPageNumber}">${currentPageNumber}</a>
</#if>
<#if (currentPageNumber < numberOfPages)>
- <li class="page-item"><a class="page-link" href="<#if (content.rootpath)??>${content.rootpath}</#if>${currentPageNumber + 1}">Next</a></li>
+ <a class="btn btn-outline-primary" href="<#if (content.rootpath)??>${content.rootpath}</#if>${currentPageNumber + 1}">Next</a>
</#if>
Review comment:
Oh yeah that also works. Anything wrong with following https://getbootstrap.com/docs/5.0/components/pagination/ though? Did it not work for you? (style-wise)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro-site] bdemers commented on a change in pull request #91: Moved footer out of page content containe
Posted by GitBox <gi...@apache.org>.
bdemers commented on a change in pull request #91:
URL: https://github.com/apache/shiro-site/pull/91#discussion_r711138819
##########
File path: jbake/templates/index.ftl
##########
@@ -110,70 +110,64 @@
</a>
</div>
- <div class="panel panel-primary">
- <div class=" panel-heading" style="text-align: center;">
- <h3>Latest news:</h3>
+ <div class="card border-primary mb-4 shadow-sm">
+ <div class="card-header bg-primary text-white" style="text-align: center;">
+ <h3 class="card-title">Latest news:</h3>
</div>
- <div class="panel-body">
+ <div class="card-body">
<#list posts as post>
<#if (post.status == "published" && post?index >= (currentPageNumber-1) * config.index_posts_per_page?eval && post?index < currentPageNumber * config.index_posts_per_page?eval)>
<div>
- <a href="${post.uri}"><small><h4>${post.title}</h4></small></a>
+ <a href="${post.uri}"><small>${post.title}</small></a>
<p><small>by ${(post.author)!"The Apache Shiro Team"} on ${post.date?string("yyyy-MM-dd")}</small></p>
</div>
</#if>
</#list>
<hr/>
- <nav aria-label="News Pagination">
- <ul class="pagination">
+ <div class="btn-group d-flex justify-content-center" role="group" aria-label="News Pagination">
<#if (currentPageNumber > 1)>
- <li class="page-item"><a class="page-link" href="<#if (content.rootpath)??>${content.rootpath}</#if>/${(currentPageNumber==2)?then('', currentPageNumber-1)}">Previous</a></li>
+ <a class="btn btn-outline-primary" href="<#if (content.rootpath)??>${content.rootpath}</#if>/${(currentPageNumber==2)?then('', currentPageNumber-1)}">Previous</a>
</#if>
<#if (currentPageNumber > 1 && currentPageNumber != numberOfPages)>
- <li class="page-item"><a class="page-link" href="${currentPageNumber}">${currentPageNumber}</a></li>
+ <a class="btn btn-outline-primary " href="${currentPageNumber}">${currentPageNumber}</a>
</#if>
<#if (currentPageNumber < numberOfPages)>
- <li class="page-item"><a class="page-link" href="<#if (content.rootpath)??>${content.rootpath}</#if>${currentPageNumber + 1}">Next</a></li>
+ <a class="btn btn-outline-primary" href="<#if (content.rootpath)??>${content.rootpath}</#if>${currentPageNumber + 1}">Next</a>
</#if>
Review comment:
Oh nice! I didn't see that component! I'll tweak it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro-site] bdemers commented on pull request #91: Moved footer out of page content containe
Posted by GitBox <gi...@apache.org>.
bdemers commented on pull request #91:
URL: https://github.com/apache/shiro-site/pull/91#issuecomment-921875327
> Wow, gerat PR! Thanks!
>
> Just two nits (added as comments) and one request: In case you moved the pictures from the old site, can you use `git mv` so they get deleted in the old path? I think this would help us keep track of what we have done so far.
>
> Thanks! 👍🏻
Oh yeah, I forgot about that, will do!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org