You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by GitBox <gi...@apache.org> on 2022/11/21 16:10:18 UTC
[GitHub] [streampipes-website] bossenti opened a new pull request, #34: [STREAMPIPES-639] remove incubating references
bossenti opened a new pull request, #34:
URL: https://github.com/apache/streampipes-website/pull/34
<!--
Thanks for contributing! Here are some tips you can follow to help us incorporate your contribution quickly and easily:
1. If this is your first time, please read our contributor guidelines:
- https://streampipes.apache.org/getinvolved.html
- https://cwiki.apache.org/confluence/display/STREAMPIPES/Getting+Started
2. Make sure the PR title is formatted like: `[STREAMPIPES-<Jira issue #>] PR title ...`
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., `[WIP][STREAMPIPES-<Jira issue #>] PR title ...`.
4. Please write your PR title to summarize what this PR proposes/fixes.
5. Be sure to keep the PR description updated to reflect all changes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. Make sure tests pass via `mvn clean install`.
8. (Optional) If the contribution is large, please file an Apache ICLA
- http://apache.org/licenses/icla.pdf
-->
### Purpose
<!--
Please clarify what changes you are proposing and describe how those changes will address the issue.
-->
Remove all incubating references from website + docs.
### Remarks
<!--
List related issues/PRs, link to discussions in the mailing list, todo items, or any other notes related to the PR.
-->
Fixes: STREAMPIPES-639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes-website] dominikriemer commented on a diff in pull request #34: [STREAMPIPES-639] remove incubating references
Posted by GitBox <gi...@apache.org>.
dominikriemer commented on code in PR #34:
URL: https://github.com/apache/streampipes-website/pull/34#discussion_r1028491250
##########
documentation/website/core/Footer.js:
##########
@@ -101,8 +101,6 @@ class Footer extends React.Component {
</a>
</div>
</section>
-
- <section className="copyright">{this.props.config.copyright}<p style={{marginBottom:'0px', marginLeft:'20px', marginRight:'20px'}}>Disclaimer: Apache StreamPipes (incubating) is an effort undergoing incubation at The Apache Software Foundation (ASF), sponsored by the Apache Incubator. Incubation is required of all newly accepted projects until a further review indicates that the infrastructure, communications, and decision making process have stabilized in a manner consistent with other successful ASF projects. While incubation status is not necessarily a reflection of the completeness or stability of the code, it does indicate that the project has yet to be fully endorsed by the ASF.</p></section>
Review Comment:
I think Copyright (c) 2019 -2022 should be right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes-website] dominikriemer commented on a diff in pull request #34: [STREAMPIPES-639] remove incubating references
Posted by GitBox <gi...@apache.org>.
dominikriemer commented on code in PR #34:
URL: https://github.com/apache/streampipes-website/pull/34#discussion_r1028435020
##########
documentation/website/core/Footer.js:
##########
@@ -101,8 +101,6 @@ class Footer extends React.Component {
</a>
</div>
</section>
-
- <section className="copyright">{this.props.config.copyright}<p style={{marginBottom:'0px', marginLeft:'20px', marginRight:'20px'}}>Disclaimer: Apache StreamPipes (incubating) is an effort undergoing incubation at The Apache Software Foundation (ASF), sponsored by the Apache Incubator. Incubation is required of all newly accepted projects until a further review indicates that the infrastructure, communications, and decision making process have stabilized in a manner consistent with other successful ASF projects. While incubation status is not necessarily a reflection of the completeness or stability of the code, it does indicate that the project has yet to be fully endorsed by the ASF.</p></section>
Review Comment:
Copyright start should be 2019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes-website] dominikriemer commented on a diff in pull request #34: [STREAMPIPES-639] remove incubating references
Posted by GitBox <gi...@apache.org>.
dominikriemer commented on code in PR #34:
URL: https://github.com/apache/streampipes-website/pull/34#discussion_r1028427037
##########
README.md:
##########
@@ -1,8 +1,8 @@
-[](https://github.com/apache/incubator-streampipes-website/actions/)
-# Apache StreamPipes (incubating) Website + Docs
+[](https://github.com/apache/streampipes-website/actions/)
Review Comment:
Good find!
I think we can just update the repo link without any further configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes-website] bossenti commented on a diff in pull request #34: [STREAMPIPES-639] remove incubating references
Posted by GitBox <gi...@apache.org>.
bossenti commented on code in PR #34:
URL: https://github.com/apache/streampipes-website/pull/34#discussion_r1028247375
##########
README.md:
##########
@@ -1,8 +1,8 @@
-[](https://github.com/apache/incubator-streampipes-website/actions/)
-# Apache StreamPipes (incubating) Website + Docs
+[](https://github.com/apache/streampipes-website/actions/)
Review Comment:
how can we update this link? Do we have them adapted in the main repository?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes-website] bossenti merged pull request #34: [STREAMPIPES-639] remove incubating references
Posted by GitBox <gi...@apache.org>.
bossenti merged PR #34:
URL: https://github.com/apache/streampipes-website/pull/34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes-website] bossenti commented on a diff in pull request #34: [STREAMPIPES-639] remove incubating references
Posted by GitBox <gi...@apache.org>.
bossenti commented on code in PR #34:
URL: https://github.com/apache/streampipes-website/pull/34#discussion_r1028463837
##########
website/partials/_index-teaser.ejs:
##########
@@ -11,7 +11,7 @@
<div style="background:rgba(255, 255, 255, 0.95);margin-top:50px;margin-bottom:50px;padding:35px;border-radius:15px;display:inline-block;max-width:750px;">
<div class="row" style="margin-left:0px;margin-right:0px;">
<h1 class="header-apache-text">Apache <span class="sp-green">S</span><span
Review Comment:
yes, for example. Just as an idea :)
##########
documentation/website/core/Footer.js:
##########
@@ -101,8 +101,6 @@ class Footer extends React.Component {
</a>
</div>
</section>
-
- <section className="copyright">{this.props.config.copyright}<p style={{marginBottom:'0px', marginLeft:'20px', marginRight:'20px'}}>Disclaimer: Apache StreamPipes (incubating) is an effort undergoing incubation at The Apache Software Foundation (ASF), sponsored by the Apache Incubator. Incubation is required of all newly accepted projects until a further review indicates that the infrastructure, communications, and decision making process have stabilized in a manner consistent with other successful ASF projects. While incubation status is not necessarily a reflection of the completeness or stability of the code, it does indicate that the project has yet to be fully endorsed by the ASF.</p></section>
Review Comment:
Soo, `Copyright © 2022 ` or `Copyright © 2019-2022`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes-website] bossenti commented on a diff in pull request #34: [STREAMPIPES-639] remove incubating references
Posted by GitBox <gi...@apache.org>.
bossenti commented on code in PR #34:
URL: https://github.com/apache/streampipes-website/pull/34#discussion_r1028505004
##########
documentation/website/core/Footer.js:
##########
@@ -101,8 +101,6 @@ class Footer extends React.Component {
</a>
</div>
</section>
-
- <section className="copyright">{this.props.config.copyright}<p style={{marginBottom:'0px', marginLeft:'20px', marginRight:'20px'}}>Disclaimer: Apache StreamPipes (incubating) is an effort undergoing incubation at The Apache Software Foundation (ASF), sponsored by the Apache Incubator. Incubation is required of all newly accepted projects until a further review indicates that the infrastructure, communications, and decision making process have stabilized in a manner consistent with other successful ASF projects. While incubation status is not necessarily a reflection of the completeness or stability of the code, it does indicate that the project has yet to be fully endorsed by the ASF.</p></section>
Review Comment:
I guess that's already part of the footer or am I mistaken?
https://github.com/apache/streampipes-website/blob/STREAMPIPES-639/website/partials/_footer.ejs#L4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes-website] dominikriemer commented on a diff in pull request #34: [STREAMPIPES-639] remove incubating references
Posted by GitBox <gi...@apache.org>.
dominikriemer commented on code in PR #34:
URL: https://github.com/apache/streampipes-website/pull/34#discussion_r1028489444
##########
website/partials/_download_box.ejs:
##########
@@ -20,20 +20,20 @@
</thead>
<tbody>
<tr>
- <td><a href="https://www.apache.org/dyn/closer.lua?action=download&filename=incubator/streampipes/0.70.0/apache-streampipes-0.70.0-incubating-source-release.zip">apache-streampipes-0.70.0-incubating-source-release.zip</a></td>
+ <td><a href="https://www.apache.org/dyn/closer.lua?action=download&filename=streampipes/0.70.0/apache-streampipes-0.70.0-incubating-source-release.zip">apache-streampipes-0.70.0-incubating-source-release.zip</a></td>
<td>0.70.0</td>
<td>2022-10-13</td>
<td>
- <a href="https://downloads.apache.org/incubator/streampipes/0.70.0/apache-streampipes-0.70.0-incubating-source-release.zip.sha512">SHA</a>
Review Comment:
Oh sorry, I didn't know that there is a redirect, very cool ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes-website] bossenti commented on a diff in pull request #34: [STREAMPIPES-639] remove incubating references
Posted by GitBox <gi...@apache.org>.
bossenti commented on code in PR #34:
URL: https://github.com/apache/streampipes-website/pull/34#discussion_r1028462519
##########
website/partials/_download_box.ejs:
##########
@@ -20,20 +20,20 @@
</thead>
<tbody>
<tr>
- <td><a href="https://www.apache.org/dyn/closer.lua?action=download&filename=incubator/streampipes/0.70.0/apache-streampipes-0.70.0-incubating-source-release.zip">apache-streampipes-0.70.0-incubating-source-release.zip</a></td>
+ <td><a href="https://www.apache.org/dyn/closer.lua?action=download&filename=streampipes/0.70.0/apache-streampipes-0.70.0-incubating-source-release.zip">apache-streampipes-0.70.0-incubating-source-release.zip</a></td>
<td>0.70.0</td>
<td>2022-10-13</td>
<td>
- <a href="https://downloads.apache.org/incubator/streampipes/0.70.0/apache-streampipes-0.70.0-incubating-source-release.zip.sha512">SHA</a>
Review Comment:
Please give it a try, at least it has worked already on my end :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes-website] dominikriemer commented on a diff in pull request #34: [STREAMPIPES-639] remove incubating references
Posted by GitBox <gi...@apache.org>.
dominikriemer commented on code in PR #34:
URL: https://github.com/apache/streampipes-website/pull/34#discussion_r1030086662
##########
documentation/website/core/Footer.js:
##########
@@ -101,8 +101,6 @@ class Footer extends React.Component {
</a>
</div>
</section>
-
- <section className="copyright">{this.props.config.copyright}<p style={{marginBottom:'0px', marginLeft:'20px', marginRight:'20px'}}>Disclaimer: Apache StreamPipes (incubating) is an effort undergoing incubation at The Apache Software Foundation (ASF), sponsored by the Apache Incubator. Incubation is required of all newly accepted projects until a further review indicates that the infrastructure, communications, and decision making process have stabilized in a manner consistent with other successful ASF projects. While incubation status is not necessarily a reflection of the completeness or stability of the code, it does indicate that the project has yet to be fully endorsed by the ASF.</p></section>
Review Comment:
I also added it to the documentation footer in addition to the website.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes-website] bossenti commented on a diff in pull request #34: [STREAMPIPES-639] remove incubating references
Posted by GitBox <gi...@apache.org>.
bossenti commented on code in PR #34:
URL: https://github.com/apache/streampipes-website/pull/34#discussion_r1028248940
##########
website/partials/_index-teaser.ejs:
##########
@@ -11,7 +11,7 @@
<div style="background:rgba(255, 255, 255, 0.95);margin-top:50px;margin-bottom:50px;padding:35px;border-radius:15px;display:inline-block;max-width:750px;">
<div class="row" style="margin-left:0px;margin-right:0px;">
<h1 class="header-apache-text">Apache <span class="sp-green">S</span><span
Review Comment:
@dominikriemer we could update the index page similar to the README of the main repository, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes-website] dominikriemer commented on a diff in pull request #34: [STREAMPIPES-639] remove incubating references
Posted by GitBox <gi...@apache.org>.
dominikriemer commented on code in PR #34:
URL: https://github.com/apache/streampipes-website/pull/34#discussion_r1028429727
##########
documentation/website/core/Footer.js:
##########
@@ -101,8 +101,6 @@ class Footer extends React.Component {
</a>
</div>
</section>
-
- <section className="copyright">{this.props.config.copyright}<p style={{marginBottom:'0px', marginLeft:'20px', marginRight:'20px'}}>Disclaimer: Apache StreamPipes (incubating) is an effort undergoing incubation at The Apache Software Foundation (ASF), sponsored by the Apache Incubator. Incubation is required of all newly accepted projects until a further review indicates that the infrastructure, communications, and decision making process have stabilized in a manner consistent with other successful ASF projects. While incubation status is not necessarily a reflection of the completeness or stability of the code, it does indicate that the project has yet to be fully endorsed by the ASF.</p></section>
Review Comment:
We could add here instead of the Incubator disclaimer:
Copyright © 2022 The Apache Software Foundation.
Apache and the Apache feather logo are trademarks of The Apache Software Foundation.
##########
website/partials/_index-teaser.ejs:
##########
@@ -11,7 +11,7 @@
<div style="background:rgba(255, 255, 255, 0.95);margin-top:50px;margin-bottom:50px;padding:35px;border-radius:15px;display:inline-block;max-width:750px;">
<div class="row" style="margin-left:0px;margin-right:0px;">
<h1 class="header-apache-text">Apache <span class="sp-green">S</span><span
Review Comment:
with the new texts and images?
##########
website/partials/_download_box.ejs:
##########
@@ -20,20 +20,20 @@
</thead>
<tbody>
<tr>
- <td><a href="https://www.apache.org/dyn/closer.lua?action=download&filename=incubator/streampipes/0.70.0/apache-streampipes-0.70.0-incubating-source-release.zip">apache-streampipes-0.70.0-incubating-source-release.zip</a></td>
+ <td><a href="https://www.apache.org/dyn/closer.lua?action=download&filename=streampipes/0.70.0/apache-streampipes-0.70.0-incubating-source-release.zip">apache-streampipes-0.70.0-incubating-source-release.zip</a></td>
<td>0.70.0</td>
<td>2022-10-13</td>
<td>
- <a href="https://downloads.apache.org/incubator/streampipes/0.70.0/apache-streampipes-0.70.0-incubating-source-release.zip.sha512">SHA</a>
Review Comment:
We have not set up the new distribution directories yet.
So in case we want to update the website before the announcement, we either need to copy the last incubating release to the new distribution area, keep the old link or wait for the first non-incubating release and update the website afterwards, whatever you prefer ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes-website] bossenti commented on a diff in pull request #34: [STREAMPIPES-639] remove incubating references
Posted by GitBox <gi...@apache.org>.
bossenti commented on code in PR #34:
URL: https://github.com/apache/streampipes-website/pull/34#discussion_r1028464996
##########
README.md:
##########
@@ -1,8 +1,8 @@
-[](https://github.com/apache/incubator-streampipes-website/actions/)
-# Apache StreamPipes (incubating) Website + Docs
+[](https://github.com/apache/streampipes-website/actions/)
Review Comment:
Indeed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org