You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openmeetings.apache.org by so...@apache.org on 2018/02/19 15:13:32 UTC

[openmeetings] branch 4.0.x updated: [OPENMEETINGS-1803] js issue reported by Sonar should be fixed

This is an automated email from the ASF dual-hosted git repository.

solomax pushed a commit to branch 4.0.x
in repository https://gitbox.apache.org/repos/asf/openmeetings.git


The following commit(s) were added to refs/heads/4.0.x by this push:
     new 48f2dc4  [OPENMEETINGS-1803] js issue reported by Sonar should be fixed
48f2dc4 is described below

commit 48f2dc4581b9f76eeaf2f6f552ab2934b2cba6ab
Author: Maxim Solodovnik <so...@gmail.com>
AuthorDate: Mon Feb 19 22:13:21 2018 +0700

    [OPENMEETINGS-1803] js issue reported by Sonar should be fixed
---
 .../main/java/org/apache/openmeetings/web/user/chat/chat-base.js    | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/chat-base.js b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/chat-base.js
index 019b8cc..8c9e556 100644
--- a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/chat-base.js
+++ b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/chat-base.js
@@ -60,6 +60,9 @@ var Chat = function() {
 		typingTimer = null;
 		chatActivity('typing_stop', $('.room.box').data('room-id'));
 	}
+	function _emtClick() {
+		_editorAppend($(this).data('emt'));
+	}
 	function initToolbar() {
 		const emots = emoticon.emoticons;
 		const rowSize = 20, emotMenuList = $('#emotMenuList');
@@ -72,7 +75,7 @@ var Chat = function() {
 			}
 			row.append($('<td>').append(
 					$('<div>').addClass('emt').html(emoticon.emoticonize(emots[i]))
-						.data('emt', emots[i]).click(function() {Chat.emtClick($(this).data('emt'));})
+						.data('emt', emots[i]).click(_emtClick)
 				));
 		}
 		const emtBtn = $('#emoticons');
@@ -409,7 +412,6 @@ var Chat = function() {
 		}
 		, close: _close
 		, toggle: _toggle
-		, emtClick: _editorAppend
 		, setRoomMode: _setRoomMode
 		, setHeight: _setHeight
 		, clean: _clean

-- 
To stop receiving notification emails like this one, please contact
solomax@apache.org.