You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/10/30 04:02:59 UTC
[kudu-CR] mt-rowset delta compaction-test: remove dead code
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11824
to review the following change.
Change subject: mt-rowset_delta_compaction-test: remove dead code
......................................................................
mt-rowset_delta_compaction-test: remove dead code
This should have been removed in commit b6306163b.
Change-Id: I9ce38fc2555f05ab5401fc56d4c5dca20258d436
---
M src/kudu/tablet/mt-rowset_delta_compaction-test.cc
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/11824/1
--
To view, visit http://gerrit.cloudera.org:8080/11824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ce38fc2555f05ab5401fc56d4c5dca20258d436
Gerrit-Change-Number: 11824
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] mt-rowset delta compaction-test: remove dead code
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11824 )
Change subject: mt-rowset_delta_compaction-test: remove dead code
......................................................................
Patch Set 1: Verified+1
Overriding Jenkins, unrelated test failure.
--
To view, visit http://gerrit.cloudera.org:8080/11824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ce38fc2555f05ab5401fc56d4c5dca20258d436
Gerrit-Change-Number: 11824
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 30 Oct 2018 20:59:56 +0000
Gerrit-HasComments: No
[kudu-CR] mt-rowset delta compaction-test: remove dead code
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11824 )
Change subject: mt-rowset_delta_compaction-test: remove dead code
......................................................................
mt-rowset_delta_compaction-test: remove dead code
This should have been removed in commit b6306163b.
Change-Id: I9ce38fc2555f05ab5401fc56d4c5dca20258d436
Reviewed-on: http://gerrit.cloudera.org:8080/11824
Tested-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/tablet/mt-rowset_delta_compaction-test.cc
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ce38fc2555f05ab5401fc56d4c5dca20258d436
Gerrit-Change-Number: 11824
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] mt-rowset delta compaction-test: remove dead code
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Alexey Serbin from this change. ( http://gerrit.cloudera.org:8080/11824 )
Change subject: mt-rowset_delta_compaction-test: remove dead code
......................................................................
Removed reviewer Alexey Serbin with the following votes:
* Code-Review+2 by Alexey Serbin <as...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/11824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I9ce38fc2555f05ab5401fc56d4c5dca20258d436
Gerrit-Change-Number: 11824
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] mt-rowset delta compaction-test: remove dead code
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11824 )
Change subject: mt-rowset_delta_compaction-test: remove dead code
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ce38fc2555f05ab5401fc56d4c5dca20258d436
Gerrit-Change-Number: 11824
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 30 Oct 2018 04:37:58 +0000
Gerrit-HasComments: No
[kudu-CR] mt-rowset delta compaction-test: remove dead code
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11824 )
Change subject: mt-rowset_delta_compaction-test: remove dead code
......................................................................
Patch Set 1: Code-Review+2
Whoops, accidentally removed Alexey instead of Jenkins.
--
To view, visit http://gerrit.cloudera.org:8080/11824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ce38fc2555f05ab5401fc56d4c5dca20258d436
Gerrit-Change-Number: 11824
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 30 Oct 2018 21:00:16 +0000
Gerrit-HasComments: No
[kudu-CR] mt-rowset delta compaction-test: remove dead code
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11824 )
Change subject: mt-rowset_delta_compaction-test: remove dead code
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I9ce38fc2555f05ab5401fc56d4c5dca20258d436
Gerrit-Change-Number: 11824
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>