You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/17 15:59:16 UTC

[GitHub] [airflow] turbaszek commented on a change in pull request #14276: Refactor Gdrive to GCS operator

turbaszek commented on a change in pull request #14276:
URL: https://github.com/apache/airflow/pull/14276#discussion_r577732898



##########
File path: airflow/providers/google/cloud/transfers/gdrive_to_gcs.py
##########
@@ -74,8 +73,8 @@ class GoogleDriveToGCSOperator(BaseOperator):
     def __init__(
         self,
         *,
-        destination_bucket: str,
-        destination_object: str,
+        bucket_name: str,
+        object_name: str,

Review comment:
       This is a breaking change. While I agree that you suggestion is reasonable and I support it we will need to keep old arguments to preserve backward compatibly and we need to add deprecation warning. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org